Skip to contentSkip to conversation

recording gain control

PATCH In review Viral Mehta 3 participants 5 messages Mar 10, 2009

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 recording gain control

Hi,

I am trying to do gain control while RECORDING for my Audio Mic device.

My application opens /dev/mixer device and calls ioctl(fdmixer, MIXER_WRITE(SOUND_MIXER_MIC), ...)

But, the call fails. It traces to sound/core/oss/mixer_oss.c file and snd_mixer_oss_put_volume1() function.
It never falls in "if (slot->present & SNDRV_MIXER_OSS_PRESENT_CVOLUME)" as condition "if (slot->present & SNDRV_MIXER_OSS_PRESENT_PVOLUME) " comes as false.

I think there is a bug in kernel and I think it should be like as below,

core/oss/mixer_oss.c 2009-03-09 16:22:06.548766896 +0530 renamed from core/oss/mixer_oss.c 2008-12-03 13:24:02.000000000 +0530 +0 -0
@@ -688,7 +688,7 @@ static int snd_mixer_oss_put_volume1(str
 
    if (slot->present & SNDRV_MIXER_OSS_PRESENT_PVOLUME) {
            snd_mixer_oss_put_volume1_vol(fmixer, pslot, 

slot->numid[SNDRV_MIXER_OSS_ITEM_PVOLUME], left, right);
- if (slot->present & SNDRV_MIXER_OSS_PRESENT_CVOLUME)
+ } else if (slot->present & SNDRV_MIXER_OSS_PRESENT_CVOLUME) {
snd_mixer_oss_put_volume1_vol(fmixer, pslot,

slot->numid[SNDRV_MIXER_OSS_ITEM_CVOLUME], left, right);
    } else if (slot->present & SNDRV_MIXER_OSS_PRESENT_GVOLUME) {
            snd_mixer_oss_put_volume1_vol(fmixer, pslot, 

slot->numid[SNDRV_MIXER_OSS_ITEM_GVOLUME], left, right);

Thanks,
Viral

Signature · 15 lines
_____________________________________________________________________
Disclaimer: This e-mail message and all attachments transmitted with it
are intended solely for the use of the addressee and may contain legally
privileged and confidential information. If the reader of this message
is not the intended recipient, or an employee or agent responsible for
delivering this message to the intended recipient, you are hereby
notified that any dissemination, distribution, copying, or other use of
this message or its attachments is strictly prohibited. If you have
received this message in error, please notify the sender immediately by
replying to this message and please delete it from your computer. Any
views expressed in this message are those of the individual sender
unless otherwise stated.Company has taken enough precautions to prevent
the spread of viruses. However the company accepts no liability for any
damage caused by any virus transmitted by this email.
__________________________________________________________________________
#1 lore raw

(CC alsa-devel)

Quoted 28 lines · Viral Mehta

Hi,

I am trying to do gain control while RECORDING for my Audio Mic device.

My application opens /dev/mixer device and calls ioctl(fdmixer, MIXER_WRITE(SOUND_MIXER_MIC), ...)

But, the call fails. It traces to sound/core/oss/mixer_oss.c file and snd_mixer_oss_put_volume1() function.
It never falls in "if (slot->present & SNDRV_MIXER_OSS_PRESENT_CVOLUME)" as condition "if (slot->present & SNDRV_MIXER_OSS_PRESENT_PVOLUME) " comes as false.

I think there is a bug in kernel and I think it should be like as below,

core/oss/mixer_oss.c 2009-03-09 16:22:06.548766896 +0530 renamed from core/oss/mixer_oss.c 2008-12-03 13:24:02.000000000 +0530 +1 -1
@@ -688,7 +688,7 @@ static int snd_mixer_oss_put_volume1(str
 
     if (slot->present & SNDRV_MIXER_OSS_PRESENT_PVOLUME) {
             snd_mixer_oss_put_volume1_vol(fmixer, pslot, 
 slot->numid[SNDRV_MIXER_OSS_ITEM_PVOLUME], left, right);
-               if (slot->present & SNDRV_MIXER_OSS_PRESENT_CVOLUME)
+       } else if (slot->present & SNDRV_MIXER_OSS_PRESENT_CVOLUME) {
                     snd_mixer_oss_put_volume1_vol(fmixer, pslot, 
 slot->numid[SNDRV_MIXER_OSS_ITEM_CVOLUME], left, right);
     } else if (slot->present & SNDRV_MIXER_OSS_PRESENT_GVOLUME) {
             snd_mixer_oss_put_volume1_vol(fmixer, pslot, 
Quoted 1 line

slot->numid[SNDRV_MIXER_OSS_ITEM_GVOLUME], left, right);

Your mailer mangled the patch; see linux/Documentation/email-clients.txt.

Best regards,
Clemens

#2 lore raw

At Tue, 10 Mar 2009 10:00:13 +0100,

Quoted 23 lines · Clemens Ladisch

(CC alsa-devel)

Quoted 19 lines · Viral Mehta

Hi,

I am trying to do gain control while RECORDING for my Audio Mic device.

My application opens /dev/mixer device and calls ioctl(fdmixer, MIXER_WRITE(SOUND_MIXER_MIC), ...)

But, the call fails. It traces to sound/core/oss/mixer_oss.c file and snd_mixer_oss_put_volume1() function.
It never falls in "if (slot->present & SNDRV_MIXER_OSS_PRESENT_CVOLUME)" as condition "if (slot->present & SNDRV_MIXER_OSS_PRESENT_PVOLUME) " comes as false.

I think there is a bug in kernel and I think it should be like as below,

core/oss/mixer_oss.c 2009-03-09 16:22:06.548766896 +0530 renamed from core/oss/mixer_oss.c 2008-12-03 13:24:02.000000000 +0530 +0 -0
@@ -688,7 +688,7 @@ static int snd_mixer_oss_put_volume1(str
 
Quoted 12 lines
Quoted 10 lines
core/oss/mixer_oss.c 2009-03-09 16:22:06.548766896 +0530 renamed from core/oss/mixer_oss.c 2008-12-03 13:24:02.000000000 +0530 +1 -1
     if (slot->present & SNDRV_MIXER_OSS_PRESENT_PVOLUME) {
             snd_mixer_oss_put_volume1_vol(fmixer, pslot, 
 slot->numid[SNDRV_MIXER_OSS_ITEM_PVOLUME], left, right);
-               if (slot->present & SNDRV_MIXER_OSS_PRESENT_CVOLUME)
+       } else if (slot->present & SNDRV_MIXER_OSS_PRESENT_CVOLUME) {
                     snd_mixer_oss_put_volume1_vol(fmixer, pslot, 
 slot->numid[SNDRV_MIXER_OSS_ITEM_CVOLUME], left, right);
     } else if (slot->present & SNDRV_MIXER_OSS_PRESENT_GVOLUME) {
             snd_mixer_oss_put_volume1_vol(fmixer, pslot, 

slot->numid[SNDRV_MIXER_OSS_ITEM_GVOLUME], left, right);

Your mailer mangled the patch; see linux/Documentation/email-clients.txt.

Also, the current code behaves intentionally so (as it's designed for mic-loopback volume).

A more feasible fix would be to add another if check for *_CVOLUME instead of moving it.

Takashi

#3 lore raw
Quoted 40 lines · Takashi Iwai

At Tue, 10 Mar 2009 10:00:13 +0100,

Quoted 23 lines · Clemens Ladisch

(CC alsa-devel)

Quoted 19 lines · Viral Mehta

Hi,

I am trying to do gain control while RECORDING for my Audio Mic device.

My application opens /dev/mixer device and calls ioctl(fdmixer, MIXER_WRITE(SOUND_MIXER_MIC), ...)

But, the call fails. It traces to sound/core/oss/mixer_oss.c file and snd_mixer_oss_put_volume1() function.
It never falls in "if (slot->present & SNDRV_MIXER_OSS_PRESENT_CVOLUME)" as condition "if (slot->present & SNDRV_MIXER_OSS_PRESENT_PVOLUME) " comes as false.

I think there is a bug in kernel and I think it should be like as below,

core/oss/mixer_oss.c 2009-03-09 16:22:06.548766896 +0530 renamed from core/oss/mixer_oss.c 2008-12-03 13:24:02.000000000 +0530 +0 -0
@@ -688,7 +688,7 @@ static int snd_mixer_oss_put_volume1(str
 
Quoted 13 lines
Quoted 11 lines
core/oss/mixer_oss.c 2009-03-09 16:22:06.548766896 +0530 renamed from core/oss/mixer_oss.c 2008-12-03 13:24:02.000000000 +0530 +1 -1
     if (slot->present & SNDRV_MIXER_OSS_PRESENT_PVOLUME) {
             snd_mixer_oss_put_volume1_vol(fmixer, pslot, 
 slot->numid[SNDRV_MIXER_OSS_ITEM_PVOLUME], left, right);
-               if (slot->present & SNDRV_MIXER_OSS_PRESENT_CVOLUME)
+       } else if (slot->present & SNDRV_MIXER_OSS_PRESENT_CVOLUME) {
                     snd_mixer_oss_put_volume1_vol(fmixer, pslot, 
 slot->numid[SNDRV_MIXER_OSS_ITEM_CVOLUME], left, right);
     } else if (slot->present & SNDRV_MIXER_OSS_PRESENT_GVOLUME) {
             snd_mixer_oss_put_volume1_vol(fmixer, pslot, 

slot->numid[SNDRV_MIXER_OSS_ITEM_GVOLUME], left, right);

Your mailer mangled the patch; see linux/Documentation/email-clients.txt.

Quoted 8 lines

Also, the current code behaves intentionally so (as it's designed for mic-loopback volume).

A more feasible fix would be to add another if check for *_CVOLUME instead of moving it.

Oh okie. It makes sense.
I just sent out a patch on LAD. Should I resubmit with what you proposed ?

Quoted 12 lines

Takashi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Email Scanned for Virus & Dangerous Content by : www.CleanMailGateway.com

Signature · 15 lines
_____________________________________________________________________
Disclaimer: This e-mail message and all attachments transmitted with it
are intended solely for the use of the addressee and may contain legally
privileged and confidential information. If the reader of this message
is not the intended recipient, or an employee or agent responsible for
delivering this message to the intended recipient, you are hereby
notified that any dissemination, distribution, copying, or other use of
this message or its attachments is strictly prohibited. If you have
received this message in error, please notify the sender immediately by
replying to this message and please delete it from your computer. Any
views expressed in this message are those of the individual sender
unless otherwise stated.Company has taken enough precautions to prevent
the spread of viruses. However the company accepts no liability for any
damage caused by any virus transmitted by this email.
__________________________________________________________________________
#4 lore raw

At Tue, 10 Mar 2009 17:52:46 +0530,

Quoted 45 lines · Viral Mehta
Quoted 43 lines · Takashi Iwai

At Tue, 10 Mar 2009 10:00:13 +0100,

Quoted 23 lines · Clemens Ladisch

(CC alsa-devel)

Quoted 19 lines · Viral Mehta

Hi,

I am trying to do gain control while RECORDING for my Audio Mic device.

My application opens /dev/mixer device and calls ioctl(fdmixer, MIXER_WRITE(SOUND_MIXER_MIC), ...)

But, the call fails. It traces to sound/core/oss/mixer_oss.c file and snd_mixer_oss_put_volume1() function.
It never falls in "if (slot->present & SNDRV_MIXER_OSS_PRESENT_CVOLUME)" as condition "if (slot->present & SNDRV_MIXER_OSS_PRESENT_PVOLUME) " comes as false.

I think there is a bug in kernel and I think it should be like as below,

core/oss/mixer_oss.c 2009-03-09 16:22:06.548766896 +0530 renamed from core/oss/mixer_oss.c 2008-12-03 13:24:02.000000000 +0530 +0 -0
@@ -688,7 +688,7 @@ static int snd_mixer_oss_put_volume1(str
 
Quoted 13 lines
Quoted 11 lines
core/oss/mixer_oss.c 2009-03-09 16:22:06.548766896 +0530 renamed from core/oss/mixer_oss.c 2008-12-03 13:24:02.000000000 +0530 +1 -1
     if (slot->present & SNDRV_MIXER_OSS_PRESENT_PVOLUME) {
             snd_mixer_oss_put_volume1_vol(fmixer, pslot, 
 slot->numid[SNDRV_MIXER_OSS_ITEM_PVOLUME], left, right);
-               if (slot->present & SNDRV_MIXER_OSS_PRESENT_CVOLUME)
+       } else if (slot->present & SNDRV_MIXER_OSS_PRESENT_CVOLUME) {
                     snd_mixer_oss_put_volume1_vol(fmixer, pslot, 
 slot->numid[SNDRV_MIXER_OSS_ITEM_CVOLUME], left, right);
     } else if (slot->present & SNDRV_MIXER_OSS_PRESENT_GVOLUME) {
             snd_mixer_oss_put_volume1_vol(fmixer, pslot, 

slot->numid[SNDRV_MIXER_OSS_ITEM_GVOLUME], left, right);

Your mailer mangled the patch; see linux/Documentation/email-clients.txt.

Also, the current code behaves intentionally so (as it's designed for mic-loopback volume).

Quoted 7 lines
Quoted 5 lines

A more feasible fix would be to add another if check for *_CVOLUME instead of moving it.

Oh okie. It makes sense.
I just sent out a patch on LAD. Should I resubmit with what you proposed ?

LAD is no good place for sending a patch of sound driver. Please post to alsa-devel ML (and add Cc to me).

thanks,

Takashi