Skip to contentSkip to conversation

make qemu_announce_self handle non contiguous net tables

PATCH Applied Marcelo Tosatti 2 participants 2 messages Mar 11, 2009 – Mar 13, 2009

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 make qemu_announce_self handle non contiguous net tables

With hotplug nd_table might contain holes.

Noticed by Eduardo Habkost.

savevm.c +3 -1
Index: savevm.c
===================================================================
@@ -122,7 +122,9 @@
     VLANClientState *vc;
     uint8_t buf[256];
 
-    for (i = 0; i < nb_nics; i++) {
+    for (i = 0; i < MAX_NICS; i++) {
+        if (!nd_table[i].used)
+            continue;
         len = announce_self_create(buf, nd_table[i].macaddr);
         vlan = nd_table[i].vlan;
         for(vc = vlan->first_client; vc != NULL; vc = vc->next) {
#1 lore raw
Quoted 6 lines · Marcelo Tosatti

With hotplug nd_table might contain holes.

Noticed by Eduardo Habkost.

Applied to both trunk and stable. Thanks.

Regards,

Anthony Liguori

Quoted 19 lines

Index: savevm.c
===================================================================

savevm.c +3 -1
@@ -122,7 +122,9 @@
     VLANClientState *vc;
     uint8_t buf[256];
 
-    for (i = 0; i < nb_nics; i++) {
+    for (i = 0; i < MAX_NICS; i++) {
+        if (!nd_table[i].used)
+            continue;
         len = announce_self_create(buf, nd_table[i].macaddr);
         vlan = nd_table[i].vlan;
         for(vc = vlan->first_client; vc != NULL; vc = vc->next) {