kfree(napi->skb) => kfree_skb
Subsystems (2)
PATCH 1/1 kfree(napi->skb) => kfree_skb
struct sk_buff pointers should be freed with kfree_skb.
---
@@ -2669,11 +2669,11 @@ EXPORT_SYMBOL(netif_napi_add);
void netif_napi_del(struct napi_struct *napi) {
struct sk_buff *skb, *next;
list_del_init(&napi->dev_list);
- kfree(napi->skb);
+ kfree_skb(napi->skb);
for (skb = napi->gro_list; skb; skb = next) {
next = skb->next;
skb->next = NULL; kfree_skb(skb);
David Miller
maintainerFrom: Roel Kluin <[email protected]>
Date: Tue, 17 Mar 2009 11:38:25 +0100
Review EXPORT_SYMBOL(netif_napi_add); · line 2670
Quoted 7 lines
struct
sk_buffpointers should be freed withkfree_skb.Signed-off-by Roel Kluin <[email protected]>---
(quoted diff) +0
-0@@ -2669,11 +2669,11 @@ EXPORT_SYMBOL(netif_napi_add); void netif_napi_del(struct napi_struct *napi) {
Roel, what did you use to generate this patch? :-/
If you hand-edited the patch, please check your work before sending it out.
David Miller
maintainerFrom: David Miller <[email protected]>
Date: Wed, 18 Mar 2009 23:10:43 -0700 (PDT)
Quoted 13 lines
From: Roel Kluin <[email protected]>
Date: Tue, 17 Mar 2009 11:38:25 +0100Review EXPORT_SYMBOL(netif_napi_add); · line 2670
Quoted 7 lines
struct
sk_buffpointers should be freed withkfree_skb.Signed-off-by Roel Kluin <[email protected]>---
(quoted diff) +0
-0@@ -2669,11 +2669,11 @@ EXPORT_SYMBOL(netif_napi_add); void netif_napi_del(struct napi_struct *napi) {Roel, what did you use to generate this patch? :-/
Quoted 2 lines
If you hand-edited the patch, please check your work before sending it out.
Don't bother resending Roel, I took care of it by hand.
Nobody is doing anything reasonably today, so I am just going to start doing everything myself like I always seem to end up doing :-/
Today sucks... so... much...