spider_net:remove '&' in the init of function pointers
Subsystems (2)
PATCH 1/1 spider_net:remove '&' in the init of function pointers
Do not need '&' in the init of function pointers.
--- drivers/net/spider_net.c | 18 +++++++++--------- 1 files changed, 9 insertions(+), 9 deletions(-)
drivers/net/spider_net.c +9 -9
@@ -2268,20 +2268,20 @@ spider_net_tx_timeout(struct net_device *netdev)static void spider_net_setup_netdev_ops (struct net_device *netdev) { - netdev->open = &spider_net_open; - netdev->stop = &spider_net_stop; - netdev->hard_start_xmit = &spider_net_xmit; - netdev->set_multicast_list = &spider_net_set_multi; - netdev->set_mac_address = &spider_net_set_mac; - netdev->change_mtu = &spider_net_change_mtu; - netdev->do_ioctl = &spider_net_do_ioctl; + netdev->open = spider_net_open; + netdev->stop = spider_net_stop; + netdev->hard_start_xmit = spider_net_xmit; + netdev->set_multicast_list = spider_net_set_multi; + netdev->set_mac_address = spider_net_set_mac; + netdev->change_mtu = spider_net_change_mtu; + netdev->do_ioctl = spider_net_do_ioctl;/* tx watchdog */ - netdev->tx_timeout = &spider_net_tx_timeout; + netdev->tx_timeout = spider_net_tx_timeout; netdev->watchdog_timeo =SPIDER_NET_WATCHDOG_TIMEOUT ;/* HW VLAN */ #ifdef CONFIG_NET_POLL_CONTROLLER /* poll controller */ - netdev->poll_controller = &spider_net_poll_controller; + netdev->poll_controller = spider_net_poll_controller;#endif /* CONFIG_NET_POLL_CONTROLLER */ /* ethtool ops */ netdev->ethtool_ops = &spider_net_ethtool_ops;
Signature · 5 lines
1.6.0.3 -- Regards Yang Hongyang
David Miller
maintainerFrom: Yang Hongyang <[email protected]>
Date: Fri, 20 Mar 2009 16:18:37 +0800
Quoted 3 lines
Do not need '&' in the init of function pointers.
Signed-off-by Yang Hongyang <[email protected]>
It's harmless, just leave it alone. This is just going to be commit noise.
More useful would be to convert this driver over to net_device_ops.
I'm not applying this.
Quoted 9 lines · David Miller
From: Yang Hongyang <[email protected]>
Date: Fri, 20 Mar 2009 16:18:37 +0800Quoted 3 lines
Do not need '&' in the init of function pointers.
Signed-off-by Yang Hongyang <[email protected]>It's harmless, just leave it alone. This is just going to be commit noise.
OK.
Quoted 6 lines
More useful would be to convert this driver over to
net_device_ops.I'm not applying this.
Signature · 2 lines
Regards Yang Hongyang
Quoted 11 lines · David Miller
From: Yang Hongyang <[email protected]>
Date: Fri, 20 Mar 2009 16:18:37 +0800Quoted 3 lines
Do not need '&' in the init of function pointers.
Signed-off-by Yang Hongyang <[email protected]>It's harmless, just leave it alone. This is just going to be commit noise.
More useful would be to convert this driver over to
net_device_ops.
I'll do that.
Quoted 4 lines
I'm not applying this.
Signature · 2 lines
Regards Yang Hongyang