Skip to contentSkip to conversation

trivial: remove warning from arch/x86/kernel/kprobes.c

PATCH In review Frank Seidel 3 participants 4 messages Mar 25, 2009 x86

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 trivial: remove warning from arch/x86/kernel/kprobes.c

From: Frank Seidel <[email protected]>

Remove warning (makes integer from pointer without a cast) from build messages.

---
 arch/x86/kernel/kprobes.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/x86/kernel/kprobes.c +1 -1
@@ -193,7 +193,7 @@ static int __kprobes can_boost(kprobe_op
 	kprobe_opcode_t opcode;
 	kprobe_opcode_t *orig_opcodes = opcodes;
 
-	if (search_exception_tables(opcodes))
+	if (search_exception_tables((unsigned long)opcodes))
 		return 0;	/* Page fault may occur on this address. */
 
 retry:
#1 lore raw
Quoted 13 lines · Frank Seidel

From: Frank Seidel <[email protected]>

Remove warning (makes integer from pointer without a cast) from build messages.

---
 arch/x86/kernel/kprobes.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

arch/x86/kernel/kprobes.c static int __kprobes can_boost(kprobe_op · line 197

Quoted 6 lines
arch/x86/kernel/kprobes.c +1 -1
@@ -193,7 +193,7 @@ static int __kprobes can_boost(kprobe_op
 	kprobe_opcode_t opcode;
 	kprobe_opcode_t *orig_opcodes = opcodes;
 
-	if (search_exception_tables(opcodes))
+	if (search_exception_tables((unsigned long)opcodes))
 		return 0;	/* Page fault may occur on this address. */

fixed in the x86 tree:

http://people.redhat.com/mingo/tip.git/README

a couple of days ago. (see the commit below)

Ingo

---------->

Quoted 1 line

From cde5edbda8ba7d600154ce4171125a48e4d2a21b Mon Sep 17 00:00:00 2001

From: Jaswinder Singh Rajput <[email protected]>
Date: Wed, 18 Mar 2009 17:37:45 +0530
Subject: [PATCH] x86: kprobes.c fix compilation warning
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit

arch/x86/kernel/kprobes.c:196: warning: passing argument 1 of ‘search_exception_tables’ makes integer from pointer without a cast

LKML-Reference:<[email protected]>
LKML-Reference: <[email protected]>

---
 arch/x86/kernel/kprobes.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
arch/x86/kernel/kprobes.c +1 -1
index 4558dd3..55b9461 100644
@@ -193,7 +193,7 @@ static int __kprobes can_boost(kprobe_opcode_t *opcodes)
 	kprobe_opcode_t opcode;
 	kprobe_opcode_t *orig_opcodes = opcodes;
 
-	if (search_exception_tables(opcodes))
+	if (search_exception_tables((unsigned long)opcodes))
 		return 0;	/* Page fault may occur on this address. */
 
 retry:
#2 lore raw

Ingo Molnar wrote.

Quoted 1 line

fixed in the x86 tree:

Oops, ok, sorry for the noise..

Frank

#3 lore raw
Quoted 4 lines · Frank Seidel

Ingo Molnar wrote.

Quoted 1 line

fixed in the x86 tree:

Oops, ok, sorry for the noise..

Anyway, thank you for fixing!

Signature · 7 lines
Masami Hiramatsu

Software Engineer
Hitachi Computer Products (America) Inc.
Software Solutions Division

e-mail: [email protected]