reiserfs: select CRC32 and BITREVERSE for REISERFS_FS Kconfig entry
PATCH 1/1 reiserfs: select CRC32 and BITREVERSE for REISERFS_FS Kconfig entry
In patch fs-reiserfs-return-f_fsid-for-statfs2-v2.patch (from mmotm), crc32_le() is referenced. If reiserfs is compiled into kernel and crc32_le() is compiled as kernel module, there might be a compiling error as:
fs/built-in.o: In function `reiserfs_statfs':
super.c:(.text+0x7332b): undefined reference to `crc32_le'
super.c:(.text+0x7333f): undefined reference to `crc32_le'This patch select CRC32 and BITREVERSE for REISERFS_FS Kconfig entry, which indicates compiling crc32_le() into kernel.
Thanks to Randy Dunlap for pointing out this error and providing helpful solution.
--- fs/reiserfs/Kconfig | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-)
fs/reiserfs/Kconfig +2 -0
@@ -1,5 +1,7 @@ config REISERFS_FS tristate "Reiserfs support" + select CRC32 + select BITREVERSE help Stores not just filenames but the files themselves in a balanced tree. Uses journalling.
Signature · 2 lines
Coly Li SuSE Labs
Quoted 6 lines · Coly Li
In patch fs-reiserfs-return-f_fsid-for-statfs2-v2.patch (from mmotm),
crc32_le()is referenced. If reiserfs is compiled into kernel andcrc32_le()is compiled as kernel module, there might be a compiling error as:fs/built-in.o: In function `reiserfs_statfs': super.c:(.text+0x7332b): undefined reference to `crc32_le' super.c:(.text+0x7333f): undefined reference to `crc32_le'
Quoted 7 lines
This patch select CRC32 and BITREVERSE for
REISERFS_FSKconfigentry, which indicates compilingcrc32_le()into kernel.Thanks to Randy Dunlap for pointing out this error and providing helpful solution.
Signed-off-by Coly Li <[email protected]>Cc Randy Dunlap <[email protected]>
Thanks.
Quoted 17 lines
Cc Andrew Morton <[email protected]>--- fs/reiserfs/Kconfig | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-)fs/reiserfs/Kconfig +2
-0@@ -1,5 +1,7 @@ config REISERFS_FS tristate "Reiserfs support" + select CRC32 + select BITREVERSE help Stores not just filenames but the files themselves in a balanced tree. Uses journalling.
Signature · 1 line
~Randy
Randy Dunlap Wrote:
Quoted 10 lines
Quoted 9 lines · Coly Li
In patch fs-reiserfs-return-f_fsid-for-statfs2-v2.patch (from mmotm),
crc32_le()is referenced. If reiserfs is compiled into kernel andcrc32_le()is compiled as kernel module, there might be a compiling error as:fs/built-in.o: In function `reiserfs_statfs': super.c:(.text+0x7332b): undefined reference to `crc32_le' super.c:(.text+0x7333f): undefined reference to `crc32_le'This patch select CRC32 and BITREVERSE for
REISERFS_FSKconfigentry, which indicates compilingcrc32_le()into kernel.
Quoted 7 lines
Quoted 4 lines
Thanks to Randy Dunlap for pointing out this error and providing helpful solution.
Signed-off-by Coly Li <[email protected]>Cc Randy Dunlap <[email protected]>Acked-by Randy Dunlap <[email protected]>Tested-by Randy Dunlap <[email protected]>
Hi Randy,
You give me an important enlightenment, for my return-f_fsid-for-statfs2 patch serial, selecting CRC32 and BITREVERSE is necessary ...
Andrew,
I will check it and send out fix ASAP.
Thanks.
Signature · 2 lines
Coly Li SuSE Labs
Randy Dunlap Wrote:
Quoted 12 lines
Quoted 11 lines · Coly Li
In patch fs-reiserfs-return-f_fsid-for-statfs2-v2.patch (from mmotm),
crc32_le()is referenced. If reiserfs is compiled into kernel andcrc32_le()is compiled as kernel module, there might be a compiling error as:fs/built-in.o: In function `reiserfs_statfs': super.c:(.text+0x7332b): undefined reference to `crc32_le' super.c:(.text+0x7333f): undefined reference to `crc32_le'This patch select CRC32 and BITREVERSE for
REISERFS_FSKconfigentry, which indicates compilingcrc32_le()into kernel.Thanks to Randy Dunlap for pointing out this error and providing helpful solution.
Quoted 8 lines
Quoted 2 lines
Signed-off-by Coly Li <[email protected]>Cc Randy Dunlap <[email protected]>Acked-by Randy Dunlap <[email protected]>Tested-by Randy Dunlap <[email protected]>Thanks.
Hi Randy,
I just find only select CRC32 is enough, because crc32 code in sequence selects BITREVERSE in lib/Kconfig. I verified it on my x86_64 machine.
BTW, in mmotm, only fs-reiserfs-return-f_fsid-for-statfs2-v2.patch of the return-f_fsid-for-statfs2 patch serial which calls crc32_le(). Therefore I will not update other patches and only merge the modification of fs/reiserfs/Kconfig to fs-reiserfs-return-f_fsid-for-statfs2-v3.patch. I will Cc you as well.
Thanks.
Quoted 19 lines
Quoted 17 lines
Cc Andrew Morton <[email protected]>--- fs/reiserfs/Kconfig | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-)fs/reiserfs/Kconfig +2
-0@@ -1,5 +1,7 @@ config REISERFS_FS tristate "Reiserfs support" + select CRC32 + select BITREVERSE help Stores not just filenames but the files themselves in a balanced tree. Uses journalling.
Signature · 2 lines
Coly Li SuSE Labs