Add host-libglib2 dependencie to dbus-glib

Hello,

I need the small patch below to successfully buils the dbus-glib. This was tested on a board that is almost like the AT91SAM9261EK, although I don't think it matter for this kind of problem. Without the patch the error was:

(cd /home/xxx/buildroot/build_arm/dbus-glib-0.80-host; [...]
[...]
checking pkg-config is at least version 0.9.0... yes
checking for DBUS... yes
checking for DBUS_GLIB... no
checking for DBUS_GLIB_THREADS... no
configure: error: GLib development libraries not found
make: *** [/home/xxx/buildroot/build_arm/dbus-glib-0.80-host/.configured] Error 1

Index: package/dbus-glib/dbus-glib.mk
===================================================================
@@ -23,7 +23,7 @@
                --disable-doxygen-docs \
                --enable-asserts=yes
 
-DBUS_GLIB_DEPENDENCIES = uclibc host-pkgconfig dbus host-dbus host-dbus-glib libglib2
+DBUS_GLIB_DEPENDENCIES = uclibc host-pkgconfig dbus host-dbus host-libglib2 host-dbus-glib libglib2
 
 $(eval $(call AUTOTARGETS,package,dbus-glib))
 

Best Regards,

Jean-Christian de Rivaz

Hi,

I just had the same problem when trying to compile trunk for i686. However, after applying the fix I got an error about missing '-lexpat'. Adding expat to the dependencies fixed that.

Hi,

There is expat in the dependencies already:

ifeq ($(BR2_DBUS_EXPAT),y)
DBUS_CONF_OPT += --with-xml=expat
DBUS_DEPENDENCIES += expat
else
DBUS_CONF_OPT += --with-xml=libxml
DBUS_DEPENDENCIES += libxml2
endif

We are using libxml2, so I can't tell for sure if compiling dbus with expat is working or not. But it looks as if the dependencies are correct.

Sven

Ah...but this is in dbus.mk, not dbus-glib.mk which gives the error.

Anyway, hal also fails to compile so I will skip the dbus stuff..

Hi,

Ah, but shouldn't dbus-glib depend on dbus already? Perhaps dbus-glib is picking up wrong linker flags. I guess it might help to port dbus-glib to Makefile.autotools.in.

Sven

Sven Neumann a ?crit :

Interesting. On ARM I can only build dbus with expat.

BR2_PACKAGE_DBUS=y
BR2_DBUS_EXPAT=y
# BR2_DBUS_LIBXML2 is not set
BR2_PACKAGE_DBUS_GLIB=y

Jean-Christian de Rivaz

Hi,

This works for us:

BR2_iwmmxt=y
BR2_ARM_TYPE="ARM_IWMMXT"
# BR2_ARM_OABI is not set
BR2_ARM_EABI=y
BR2_ARCH="arm"
BR2_ENDIAN="LITTLE"
BR2_GCC_TARGET_TUNE="iwmmxt"
BR2_GCC_TARGET_ARCH="iwmmxt"
BR2_GCC_TARGET_ABI="aapcs-linux"

BR2_PACKAGE_DBUS=y
# BR2_DBUS_EXPAT is not set
BR2_DBUS_LIBXML2=y
BR2_PACKAGE_DBUS_GLIB=y

Sven

Jean-Christian> Interesting. On ARM I can only build dbus with expat.

Jean-Christian> BR2_PACKAGE_DBUS=y
Jean-Christian> BR2_DBUS_EXPAT=y
Jean-Christian> # BR2_DBUS_LIBXML2 is not set
Jean-Christian> BR2_PACKAGE_DBUS_GLIB=y

What happens when you try building it with libxml2? I fixed a build issue with libxml2 in February.

Bye, Peter Korsgaard

Is there a buildroot user mail list where I might get assistance but not disturb the developers? I looked but could not find so, apologies ...

I am using buildroot 2009.02 release and have successfully produced a linux kernel, rootfs and cross tool kit for a 486 SX PC104 PC104 CPU. I need to apply a patch to the 2.6.24 kernel and have initially used a kernel .config provided by the PC104 manufacturer which I did by manually applying the patch in project_build_486/uclibc/linux-2.6.24 and copying the kernel .config there too. I can see that there is support in the buildroot menu Kernel->Patches for Additional patch to apply (from $(DL_DIR)) but when I put the kernel patch file in /dl and entered the filename in the menu configuration buildroot complained:

Make: *** No rule to make target 'patch-2.4.6-DMP', needed by '../project_build_i486/uclibc/linux-2.6.24/.patched'. Stop.

Your assistance to better understand how to get buildroot to automatically apply a kernel patch would be appreciated.

Regards

Will

Peter Korsgaard a ?crit :

Well, it take me some time to do the test because my original buildroot folder was not clean enough. I have checked out the revision 26186 from the buildroot SVN and I have copied it into 4 folders in order to test without and with the patch and using expat or libxml2. The short answer is that for my configuration only the folder with the patch and using expat do the build successfully.

Without the patch, using expat or libxml2, let the build fail with this error into the make of dbus-1.2.12-host:

[...]
checking for gmsgfmt... /usr/bin/msgfmt
checking for xgettext... /usr/bin/xgettext
checking for XML_ParserCreate_MM in -lexpat... yes
checking expat.h usability... yes
checking expat.h presence... yes
checking for expat.h... yes
checking pkg-config is at least version 0.9.0... yes
checking for DBUS... yes
checking for DBUS_GLIB... no
checking for DBUS_GLIB_THREADS... no
configure: error: GLib development libraries not found
make: *** [/home/jcdr/try/buildroot-svn-expat/build_arm/stamps/host_dbusglib_configured] Erreur 1

It worth noticed that even if libxml2 is used, the dbus-1.2.12-host configure log the same messages about expat and no one about libxml2.

The two others folders have this patch applyed:
------------------------------------------------

Index: package/dbus-glib/dbus-glib.mk
===================================================================
@@ -23,7 +23,7 @@
                --disable-doxygen-docs \
                --enable-asserts=yes
 
-DBUS_GLIB_DEPENDENCIES = uclibc host-pkgconfig dbus host-dbus host-dbus-glib libglib2
+DBUS_GLIB_DEPENDENCIES = uclibc host-pkgconfig dbus host-dbus host-libglib2 host-dbus-glib libglib2
 
 $(eval $(call AUTOTARGETS,package,dbus-glib))
 

------------------------------------------------

Now using libxml2 let the build fail with this error into the make of dbus-glib:

[...]
checking for ngettext in -lintl... yes
checking for dgettext in -lintl... yes
checking for bind_textdomain_codeset... yes
checking for msgfmt... /usr/bin/msgfmt
checking for dcgettext... yes
checking if msgfmt accepts -c... yes
checking for gmsgfmt... /usr/bin/msgfmt
checking for xgettext... /usr/bin/xgettext
checking for XML_ParserCreate_MM in -lexpat... no
configure: error: expat library not found, check config.log for failed attempts
make: *** [/home/jcdr/try/buildroot-svn-dep-libxml2/build_arm/dbus-glib-0.80/.stamp_configured] Erreur 1

Jean-Christian de Rivaz

Hi,

Jean-Christian> Without the patch, using expat or libxml2, let the Jean-Christian> build fail with this error into the make of Jean-Christian> dbus-1.2.12-host:

I take it you mean dbus-glib-host from the below.

Jean-Christian> [...]
Jean-Christian> checking for gmsgfmt... /usr/bin/msgfmt
Jean-Christian> checking for xgettext... /usr/bin/xgettext
Jean-Christian> checking for XML_ParserCreate_MM in -lexpat... yes
Jean-Christian> checking expat.h usability... yes
Jean-Christian> checking expat.h presence... yes
Jean-Christian> checking for expat.h... yes
Jean-Christian> checking pkg-config is at least version 0.9.0... yes
Jean-Christian> checking for DBUS... yes
Jean-Christian> checking for DBUS_GLIB... no
Jean-Christian> checking for DBUS_GLIB_THREADS... no
Jean-Christian> configure: error: GLib development libraries not found
Jean-Christian> make: *** [/home/jcdr/try/buildroot-svn-expat/build_arm/stamps/host_dbusglib_configured] Erreur 1

Ahh, I thought you had a problem building dbus for the target, not dbus-glib for the host. I see the missing dependency on host-glib and will fix shortly.

Jean-Christian> It worth noticed that even if libxml2 is used, the Jean-Christian> dbus-1.2.12-host configure log the same messages Jean-Christian> about expat and no one about libxml2.

Yes, we always build the host dbus version with expat support for simplicity.

Jean-Christian> The two others folders have this patch applyed:
Jean-Christian> ------------------------------------------------ Jean-Christian> Index: package/dbus-glib/dbus-glib.mk
Jean-Christian> ===================================================================
Jean-Christian> --- package/dbus-glib/dbus-glib.mk (r?vision 26188)
Jean-Christian> +++ package/dbus-glib/dbus-glib.mk (copie de travail)
Jean-Christian> @@ -23,7 +23,7 @@
Jean-Christian> --disable-doxygen-docs \
Jean-Christian> --enable-asserts=yes

Jean-Christian> -DBUS_GLIB_DEPENDENCIES = uclibc host-pkgconfig dbus host-dbus host-dbus-glib libglib2 Jean-Christian> +DBUS_GLIB_DEPENDENCIES = uclibc host-pkgconfig dbus host-dbus host-libglib2 host-dbus-glib libglib2

That's wrong, it's the host-dbus-glib which needs the host-glib, not the target dbus-glib (but it'll work as well). I'll fix it in svn.

Jean-Christian> Now using libxml2 let the build fail with this error Jean-Christian> into the make of dbus-glib:

Jean-Christian> [...]
Jean-Christian> checking for ngettext in -lintl... yes
Jean-Christian> checking for dgettext in -lintl... yes
Jean-Christian> checking for bind_textdomain_codeset... yes
Jean-Christian> checking for msgfmt... /usr/bin/msgfmt
Jean-Christian> checking for dcgettext... yes
Jean-Christian> checking if msgfmt accepts -c... yes
Jean-Christian> checking for gmsgfmt... /usr/bin/msgfmt
Jean-Christian> checking for xgettext... /usr/bin/xgettext
Jean-Christian> checking for XML_ParserCreate_MM in -lexpat... no
Jean-Christian> configure: error: expat library not found, check config.log for failed attempts Jean-Christian> make: *** [/home/jcdr/try/buildroot-svn-dep-libxml2/build_arm/dbus-glib-0.80/.stamp_configured] Erreur 1

Peter Korsgaard a ?crit :

Hi,

Yes. I was confused by a early make message, sorry.

Thanks.

Ok.

I agree with you, but I did not know how to make a better fix.

Good idea. Thanks.

Jean-Christian de Rivaz