spi_mpc83xx: Handles other Freescale processors
PATCH 1/3 spi_mpc83xx: Handles other Freescale processors
With this patch we'll able to select spi_mpc83xx driver on the MPC86xx platforms. Let the driver depend on FSL_SOC, so we don't have to worry about Kconfig anymore.
Also remove the "experimental" dependency, the driver has been tested to work on a various hardware, and surely not experimental anymore.
--- drivers/spi/Kconfig | 14 ++++++-------- 1 files changed, 6 insertions(+), 8 deletions(-)
drivers/spi/Kconfig +6 -8
@@ -140,16 +140,14 @@ config SPI_MPC52xx_PSC Controller in master SPI mode. config SPI_MPC83xx - tristate "Freescale MPC83xx/QUICC Engine SPI controller" - depends on (PPC_83xx || QUICC_ENGINE) && EXPERIMENTAL + tristate "Freescale MPC8xxx SPI controller" + depends on FSL_SOC help - This enables using the Freescale MPC83xx and QUICC Engine SPI - controllers in master mode. + This enables using the Freescale MPC8xxx SPI controllers in master + mode. - Note, this driver uniquely supports the SPI controller on the MPC83xx - family of PowerPC processors, plus processors with QUICC Engine - technology. This driver uses a simple set of shift registers for data - (opposed to the CPM based descriptor model). + This driver uses a simple set of shift registers for data (opposed + to the CPM based descriptor model). config SPI_OMAP_UWIRE tristate "OMAP1 MicroWire"
Signature · 1 line
1.5.6.5
Quoted 11 lines · Anton Vorontsov
With this patch we'll able to select
spi_mpc83xxdriver on the MPC86xx platforms. Let the driver depend onFSL_SOC, so we don't have to worry aboutKconfiganymore.Also remove the "experimental" dependency, the driver has been tested to work on a various hardware, and surely not experimental anymore.
Signed-off-by Anton Vorontsov <[email protected]>---
drivers/spi/Kconfig| 14 ++++++--------1 files changed, 6 insertions(+), 8 deletions(-)
this looks fine, but why don't we go ahead and rename things as well? SPI_MPC83xx -> SPI_MPC8xxx, spi_mpc83xx.c -> spi_mpc8xxx.c
- k
Quoted 10 lines · Kumar Gala
Quoted 7 lines · Anton Vorontsov
With this patch we'll able to select
spi_mpc83xxdriver on the MPC86xx platforms. Let the driver depend onFSL_SOC, so we don't have to worry aboutKconfiganymore.Also remove the "experimental" dependency, the driver has been tested to work on a various hardware, and surely not experimental anymore.
Quoted 7 lines
Quoted 4 lines
Signed-off-by Anton Vorontsov <[email protected]>---
drivers/spi/Kconfig| 14 ++++++--------1 files changed, 6 insertions(+), 8 deletions(-)this looks fine, but why don't we go ahead and rename things as well?
SPI_MPC83xx->SPI_MPC8xxx,spi_mpc83xx.c->spi_mpc8xxx.c
mpc8xxx implies mpc82xx (e.g. mpc8272) which is not the same controller as on the mpc83xx
Signature · 4 lines
------------------------------------------------------------ Gary Thomas | Consulting for the MLB Associates | Embedded world ------------------------------------------------------------
Quoted 16 lines · Gary Thomas
Quoted 15 lines · Kumar Gala
Quoted 11 lines · Anton Vorontsov
With this patch we'll able to select
spi_mpc83xxdriver on the MPC86xx platforms. Let the driver depend onFSL_SOC, so we don't have to worry aboutKconfiganymore.Also remove the "experimental" dependency, the driver has been tested to work on a various hardware, and surely not experimental anymore.
Signed-off-by Anton Vorontsov <[email protected]>---
drivers/spi/Kconfig| 14 ++++++--------1 files changed, 6 insertions(+), 8 deletions(-)
Quoted 5 lines
Quoted 2 lines
this looks fine, but why don't we go ahead and rename things as well?
SPI_MPC83xx->SPI_MPC8xxx,spi_mpc83xx.c->spi_mpc8xxx.cmpc8xxx implies mpc82xx (e.g. mpc8272) which is not the same controller as on the mpc83xx
True, but normally the 82xx drivers are "cpm" prefixed. I think 8xxx is at better name than 83xx.
- k