Skip to contentSkip to conversation

p54: generate channel list dynamically

RFC In review Christian Lamparter 2 participants 2 messages Apr 8, 2009 Networking drivers (wireless)

lore
Share & tools
lore
#0 lore raw

RFC 1/1 p54: generate channel list dynamically

This patch enhances the eeprom parser to generate customized channel list for every device.
---
Larry,

I'm thinking of splitting up p54common.c into small files... e.g: one file each for eeprom, mac, led and main/lib code. So I'm asking for your opinion "before" I waste time with it.

Regards,
Chr
---

drivers/net/wireless/p54/p54.h +1 -0
index 53d3ed8..fe8bca4 100644
@@ -171,6 +171,7 @@ struct p54_common {
 	struct p54_cal_database *curve_data;
 	struct p54_cal_database *output_limit;
 	struct p54_rssi_linear_approximation rssical_db[IEEE80211_NUM_BANDS];
+	struct ieee80211_supported_band *band_table[IEEE80211_NUM_BANDS];
 
 	/* BBP/MAC state */
 	u8 mac_addr[ETH_ALEN];
drivers/net/wireless/p54/p54common.c +265 -71

377 lines not on this page · raw message

#1 lore raw
Quoted 3 lines · Christian Lamparter

I'm thinking of splitting up p54common.c into small files... e.g: one file each for eeprom, mac, led and main/lib code. So I'm asking for your opinion "before" I waste time with it.

Christian,

With this patch applied, p54common.c is 77K characters, which is on the edge of being unwieldy. I would not object to splitting it into the 4 categories you mention.

As we are roughly 2 months from the 2.6.31 merge, this might be a good time to do it as there would be plenty of time for testing.

I have not yet tested this patch as I'm currently chasing a regression in 2.6.30-rc1 from Linus's tree. Once that is squared away, then I'll test the channel list changes. I do approve of the concept.

Larry