Skip to contentSkip to conversation

usual_tables: module license 'unspecified' taints kernel.

DISCUSSION Alan Jenkins 2 participants 4 messages Apr 8, 2009 – Apr 9, 2009

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

Hi, I see this regression in v2.6.30-rc1. I end up with a module "usual_tables.ko", which is loaded on boot and causes the kernel to complain about an unspecified license. See subject for the exact error message.

I have

CONFIG_USB_STORAGE=m
CONFIG_USB_LIBUSUAL=y

Also, usb-storage doesn't seem to get loaded automatically, as it did in 2.6.29 with the same configs.

Thanks
Alan

#1 lore raw
Quoted 5 lines · Alan Jenkins

Hi, I see this regression in v2.6.30-rc1. I end up with a module "usual_tables.ko", which is loaded on boot and causes the kernel to complain about an unspecified license. See subject for the exact error message.

Quoted 9 lines

I have

CONFIG_USB_STORAGE=m
CONFIG_USB_LIBUSUAL=y

Also, usb-storage doesn't seem to get loaded automatically, as it did in 2.6.29 with the same configs.

Hmm, seems someone else broke request_module(). So don't worry about this last issue - I'm sure it will get fixed :-).

maintainer
#2 lore raw
In reply to Alan Jenkins
Quoted 9 lines · Alan Jenkins

Hi, I see this regression in v2.6.30-rc1. I end up with a module "usual_tables.ko", which is loaded on boot and causes the kernel to complain about an unspecified license. See subject for the exact error message.

I have

CONFIG_USB_STORAGE=m
CONFIG_USB_LIBUSUAL=y

This looks like a mistake in the Makefile. Does the patch below fix the problem?

Alan Stern

drivers/usb/storage/Makefile +2 -1
Index: usb-2.6/drivers/usb/storage/Makefile
===================================================================
@@ -17,7 +17,8 @@ usb-storage-objs :=	scsiglue.o protocol.
 ifeq ($(CONFIG_USB_LIBUSUAL),)
 	usb-storage-objs	+= usual-tables.o
 else
-	obj-$(CONFIG_USB)	+= libusual.o usual-tables.o
+	obj-$(CONFIG_USB)	+= usb-libusual.o
+	usb-libusual-objs	:= libusual.o usual-tables.o
 endif
 
 obj-$(CONFIG_USB_STORAGE_ALAUDA)	+= ums-alauda.o
#3 lore raw
Quoted 10 lines · Alan Stern
Quoted 7 lines · Alan Jenkins

Hi, I see this regression in v2.6.30-rc1. I end up with a module "usual_tables.ko", which is loaded on boot and causes the kernel to complain about an unspecified license. See subject for the exact error message.

I have

Quoted 9 lines
Quoted 3 lines

CONFIG_USB_STORAGE=m
CONFIG_USB_LIBUSUAL=y

This looks like a mistake in the Makefile. Does the patch below fix the problem?

Alan Stern

Yes. Thanks!