struct exception_table_entry
Hi Arnd,
I am doing some cleanup things in MB MMU kernel and I looked at exception_table_entry structure.
Only alpha use different types among others. Some arch use only different names and types int/long.
I think that this structure could be moved to any generic location -> asm-generic/uaccess.h folder.
I think that this structure types should be acceptable for every archs?
#ifndef exception_table_entry
struct exception_table_entry {
unsigned long insn;
unsigned long fixup;
};#endif
What do you think?
Thanks,
Michal
Signature · 3 lines
Michal Simek, Ing. (M.Eng) PetaLogix - Linux Solutions for a Reconfigurable World w: www.petalogix.com p: +61-7-30090663,+42-0-721842854 f: +61-7-30090663
Quoted 9 lines · Michal Simek
I am doing some cleanup things in MB MMU kernel and I looked at
exception_table_entrystructure.
Only alpha use different types among others. Some arch use only different names and types int/long.
I think that this structure could be moved to any generic location ->asm-generic/uaccess.hfolder.I think that this structure types should be acceptable for every archs?
Quoted 8 lines
#ifndef
exception_table_entrystruct exception_table_entry { unsigned long insn; unsigned long fixup; };#endif
What do you think?
Yes, sounds good to me. Have you tried using my generic version of uaccess.h on microblaze? It already contains a definition like this, though most of the header doesn't apply for MMU-based architectures.
I suppose it can be improved a bit, but should do the basic job.
Arnd <><
From: Arnd Bergmann <[email protected]>
Date: Tue, 14 Apr 2009 16:36:11 +0200
Quoted 18 lines · Michal Simek
Quoted 17 lines
I am doing some cleanup things in MB MMU kernel and I looked at
exception_table_entrystructure.
Only alpha use different types among others. Some arch use only different names and types int/long.
I think that this structure could be moved to any generic location ->asm-generic/uaccess.hfolder.I think that this structure types should be acceptable for every archs?
#ifndef
exception_table_entrystruct exception_table_entry { unsigned long insn; unsigned long fixup; };#endif
Quoted 7 lines
Quoted 1 line
What do you think?
Yes, sounds good to me. Have you tried using my generic version of
uaccess.hon microblaze? It already contains a definition like this, though most of the header doesn't apply for MMU-based architectures.I suppose it can be improved a bit, but should do the basic job.
Note that for space saving several 64-bit architectures use plain "int" here when they know that all kernel addresses are in the low 32-bits of the address space.
sparc64 is one such architecture and I'd prefer if the size of these tables does not bloat up when you guys try to make this thing generic.
Quoted 29 lines · David Miller
From: Arnd Bergmann <[email protected]>
Date: Tue, 14 Apr 2009 16:36:11 +0200Quoted 25 lines · Michal Simek
Quoted 11 lines
I am doing some cleanup things in MB MMU kernel and I looked at
exception_table_entrystructure.
Only alpha use different types among others. Some arch use only different names and types int/long.
I think that this structure could be moved to any generic location ->asm-generic/uaccess.hfolder.I think that this structure types should be acceptable for every archs?
Quoted 9 lines
#ifndef
exception_table_entrystruct exception_table_entry { unsigned long insn; unsigned long fixup; };#endif
What do you think?
Yes, sounds good to me. Have you tried using my generic version of
uaccess.hon microblaze? It already contains a definition like this, though most of the header doesn't apply for MMU-based architectures.
Quoted 7 lines
Quoted 2 lines
I suppose it can be improved a bit, but should do the basic job.
Note that for space saving several 64-bit architectures use plain "int" here when they know that all kernel addresses are in the low 32-bits of the address space.
Just one my note: use u32 instead of int.
Michal
Quoted 3 lines
sparc64 is one such architecture and I'd prefer if the size of these tables does not bloat up when you guys try to make this thing generic.
Signature · 3 lines
Michal Simek, Ing. (M.Eng) PetaLogix - Linux Solutions for a Reconfigurable World w: www.petalogix.com p: +61-7-30090663,+42-0-721842854 f: +61-7-30090663
Quoted 19 lines · Arnd Bergmann
Quoted 16 lines · Michal Simek
I am doing some cleanup things in MB MMU kernel and I looked at
exception_table_entrystructure.
Only alpha use different types among others. Some arch use only different names and types int/long.
I think that this structure could be moved to any generic location ->asm-generic/uaccess.hfolder.I think that this structure types should be acceptable for every archs?
#ifndef
exception_table_entrystruct exception_table_entry { unsigned long insn; unsigned long fixup; };#endif
Quoted 7 lines
Quoted 2 lines
What do you think?
Yes, sounds good to me. Have you tried using my generic version of
uaccess.hon microblaze? It already contains a definition like this, though most of the header doesn't apply for MMU-based architectures.
I haven't had time to look at it but it is on my list.
Quoted 2 lines
I suppose it can be improved a bit, but should do the basic job.
yes of course. That was just my idea. Use it only for MMU kernels + #ifndef for structure
doesn't work I think.
Thanks,
Michal
Quoted 2 lines
Arnd <><
Signature · 3 lines
Michal Simek, Ing. (M.Eng) PetaLogix - Linux Solutions for a Reconfigurable World w: www.petalogix.com p: +61-7-30090663,+42-0-721842854 f: +61-7-30090663