Skip to contentSkip to conversation

tracing: mark get_parent_ip() notrace

PATCH In review Lai Jiangshan 4 participants 6 messages Apr 2, 2009 – Apr 14, 2009

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 tracing: mark get_parent_ip() notrace

Impact: remove redundancy tracing log

When tracer is "function" or "function_graph", too much "get_parent_ip" are recorded in ring_buffer.

---

kernel/sched.c +1 -1
index 706517c..a0ec10c 100644
@@ -4860,7 +4860,7 @@ void scheduler_tick(void)
 #endif
 }
 
-unsigned long get_parent_ip(unsigned long addr)
+notrace unsigned long get_parent_ip(unsigned long addr)
 {
 	if (in_lock_functions(addr)) {
 		addr = CALLER_ADDR2;
Acked-by on v1 1/1
#1 lore raw
Quoted 5 lines · Lai Jiangshan

Impact: remove redundancy tracing log

When tracer is "function" or "function_graph", too much "get_parent_ip" are recorded in ring_buffer.

Thanks, indeed this get_parent_ip was a bit harrassing in the traces, though I still don't understand why it is called so often.

Anyway, tracing it seems to me not useful.

Quoted 22 lines

---

kernel/sched.c +1 -2
index 706517c..a0ec10c 100644
@@ -4860,7 +4860,7 @@ void scheduler_tick(void)
 #endif
 }
 
-unsigned long get_parent_ip(unsigned long addr)
+notrace unsigned long get_parent_ip(unsigned long addr)
 {
 	if (in_lock_functions(addr)) {
 		addr = CALLER_ADDR2;
 
 
--

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

#2 lore raw
Quoted 7 lines · Frederic Weisbecker
Quoted 4 lines · Lai Jiangshan

Impact: remove redundancy tracing log

When tracer is "function" or "function_graph", too much "get_parent_ip" are recorded in ring_buffer.

Quoted 9 lines

Thanks, indeed this get_parent_ip was a bit harrassing in the traces, though I still don't understand why it is called so often.

Anyway, tracing it seems to me not useful.

Hi, Ingo,
Could you apply this fix?

get_parent_ip() is a helper function for ftace, and it is called by preempt_disable() and preempt_enable(), so it is occurred very often.

Lai.

#3 lore raw
Quoted 18 lines · Lai Jiangshan
Quoted 7 lines · Frederic Weisbecker
Quoted 4 lines · Lai Jiangshan

Impact: remove redundancy tracing log

When tracer is "function" or "function_graph", too much "get_parent_ip" are recorded in ring_buffer.

Quoted 9 lines

Thanks, indeed this get_parent_ip was a bit harrassing in the traces, though I still don't understand why it is called so often.

Anyway, tracing it seems to me not useful.

Quoted 6 lines

Hi, Ingo,
Could you apply this fix?

get_parent_ip() is a helper function for ftace, and it is called by preempt_disable() and preempt_enable(), so it is occurred very often.

I can pull it in too, if Ingo is busy.

-- Steve

#4 lore raw
Quoted 20 lines · Steven Rostedt
Quoted 18 lines · Lai Jiangshan
Quoted 16 lines · Frederic Weisbecker
Quoted 4 lines · Lai Jiangshan

Impact: remove redundancy tracing log

When tracer is "function" or "function_graph", too much "get_parent_ip" are recorded in ring_buffer.

Thanks, indeed this get_parent_ip was a bit harrassing in the traces, though I still don't understand why it is called so often.

Anyway, tracing it seems to me not useful.

Quoted 8 lines
Quoted 6 lines

Hi, Ingo,
Could you apply this fix?

get_parent_ip() is a helper function for ftace, and it is called by preempt_disable() and preempt_enable(), so it is occurred very often.

I can pull it in too, if Ingo is busy.

I have put it into tip:sched/urgent - it belongs there file-wise. Will go upstream after -rc2 most likely.

Ingo

#5 lore raw

[tip:sched/urgent] tracing, sched: mark get_parent_ip() notrace

In reply to Lai Jiangshan
Commit-ID:  132380a06b24704fd6c9be55c44d4ef3972cead2
Gitweb:     http://git.kernel.org/tip/132380a06b24704fd6c9be55c44d4ef3972cead2
Author:     Lai Jiangshan <[email protected]>
AuthorDate: Thu, 2 Apr 2009 14:18:25 +0800
Committer:  Ingo Molnar <[email protected]>
CommitDate: Tue, 14 Apr 2009 02:11:05 +0200

tracing, sched: mark get_parent_ip() notrace

Impact: remove overly redundant tracing entries

When tracer is "function" or "function_graph", way too much "get_parent_ip" entries are recorded in ring_buffer.

LKML-Reference: <[email protected]>

---
 kernel/sched.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
kernel/sched.c +1 -1
index 5724508..e90e70e 100644
@@ -4846,7 +4846,7 @@ void scheduler_tick(void)
 #endif
 }
 
-unsigned long get_parent_ip(unsigned long addr)
+notrace unsigned long get_parent_ip(unsigned long addr)
 {
 	if (in_lock_functions(addr)) {
 		addr = CALLER_ADDR2;