drivers/isdn boolean negation and bitwise operation in wrong

PATCH New Diego Liziero 1 participant 1 message Apr 14, 2009 Kernel janitors

lore

Share & tools

lore

Diego Liziero

author

2009-04-14 01:52 UTC #0 lore raw

PATCH 1/1 drivers/isdn boolean negation and bitwise operation in wrong

From: Diego Liziero <[email protected]>

The semantic patch that makes this change is:
(http://www.emn.fr/x-info/coccinelle/)

@@ expression E; constant C; @@
(
- !E = C
+ E != C
)

Signed-off-by Diego Liziero <[email protected]>

---

tmp/cocci-output-25237-f6bb7c-diva.c renamed from drivers/isdn/hisax/diva.c +1 -1

diff = 
@@ -382,7 +382,7 @@ MemwaitforXFW(struct IsdnCardState *cs, 
 {
 	int to = 50;
 
-	while ((!(MemReadHSCX(cs, hscx, HSCX_STAR) & 0x44) = 0x40) && to) {
+	while (((MemReadHSCX(cs, hscx, HSCX_STAR) & 0x44) != 0x40) && to) {
 		udelay(1);
 		to--;
 	}