Skip to contentSkip to conversation

myri10ge: fix compile error

PATCH In review Andrew Gallatin 3 participants 3 messages Apr 17, 2009 – Apr 18, 2009

Subsystems (2)
Networking Network drivers
lore
Share & tools
lore

Andrew Gallatin

author
#0 lore raw

PATCH 1/1 myri10ge: fix compile error

A compilation error snuck into 2d90b0aa3bc484189940444bcddcbe0ebbb53af5 due to an over-zealous indent script removing spaces around array initialization ellipsis. The attached patch fixes the myri10ge compilation in net-next.

Thanks,

Drew

Signed-off-by Andrew Gallatin <[email protected]>
drivers/net/myri10ge/myri10ge.c +1 -1
index 291944d..140794a 100644
@@ -269,7 +269,7 @@ MODULE_PARM_DESC(myri10ge_fw_name, "Firmware image name");
 
 #define MYRI10GE_MAX_BOARDS 8
 static char *myri10ge_fw_names[MYRI10GE_MAX_BOARDS] =
-    {[0...(MYRI10GE_MAX_BOARDS - 1)] = NULL };
+    {[0 ... (MYRI10GE_MAX_BOARDS - 1)] = NULL };
 module_param_array_named(myri10ge_fw_names, myri10ge_fw_names, charp, NULL,
 			 0444);
 MODULE_PARM_DESC(myri10ge_fw_name, "Firmware image names per board");
maintainer
#1 lore raw

From: Andrew Gallatin <[email protected]>
Date: Fri, 17 Apr 2009 13:14:37 -0400

Quoted 7 lines

A compilation error snuck into 2d90b0aa3bc484189940444bcddcbe0ebbb53af5
due to an over-zealous indent script removing spaces around array initialization ellipsis. The attached patch fixes the myri10ge compilation in net-next.

Signed-off-by Andrew Gallatin <[email protected]>

It gives me great confidence in your work, seeing as you don't even type 'make' on the patches you send me.

Sigh, applied...

#2 lore raw
Quoted 10 lines · David Miller

From: Andrew Gallatin <[email protected]>
Date: Fri, 17 Apr 2009 13:14:37 -0400

Quoted 6 lines

A compilation error snuck into 2d90b0aa3bc484189940444bcddcbe0ebbb53af5
due to an over-zealous indent script removing spaces around array initialization ellipsis. The attached patch fixes the myri10ge compilation in net-next.

Quoted 8 lines
Quoted 2 lines
Signed-off-by Andrew Gallatin <[email protected]>

It gives me great confidence in your work, seeing as you don't even type 'make' on the patches you send me.

Sigh, applied...

Apologies, it was entirely my fault here.

Brice