Skip to contentSkip to conversation

add hw/Makefile ...

PATCH In review Gerd Hoffmann 4 participants 6 messages Apr 22, 2009 – Apr 28, 2009

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 add hw/Makefile ...

Hi,

... so you can type "make" in the hw/ subdir and it happens something useful ;)

cheers,
Gerd

Quoted 1 line

From 7754e2fe0d2c955962e8a186e7f824b4b0139453 Mon Sep 17 00:00:00 2001

From: Gerd Hoffmann <[email protected]>
Date: Wed, 22 Apr 2009 12:39:24 +0200
Subject: [PATCH 04/10] add hw/Makefile

So typing "make" in hw/ does something useful.

---
 hw/Makefile |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
 create mode 100644 hw/Makefile
hw/Makefile new file +2 -0
new file mode 100644
index 0000000..625525c
@@ -0,0 +1,2 @@
+all:
+	make -C .. $@
Signature · 1 line
1.6.2.2
#1 lore raw
Quoted 7 lines · On Wednesday 22 April 2009 13:10:48 Gerd Hoffmann wrote:
   Hi,

... so you can type "make" in the hw/ subdir and it happens something useful ;)

cheers,
Gerd

This is wrong. Use $(MAKE) or you break platforms where you have to use "gmake", otherwise.

Christoph

Signature · 6 lines
---to satisfy European Law for business letters:
Advanced Micro Devices GmbH
Karl-Hammerschmidt-Str. 34, 85609 Dornach b. Muenchen
Geschaeftsfuehrer: Jochen Polster, Thomas M. McCoy, Giuliano Meroni
Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632
#2 lore raw
Quoted 2 lines · Christoph Egger

This is wrong. Use $(MAKE) or you break platforms where you have to use "gmake", otherwise.

Updated patch attached.

cheers,
Gerd

Quoted 1 line

From f18c599455383522b3901d0585befc2afa8cfe93 Mon Sep 17 00:00:00 2001

From: Gerd Hoffmann <[email protected]>
Date: Wed, 22 Apr 2009 12:39:24 +0200
Subject: [PATCH 3/5] add hw/Makefile

So typing "make" in hw/ does something useful.

---
 hw/Makefile |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
 create mode 100644 hw/Makefile
hw/Makefile new file +2 -0
new file mode 100644
index 0000000..70ea257
@@ -0,0 +1,2 @@
+all:
+	$(MAKE) -C .. $@
Signature · 1 line
1.6.2.2
#3 lore raw
Quoted 8 lines · On Wednesday 22 April 2009 14:50:09 Gerd Hoffmann wrote:
Quoted 2 lines · Christoph Egger

This is wrong. Use $(MAKE) or you break platforms where you have to use "gmake", otherwise.

Updated patch attached.

cheers,
Gerd

That's fine.

Christoph

Signature · 6 lines
---to satisfy European Law for business letters:
Advanced Micro Devices GmbH
Karl-Hammerschmidt-Str. 34, 85609 Dornach b. Muenchen
Geschaeftsfuehrer: Jochen Polster, Thomas M. McCoy, Giuliano Meroni
Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632
#4 lore raw
In reply to Gerd Hoffmann
Quoted 4 lines · Gerd Hoffmann
   Hi,

... so you can type "make" in the hw/ subdir and it happens something useful ;)

I'm not convinced it should do anything useful.

Paul

#5 lore raw
Quoted 10 lines · Paul Brook
Quoted 5 lines · Gerd Hoffmann
   Hi,

... so you can type "make" in the hw/ subdir and it happens something useful ;)

I'm not convinced it should do anything useful.

Neither am I. I'm pretty sure it would confuse me to do a top level build from a sub directory.

Regards,

Anthony Liguori

Quoted 4 lines

Paul