Skip to contentSkip to conversation

ath5k irq warning message

DISCUSSION Ben Greear 2 participants 3 messages Apr 22, 2009 – Apr 23, 2009

Subsystems (2)
lore
Share & tools
lore

Ben Greear

author
#0 lore raw

I'm working on debugging some sort of live-lock related to irqs in ath5k with lots of virtual stations.

I notice this code in the ath5k_intr method.

Won't counter be -1 if you break out of this due to the 'counter-- > 0' clause?

If so, then that warning won't be printed regardless...

	} while (ath5k_hw_is_intr_pending(ah) && counter-- > 0);

	if (unlikely(!counter))
		ATH5K_WARN(sc, "too many interrupts, giving up for now\n");

Thanks,
Ben

Signature · 2 lines
Ben Greear <[email protected]>
Candela Technologies Inc  http://www.candelatech.com
#1 lore raw
Quoted 6 lines · Ben Greear

I notice this code in the ath5k_intr method.

Won't counter be -1 if you break out of this due to the 'counter-- > 0' clause?

	} while (ath5k_hw_is_intr_pending(ah) && counter-- > 0);

Good catch, I guess it should be --counter...

Signature · 1 line
Bob Copeland %% www.bobcopeland.com
author
#2 lore raw
Quoted 9 lines · Bob Copeland
Quoted 6 lines · Ben Greear

I notice this code in the ath5k_intr method.

Won't counter be -1 if you break out of this due to the 'counter-- > 0' clause?

	} while (ath5k_hw_is_intr_pending(ah) && counter-- > 0);

Good catch, I guess it should be --counter...

That works for me.

Seems the root cause of my problem might have been fixed already by the patch to turn off BMISS irqs, btw...about to start testing that now.

Ben

Signature · 2 lines
Ben Greear <[email protected]>
Candela Technologies Inc  http://www.candelatech.com