Skip to contentSkip to conversation

Marvell MV88E61XX Switch Driver support

PATCH Superseded Prafulla Wadaskar 2 participants 5 messages Apr 23, 2009 – Apr 25, 2009

Subsystems (2)

v8 of 10 Superseded Latest is v10 →

lore
Share & tools
lore
#0 lore raw

PATCH v8 1/1 Marvell MV88E61XX Switch Driver support

Chips supported:-
1. 88E6161 6 port gbe swtich with 5 integrated PHYs
2. 88E6165 6 port gbe swtich with 5 integrated PHYs
2. 88E6132 3 port gbe swtich with 2 integrated PHYs Platform specific configuration supported default and router port vlan config supported

Note: This driver is supported and tested against
kirkwood egiga interface

Contributors:
Yotam Admon <[email protected]>
Michael Blostein <michaelbl at marvell.com

Reviewed by: Ronen Shitrit <[email protected]>

---
Change log:-
v2: updated as per review comments for v1
removed other two drivers form earlier patch
debug_prints removed
driver moved to drivers/net/

v3: updated as per review comments for v2
miiphy interface used, platform specific dependency resolved Chip id detection and printing added
common code forked out
some cosmetic and magic number fixes

v4: updated as per review comments for v3
mv88e61xx.h added
platform specific configuration support added
some more documentation references provided
cleaned rgmii delay enable related code

v5: updated as per review comments for v3 code moved to drivers/net/phy/
vlan_init changed to vlan_config and platform specific

v6: mutichip related alias moved to header file vlan_config functions renamed as port_vlan_config mv_switch_88f61xx_init renamed as mv88f61xx_switch_initialization the function prototype for same is added in netdev.h

v7: minor updates as per v6 review feedback
RD_PHY/WR_PHY macros defined and used in the code

v8: BITxx macros replaced by 1<<xx

 drivers/net/phy/Makefile    |    1 +
 drivers/net/phy/mv88e61xx.c |  298 +++++++++++++++++++++++++++++++++++++++++++
 drivers/net/phy/mv88e61xx.h |   86 +++++++++++++
 include/netdev.h            |    1 +
 4 files changed, 386 insertions(+), 0 deletions(-)
 create mode 100644 drivers/net/phy/mv88e61xx.c
 create mode 100644 drivers/net/phy/mv88e61xx.h
drivers/net/phy/Makefile +1 -0
index 4fe3b05..3b92614 100644
@@ -26,6 +26,7 @@ include $(TOPDIR)/config.mk
 LIB	:= $(obj)libphy.a
 
 COBJS-$(CONFIG_BITBANGMII) += miiphybb.o
+COBJS-$(CONFIG_MV88E61XX_SWITCH) += mv88e61xx.o
 
 COBJS	:= $(COBJS-y)
 SRCS	:= $(COBJS:.o=.c)
drivers/net/phy/mv88e61xx.c new file +298 -0

298 lines not on this page · raw message

drivers/net/phy/mv88e61xx.h new file +86 -0

86 lines not on this page · raw message

include/netdev.h +1 -0
index 2794ddd..f7a7db1 100644
@@ -59,6 +59,7 @@ int mpc512x_fec_initialize(bd_t *bis);
 int mpc5xxx_fec_initialize(bd_t *bis);
 int mpc8220_fec_initialize(bd_t *bis);
 int mpc82xx_scc_enet_initialize(bd_t *bis);
+int mv88e61xx_switch_initialize(struct mv88e61xx_config *swconfig);
 int natsemi_initialize(bd_t *bis);
 int npe_initialize(bd_t *bis);
 int ns8382x_initialize(bd_t *bis);
Signature · 1 line
1.5.3.4
#1 lore raw

PATCH v8 1/1 Marvell MV88E61XX Switch Driver support

Hi Ben

Pls skip my earlier patch v7, I found few more cosmetic updates and removal of BITxx macro dependency patch v8 is final one from my side

Regards..
Prafulla . .

________________________________________
From: Prafulla Wadaskar
Sent: Friday, April 24, 2009 1:08 AM
To: Ben Warren
Cc: u-boot at lists.denx.de; Ashish Karkare; Prabhanjan Sarnaik; Ronen Shitrit
Subject: [PATCH v8] Marvell MV88E61XX Switch Driver support

Chips supported:-
1. 88E6161 6 port gbe swtich with 5 integrated PHYs
2. 88E6165 6 port gbe swtich with 5 integrated PHYs
2. 88E6132 3 port gbe swtich with 2 integrated PHYs Platform specific configuration supported default and router port vlan config supported

Note: This driver is supported and tested against
kirkwood egiga interface

Contributors:
Yotam Admon <[email protected]>
Michael Blostein <michaelbl at marvell.com

Reviewed by: Ronen Shitrit <[email protected]>

---
Change log:-
v2: updated as per review comments for v1
removed other two drivers form earlier patch
debug_prints removed
driver moved to drivers/net/

v3: updated as per review comments for v2
miiphy interface used, platform specific dependency resolved Chip id detection and printing added
common code forked out
some cosmetic and magic number fixes

v4: updated as per review comments for v3
mv88e61xx.h added
platform specific configuration support added
some more documentation references provided
cleaned rgmii delay enable related code

v5: updated as per review comments for v3 code moved to drivers/net/phy/
vlan_init changed to vlan_config and platform specific

v6: mutichip related alias moved to header file vlan_config functions renamed as port_vlan_config mv_switch_88f61xx_init renamed as mv88f61xx_switch_initialization the function prototype for same is added in netdev.h

v7: minor updates as per v6 review feedback
RD_PHY/WR_PHY macros defined and used in the code

v8: BITxx macros replaced by 1<<xx

 drivers/net/phy/Makefile    |    1 +
 drivers/net/phy/mv88e61xx.c |  298 +++++++++++++++++++++++++++++++++++++++++++
 drivers/net/phy/mv88e61xx.h |   86 +++++++++++++
 include/netdev.h            |    1 +
 4 files changed, 386 insertions(+), 0 deletions(-)
 create mode 100644 drivers/net/phy/mv88e61xx.c
 create mode 100644 drivers/net/phy/mv88e61xx.h
drivers/net/phy/Makefile +1 -0
index 4fe3b05..3b92614 100644
@@ -26,6 +26,7 @@ include $(TOPDIR)/config.mk
 LIB    := $(obj)libphy.a
 
 COBJS-$(CONFIG_BITBANGMII) += miiphybb.o
+COBJS-$(CONFIG_MV88E61XX_SWITCH) += mv88e61xx.o
 
 COBJS  := $(COBJS-y)
 SRCS   := $(COBJS:.o=.c)
drivers/net/phy/mv88e61xx.c new file +298 -0

298 lines not on this page · raw message

drivers/net/phy/mv88e61xx.h new file +86 -0

86 lines not on this page · raw message

include/netdev.h +1 -0
index 2794ddd..f7a7db1 100644
@@ -59,6 +59,7 @@ int mpc512x_fec_initialize(bd_t *bis);
 int mpc5xxx_fec_initialize(bd_t *bis);
 int mpc8220_fec_initialize(bd_t *bis);
 int mpc82xx_scc_enet_initialize(bd_t *bis);
+int mv88e61xx_switch_initialize(struct mv88e61xx_config *swconfig);
 int natsemi_initialize(bd_t *bis);
 int npe_initialize(bd_t *bis);
 int ns8382x_initialize(bd_t *bis);

--
1.5.3.4

Applied
#2 lore raw

PATCH v8 1/1 Marvell MV88E61XX Switch Driver support

In reply to Prafulla Wadaskar
Quoted 10 lines · Prafulla Wadaskar

Chips supported:-
1. 88E6161 6 port gbe swtich with 5 integrated PHYs
2. 88E6165 6 port gbe swtich with 5 integrated PHYs
2. 88E6132 3 port gbe swtich with 2 integrated PHYs Platform specific configuration supported default and router port vlan config supported

Note: This driver is supported and tested against kirkwood egiga interface

Quoted 6 lines

Contributors:
Yotam Admon <[email protected]>
Michael Blostein <[email protected]

Reviewed by: Ronen Shitrit <[email protected]>

<snip>

applied to net/next branch.

thanks for your contribution,
Ben

#3 lore raw

PATCH v8 1/1 Marvell MV88E61XX Switch Driver support

Quoted 27 lines

-----Original Message-----
From: Ben Warren [mailto:biggerbadderben at gmail.com]
Sent: Friday, April 24, 2009 7:00 PM
To: Prafulla Wadaskar
Cc: u-boot at lists.denx.de; Ashish Karkare; Prabhanjan Sarnaik; Ronen Shitrit
Subject: Re: [PATCH v8] Marvell MV88E61XX Switch Driver support

Quoted 2 lines · Prafulla Wadaskar

Chips supported:-
1. 88E6161 6 port gbe swtich with 5 integrated PHYs 2.

88E6165 6 port

Quoted 1 line

gbe swtich with 5 integrated PHYs 2. 88E6132 3 port gbe

swtich with 2

Quoted 1 line

integrated PHYs Platform specific configuration supported

default and

Quoted 9 lines

router port vlan config supported

Note: This driver is supported and tested against kirkwood egiga interface

Contributors:
Yotam Admon <[email protected]>
Michael Blostein <[email protected]

Quoted 5 lines
Quoted 2 lines

Reviewed by: Ronen Shitrit <[email protected]>

<snip>

applied to net/next branch.

Hi Ben
Thanks....
I could not find this update at http://git.denx.de/?p=u-boot/u-boot-net.git;a=shortlog;h=refs/heads/next
Is this process still in progress or the location is different one?

Regards..
Prafulla. . .

#4 lore raw

PATCH v8 1/1 Marvell MV88E61XX Switch Driver support

Hi Prafulla,

Quoted 42 lines · Prafulla Wadaskar
Quoted 35 lines

-----Original Message-----
From: Ben Warren [mailto:biggerbadderben at gmail.com]
Sent: Friday, April 24, 2009 7:00 PM
To: Prafulla Wadaskar
Cc: u-boot at lists.denx.de; Ashish Karkare; Prabhanjan Sarnaik; Ronen Shitrit
Subject: Re: [PATCH v8] Marvell MV88E61XX Switch Driver support

Quoted 3 lines · Prafulla Wadaskar

Chips supported:-
1. 88E6161 6 port gbe swtich with 5 integrated PHYs 2.

88E6165 6 port

Quoted 2 lines

gbe swtich with 5 integrated PHYs 2. 88E6132 3 port gbe

swtich with 2

Quoted 2 lines

integrated PHYs Platform specific configuration supported

default and

Quoted 9 lines

router port vlan config supported

Note: This driver is supported and tested against kirkwood egiga interface

Contributors:
Yotam Admon <[email protected]>
Michael Blostein <[email protected]

Quoted 7 lines
Quoted 3 lines

Reviewed by: Ronen Shitrit <[email protected]>

<snip>

applied to net/next branch.

Quoted 9 lines

Hi Ben
Thanks....
I could not find this update at http://git.denx.de/?p=u-boot/u-boot-net.git;a=shortlog;h=refs/heads/next
Is this process still in progress or the location is different one?

Regards..
Prafulla. . .

I kinda missed the last step of pushing my local changes to the denx repo. It's there now.

regards,
Ben