Skip to contentSkip to conversation

ROMFS: romfs_dev_read() error ignored

PATCH New Roel Kluin 1 participant 1 message Apr 26, 2009 VFS

lore
Share & tools
lore

Roel Kluin

author
#0 lore raw

PATCH 1/1 ROMFS: romfs_dev_read() error ignored

romfs_dev_read() may return -EIO, but ret is unsigned, so the errorpath isn't taken.

---

fs/romfs/super.c +2 -1
index c53b5ef..4ab3c03 100644
@@ -298,7 +298,8 @@ static struct inode *romfs_iget(struct super_block *sb, unsigned long pos)
 	struct romfs_inode ri;
 	struct inode *i;
 	unsigned long nlen;
-	unsigned nextfh, ret;
+	unsigned nextfh;
+	int ret;
 	umode_t mode;
 
 	/* we might have to traverse a chain of "hard link" file entries to get