staging: scalar tests on pointers
PATCH 1/1 staging: scalar tests on pointers
RTUSBCmdThr_pid, TimerQThr_pid and MLMEThr_pid are pointers.
Signed-off-by Roel Kluin <[email protected]>
---
I think this is correct, right?
drivers/staging/rt3070/2870_main_dev.c +2 -2
@@ -976,7 +976,7 @@ VOID RT28xxThreadTerminate( } } -if (pObj->RTUSBCmdThr_pid >=0 ) +if (pid_nr (pObj->RTUSBCmdThr_pid) >=0 ) {printk ("Terminate the RTUSBCmdThr_pid=%d!\n" ,pid_nr (pObj->RTUSBCmdThr_pid));mb ();
@@ -998,7 +998,7 @@ VOID RT28xxThreadTerminate( pObj->RTUSBCmdThr_pid =NULL ; } } -if (pObj->TimerQThr_pid >=0 ) +if (pid_nr (pObj->TimerQThr_pid) >=0 ) {POS_COOKIE pObj = (POS_COOKIE )pAd->OS_Cookie;
drivers/staging/rt3070/common/rtusb_io.c +1 -1
@@ -873,7 +873,7 @@ NDIS_STATUS RTUSBEnqueueCmdFromNdis(POS_COOKIE pObj = (POS_COOKIE ) pAd->OS_Cookie; -if (pObj->RTUSBCmdThr_pid <0 ) +if (pid_nr (pObj->RTUSBCmdThr_pid) <0 )return (NDIS_STATUS_RESOURCES ); status =RTMPAllocateMemory ((PVOID *)&cmdqelmt,sizeof (CmdQElmt));
drivers/staging/rt3070/rt2870.h +8 -8
@@ -567,18 +567,18 @@ VOID RTUSBBulkOutPsPollComplete(purbb_t pUrb, struct pt_regs *pt_regs);VOID RTUSBBulkRxComplete (purbb_t pUrb,struct pt_regs *pt_regs); -#define RTUSBMlmeUp (pAd) \ -{ \ +#define RTUSBMlmeUp (pAd) \ +{ \ POS_COOKIE pObj = (POS_COOKIE) pAd->OS_Cookie; \ - if(pObj->MLMEThr_pid>0) \ - up(&(pAd->mlme_semaphore)); \ + if (pid_nr(pObj->MLMEThr_pid) > 0) \ + up(&(pAd->mlme_semaphore)); \ } -#define RTUSBCMDUp (pAd) \ -{ \ +#define RTUSBCMDUp (pAd) \ +{ \ POS_COOKIE pObj = (POS_COOKIE) pAd->OS_Cookie; \ - if(pObj->RTUSBCmdThr_pid>0) \ - up(&(pAd->RTUSBCmd_semaphore)); \ + if (pid_nr(pObj->RTUSBCmdThr_pid) > 0) \ + up(&(pAd->RTUSBCmd_semaphore)); \ }