Skip to contentSkip to conversation

block: remove unused __REQ_NR_BITS

PATCH In review Jerome Marchand 2 participants 3 messages Apr 29, 2009 – Apr 30, 2009 Block layer

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 block: remove unused __REQ_NR_BITS

Removes __REQ_NR_BITS which is not used since its only user (blk_dump_rq_flags()) stopped to use it.

---

include/linux/blkdev.h +0 -1
index 2755d5c..a101821 100644
@@ -119,7 +119,6 @@ enum rq_flag_bits {
 	__REQ_INTEGRITY,	/* integrity metadata has been remapped */
 	__REQ_NOIDLE,		/* Don't anticipate more IO after this one */
 	__REQ_IO_STAT,		/* account I/O stat */
-	__REQ_NR_BITS,		/* stops here */
 };
 
 #define REQ_RW		(1 << __REQ_RW)
#1 lore raw

Hi Jerome

Quoted 4 lines · Jerome Marchand

Removes __REQ_NR_BITS which is not used since its only user (blk_dump_rq_flags()) stopped to use it.

See http://lkml.org/lkml/2009/4/27/140

A user for it is added by a patch in linux-2.6-block#for-2.6.31
see http://git.kernel.org/?p=linux/kernel/git/axboe/linux-2.6-block.git;a=commit;h=9eb55b030c4b3227334ee4482402096cd1d1a6fe

Thanks
Nikanth

Quoted 23 lines

---

include/linux/blkdev.h +0 -0
index 2755d5c..a101821 100644
@@ -119,7 +119,6 @@ enum rq_flag_bits {

       __REQ_INTEGRITY,        /* integrity metadata has been remapped */ __REQ_NOIDLE,           /* Don't anticipate more IO after this one */ __REQ_IO_STAT,          /* account I/O stat */
-       __REQ_NR_BITS,          /* stops here */
 };

 #define REQ_RW         (1 << __REQ_RW)

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

#2 lore raw

Hi Nikanth,

Never mind, I missed your patch.

Jerome

Quoted 37 lines · Nikanth K

Hi Jerome

Quoted 3 lines · Jerome Marchand

Removes __REQ_NR_BITS which is not used since its only user (blk_dump_rq_flags()) stopped to use it.

See http://lkml.org/lkml/2009/4/27/140

A user for it is added by a patch in linux-2.6-block#for-2.6.31
see http://git.kernel.org/?p=linux/kernel/git/axboe/linux-2.6-block.git;a=commit;h=9eb55b030c4b3227334ee4482402096cd1d1a6fe

Thanks
Nikanth

Quoted 22 lines

---

include/linux/blkdev.h +0 -2
index 2755d5c..a101821 100644
@@ -119,7 +119,6 @@ enum rq_flag_bits {
       __REQ_INTEGRITY,        /* integrity metadata has been remapped */
       __REQ_NOIDLE,           /* Don't anticipate more IO after this one */
       __REQ_IO_STAT,          /* account I/O stat */
-       __REQ_NR_BITS,          /* stops here */
 };
 
 #define REQ_RW         (1 << __REQ_RW)
 
 
--

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/