Skip to contentSkip to conversation

2.6.30-rc4: compile fail with CONFIG_DRM_I915=y

BUG Lee 2 participants 3 messages May 2, 2009 – May 3, 2009

Subsystems (2)
lore
Share & tools
lore

Lee

author
#0 lore raw

Hi list,

compiling 2.6.30-rc4 with following options will result in an compile error:

CONFIG_DRM_I915=y
CONFIG_ACPI_VIDEO=m

drivers/video/backlight/backlight.c: In function ‘backlight_device_register’:
drivers/video/backlight/backlight.c:247: warning: format not a string literal and no format arguments drivers/video/output.c: In function ‘video_output_register’:
drivers/video/output.c:99: warning: format not a string literal and no format arguments drivers/usb/storage/libusual.c: In function ‘usu_probe_thread’:
drivers/usb/storage/libusual.c:159: warning: format not a string literal and no format arguments drivers/built-in.o: In function `intel_opregion_free':
(.text+0xaf051): undefined reference to `acpi_video_exit'
drivers/built-in.o: In function `intel_opregion_init':
(.text+0xaf411): undefined reference to `acpi_video_register'
make[1]: *** [.tmp_vmlinux1] Error 1
make[1]: Leaving directory `/home/randall/kernel-source'
make: *** [debian/stamp/build/kernel] Error 2

Compiling the kernel with both options as module or both options built-in results in a working kernel.

Kind regards,
Lee

#1 lore raw
Quoted 27 lines · Lee

Hi list,

compiling 2.6.30-rc4 with following options will result in an compile error:

CONFIG_DRM_I915=y
CONFIG_ACPI_VIDEO=m

drivers/video/backlight/backlight.c: In function ‘backlight_device_register’:
drivers/video/backlight/backlight.c:247: warning: format not a string literal and no format arguments
drivers/video/output.c: In function ‘video_output_register’:
drivers/video/output.c:99: warning: format not a string literal and no format arguments
drivers/usb/storage/libusual.c: In function ‘usu_probe_thread’:
drivers/usb/storage/libusual.c:159: warning: format not a string literal and no format arguments
drivers/built-in.o: In function `intel_opregion_free':
(.text+0xaf051): undefined reference to acpi_video_exit' drivers/built-in.o: In function intel_opregion_init':
(.text+0xaf411): undefined reference to `acpi_video_register' make[1]: *** [.tmp_vmlinux1] Error 1
make[1]: Leaving directory `/home/randall/kernel-source'
make: *** [debian/stamp/build/kernel] Error 2

Quoted 2 lines

Compiling the kernel with both options as module or both options built-in results in a working kernel.

Len Brown posted a patch to fix this, although I can't find it in any email archives just now, so I'm appending it below.

Signature · 10 lines
From: Len Brown <[email protected]>
Subject: [PATCH] ACPI, i915: build fix

drivers/built-in.o: In function `intel_opregion_init':
(.text+0x9d540): undefined reference to `acpi_video_register'

Signed-off-by: Len Brown <[email protected]>
---
 drivers/gpu/drm/Kconfig |    6 ++++++
 1 files changed, 6 insertions(+), 0 deletions(-)
drivers/gpu/drm/Kconfig +6 -0
index 3a22eb9..f33d252 100644
@@ -83,6 +83,12 @@ config DRM_I915
 config DRM_I915_KMS
 	bool "Enable modesetting on intel by default"
 	depends on DRM_I915
+	# i915 KMS depends on ACPI_VIDEO when ACPI is enabled
+	# but for select to work, need to select ACPI_VIDEO's dependencies, ick
+	select VIDEO_OUTPUT_CONTROL if ACPI
+	select BACKLIGHT_CLASS_DEVICE if ACPI
+	select INPUT if ACPI
+	select ACPI_VIDEO if ACPI
 	help
 	  Choose this option if you want kernel modesetting enabled by default,
 	  and you have a new enough userspace to support this. Running old
author
#2 lore raw
Quoted 28 lines · Randy Dunlap
Quoted 27 lines · Lee

Hi list,

compiling 2.6.30-rc4 with following options will result in an compile error:

CONFIG_DRM_I915=y
CONFIG_ACPI_VIDEO=m

drivers/video/backlight/backlight.c: In function ‘backlight_device_register’:
drivers/video/backlight/backlight.c:247: warning: format not a string literal and no format arguments
drivers/video/output.c: In function ‘video_output_register’:
drivers/video/output.c:99: warning: format not a string literal and no format arguments
drivers/usb/storage/libusual.c: In function ‘usu_probe_thread’:
drivers/usb/storage/libusual.c:159: warning: format not a string literal and no format arguments
drivers/built-in.o: In function `intel_opregion_free':
(.text+0xaf051): undefined reference to acpi_video_exit' drivers/built-in.o: In function intel_opregion_init':
(.text+0xaf411): undefined reference to `acpi_video_register' make[1]: *** [.tmp_vmlinux1] Error 1
make[1]: Leaving directory `/home/randall/kernel-source'
make: *** [debian/stamp/build/kernel] Error 2

Quoted 7 lines
Quoted 2 lines

Compiling the kernel with both options as module or both options built-in results in a working kernel.

Len Brown posted a patch to fix this, although I can't find it in any email archives just now, so I'm appending it below.

Thanks! I'll keep an eye on it that it's merged for the next rc.