Skip to contentSkip to conversation

zoran: Fix &&/|| typo

PATCH In review Roel Kluin 2 participants 2 messages May 2, 2009 Media (V4L/DVB)

lore
Share & tools
lore

Roel Kluin

author
#0 lore raw

PATCH 1/1 zoran: Fix &&/|| typo

Fix &&/|| typo

drivers/media/video/zoran/zoran_card.c +1 -1
index ea6c577..ea9de8b 100644
@@ -1022,7 +1022,7 @@ zr36057_init (struct zoran *zr)
 	zr->vbuf_bytesperline = 0;
 
 	/* Avoid nonsense settings from user for default input/norm */
-	if (default_norm < 0 && default_norm > 2)
+	if (default_norm < 0 || default_norm > 2)
 		default_norm = 0;
 	if (default_norm == 0) {
 		zr->norm = V4L2_STD_PAL;
#1 lore raw

Hello, Roel

Quoted 7 lines · Roel Kluin

Fix &&/|| typo

drivers/media/video/zoran/zoran_card.c +0 -0
index ea6c577..ea9de8b 100644

drivers/media/video/zoran/zoran_card.c zr36057_init (struct zoran *zr) · line 1028

Quoted 8 lines
drivers/media/video/zoran/zoran_card.c +1 -1
@@ -1022,7 +1022,7 @@ zr36057_init (struct zoran *zr)
        zr->vbuf_bytesperline = 0;
 
        /* Avoid nonsense settings from user for default input/norm */
-       if (default_norm < 0 && default_norm > 2)
+       if (default_norm < 0 || default_norm > 2)
                default_norm = 0;
        if (default_norm == 0) {
                zr->norm = V4L2_STD_PAL;

Please, remember that all patches that you send need 'Signed-off-by' field. And i'm out of touch with events, but probably it's better to make description more dilated/patulous (i'm not sure here).

Signature · 1 line
Best regards, Klimov Alexey