IMote 2 ASoC Support
Subsystems (3)
PATCH 1/1 IMote 2 ASoC Support
From: Jonathan Cameron <[email protected]>
IMote2 ASoC Support
This patch adds the ASoC side of the board support for the Crossbow IMB400 daughter board.
Thanks to Crossbow for considerable assistance.
---
Relatively straight forward configuration with the PXA acting as the clock master.
sound/soc/pxa/Kconfig | 9 +++ sound/soc/pxa/Makefile | 2 + sound/soc/pxa/imote2.c | 131 +++++++++++++++++++++++++++++++++++++++++++++++
sound/soc/pxa/Kconfig +9 -0
@@ -134,3 +134,12 @@ config SND_PXA2XX_SOC_MIOA701 help Say Y if you want to add support for SoC audio on the MIO A701. + +config SND_PXA2XX_SOC_IMOTE2 + tristate "SoC Audio support for IMote 2" + depends on SND_PXA2XX_SOC && MACH_INTELMOTE2 + select SND_PXA2XX_SOC_I2S + select SND_SOC_WM8940 + help + Say Y if you want to add support for SoC audio on the + IMote 2.
sound/soc/pxa/Makefile +2 -0
@@ -22,6 +22,7 @@ snd-soc-palm27x-objs := palm27x.o snd-soc-zylonite-objs := zylonite.o snd-soc-magician-objs := magician.o snd-soc-mioa701-objs := mioa701_wm9713.o +snd-soc-imote2-objs := imote2.o obj-$(CONFIG_SND_PXA2XX_SOC_CORGI) += snd-soc-corgi.o obj-$(CONFIG_SND_PXA2XX_SOC_POODLE) += snd-soc-poodle.o
@@ -35,3 +36,4 @@ obj-$(CONFIG_SND_PXA2XX_SOC_PALM27X) += snd-soc-palm27x.o obj-$(CONFIG_SND_PXA2XX_SOC_MAGICIAN) += snd-soc-magician.o obj-$(CONFIG_SND_PXA2XX_SOC_MIOA701) += snd-soc-mioa701.o obj-$(CONFIG_SND_SOC_ZYLONITE) += snd-soc-zylonite.o +obj-$(CONFIG_SND_PXA2XX_SOC_IMOTE2) += snd-soc-imote2.o
sound/soc/pxa/imote2.c new file +131 -0
131 lines not on this page · raw message
sound/soc/pxa/imote2.c line 62
Quoted 3 lines · Jonathan Cameron
sound/soc/pxa/imote2.c new file +3
-0+/* Disable the PLL */ + ret =snd_soc_dai_set_pll (codec_dai,0 ,0 ,0 ); +if (ret <0 )
This seems very odd - the PLL is never enabled by your driver but you go through and explicitly disable it every time the driver is configured.
Other than that this looks fine; you're including more headers than you really need but that shouldn't do any harm.
Quoted 8 lines · Mark Brown
sound/soc/pxa/imote2.c line 62
Quoted 3 lines · Jonathan Cameron
sound/soc/pxa/imote2.c new file +3
-0+/* Disable the PLL */ + ret =snd_soc_dai_set_pll (codec_dai,0 ,0 ,0 ); +if (ret <0 )This seems very odd - the PLL is never enabled by your driver but you go through and explicitly disable it every time the driver is configured.
Fair point. It's a legacy from trying to test with it set up differently. I'll clear that out as it's only going to cause confusion.
Quoted 2 lines
Other than that this looks fine; you're including more headers than you really need but that shouldn't do any harm.
Oops, will clean them up.
Thanks,
Jonathan
From: Jonathan Cameron <[email protected]>
IMote2 ASoC Support
This patch adds the ASoC side of the board support for the Crossbow IMB400 daughter board.
Thanks to Crossbow for considerable assistance.
---
Changes since last post (in response to Mark's comments)
* Removed PLL code. The driver never initializes so why bother to disable it.
* Removed excess headers.
Relatively straight forward configuration with the PXA acting as the clock master.
sound/soc/pxa/Kconfig | 9 ++++ sound/soc/pxa/Makefile | 2 + sound/soc/pxa/imote2.c | 114 ++++++++++++++++++++++++++++++++++++++++++++++++ 3 files changed, 125 insertions(+), 0 deletions(-)
sound/soc/pxa/Kconfig +9 -0
@@ -134,3 +134,12 @@ config SND_PXA2XX_SOC_MIOA701 help Say Y if you want to add support for SoC audio on the MIO A701. + +config SND_PXA2XX_SOC_IMOTE2 + tristate "SoC Audio support for IMote 2" + depends on SND_PXA2XX_SOC && MACH_INTELMOTE2 + select SND_PXA2XX_SOC_I2S + select SND_SOC_WM8940 + help + Say Y if you want to add support for SoC audio on the + IMote 2.
sound/soc/pxa/Makefile +2 -0
@@ -22,6 +22,7 @@ snd-soc-palm27x-objs := palm27x.o snd-soc-zylonite-objs := zylonite.o snd-soc-magician-objs := magician.o snd-soc-mioa701-objs := mioa701_wm9713.o +snd-soc-imote2-objs := imote2.o obj-$(CONFIG_SND_PXA2XX_SOC_CORGI) += snd-soc-corgi.o obj-$(CONFIG_SND_PXA2XX_SOC_POODLE) += snd-soc-poodle.o
@@ -35,3 +36,4 @@ obj-$(CONFIG_SND_PXA2XX_SOC_PALM27X) += snd-soc-palm27x.o obj-$(CONFIG_SND_PXA2XX_SOC_MAGICIAN) += snd-soc-magician.o obj-$(CONFIG_SND_PXA2XX_SOC_MIOA701) += snd-soc-mioa701.o obj-$(CONFIG_SND_SOC_ZYLONITE) += snd-soc-zylonite.o +obj-$(CONFIG_SND_PXA2XX_SOC_IMOTE2) += snd-soc-imote2.o
sound/soc/pxa/imote2.c new file +114 -0
114 lines not on this page · raw message
Mark Brown
AppliedQuoted 10 lines · Jonathan Cameron
From: Jonathan Cameron <[email protected]>
IMote2 ASoC Support
This patch adds the ASoC side of the board support for the Crossbow IMB400 daughter board.
Thanks to Crossbow for considerable assistance.
Signed-off-by Jonathan Cameron <[email protected]>
applied, thanks!