Skip to contentSkip to conversation

fix up btrace options & manpage

PATCH New Eric Sandeen 1 participant 1 message May 4, 2009

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 fix up btrace options & manpage

The btrace script & man page didn't quite match for options, and the btrace script was missing a few options in the getopts specification (b&n). Also, there seems to be no such thing as a "summarize" option anywhere, so remove it.

Reported-by /Milos Malik <[email protected] <mailto:[email protected]>>/

---

(this goes after the general manpage cleanup I sent, sorry, should have been a series in retrospect)

btrace +2 -5
index f902707..45c10cf 100644
@@ -8,11 +8,10 @@
 
 TRACEOPTS=""
 PARSEOPTS="-b100000"
-SUMMARIZE=""
-USAGE="Usage: btrace [-s] [-t] [-S] [-w N] [-a <trace>...] [-r <dbg mnt]<dev>..."
+USAGE="Usage: btrace [-s] [-t] [-w N] [-n N] [-b N] [-a <trace>...] [-r <dbg mnt>] <dev>..."
 DIRNAME=`dirname $0`
 
-while getopts "a:r:stSw:hv" c
+while getopts "a:w:n:b:r:sthv" c
 do
 	case $c in
 	a)	TRACEOPTS=$TRACEOPTS" -a "$OPTARG" ";;
@@ -24,13 +23,11 @@ do
 	t)	PARSEOPTS=$PARSEOPTS" -t";;
 	h)	PARSEOPTS=$PARSEOPTS" -h";;
 	v)	PARSEOPTS=$PARSEOPTS" -v";;
-	S)	SUMMARIZE="";;
 	\?)	echo $USAGE 1>&2
 		exit 2
 		;;
 	esac
 done
-PARSEOPTS="${PARSEOPTS} ${SUMMARIZE}"
 
 shift `expr $OPTIND - 1`
 if [ $# -eq 0 ]; then
doc/btrace.8 +5 -1
index 1e6c06d..a1f34c2 100644
@@ -6,7 +6,7 @@ btrace \- perform live tracing for block devices
 
 
 .SH SYNOPSIS
-.B btrace [\-s] [\-t] [\-w \fIN\fN] [\-n \fIN\fR] [\-b \fIN\fR]  [\-a <\fItrace\fR>...] <\fIdev\fR>...
+.B btrace [\-s] [\-t] [\-w \fIN\fN] [\-n \fIN\fR] [\-b \fIN\fR] [\-r \fI<dbg mnt>\fR] [\-a <\fItrace\fR>...] <\fIdev\fR>...
 .br
 
 
@@ -41,6 +41,10 @@ Specifies buffer size for event extraction (scaled by 1024) (see
 \fIblktrace\fR (8)).
 
 .HP 4
+.B \-r \fI<dbg mnt>\fR
+Specifies the debugfs mountpoint.
+
+.HP 4
 .B \-a <\fItrace\fR>...
 Adds mask to current filter (see \fIblktrace\fR (8)).