Skip to contentSkip to conversation

ocfs2: Don't print error when listing too many xattrs.

PATCH New Tao Ma 2 participants 6 messages May 3, 2009 – May 5, 2009 OCFS2

lore
Share & tools
lore

Tao Ma

author
#0 lore raw

PATCH 1/1 ocfs2: Don't print error when listing too many xattrs.

Currently, when listing xattrs, kernel define XATTR_LIST_MAX as 65536 in include/linux/limits.h, so it can't handle too many xattrs.

But with ocfs2 xattr tree, we actually have no limit for the number. And it will pollute the message with something like this when listing. (27738,0):ocfs2_iterate_xattr_buckets:3158 ERROR: status = -34 (27738,0):ocfs2_xattr_tree_list_index_block:3264 ERROR: status = -34

So don't print "ERROR" message as this is not an ocfs2 error.

---
 fs/ocfs2/xattr.c |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)
fs/ocfs2/xattr.c +3 -2
index 1563101..ba320e2 100644
@@ -3154,7 +3154,7 @@ static int ocfs2_iterate_xattr_buckets(struct inode *inode,
 		     le32_to_cpu(bucket_xh(bucket)->xh_entries[0].xe_name_hash));
 		if (func) {
 			ret = func(inode, bucket, para);
-			if (ret)
+			if (ret && ret != -ERANGE)
 				mlog_errno(ret);
 			/* Fall through to bucket_relse() */
 		}
@@ -3261,7 +3261,8 @@ static int ocfs2_xattr_tree_list_index_block(struct inode *inode,
 						  ocfs2_list_xattr_bucket,
 						  &xl);
 		if (ret) {
-			mlog_errno(ret);
+			if (ret != -ERANGE)
+				mlog_errno(ret);
 			goto out;
 		}
 
Signature · 1 line
1.5.5
#1 lore raw

PATCH 1/1 ocfs2: Don't print error when listing too many xattrs.

Quoted 9 lines · Tao Ma

Currently, when listing xattrs, kernel define XATTR_LIST_MAX as 65536 in include/linux/limits.h, so it can't handle too many xattrs.

But with ocfs2 xattr tree, we actually have no limit for the number. And it will pollute the message with something like this when listing. (27738,0):ocfs2_iterate_xattr_buckets:3158 ERROR: status = -34 (27738,0):ocfs2_xattr_tree_list_index_block:3264 ERROR: status = -34

So don't print "ERROR" message as this is not an ocfs2 error.

Hmm, but this will stop iteration of the xattrs right where we
hit the large one. I don't think that's correct. At the very least, we should go on listing with the following xattrs.
Now, the xattr with a too-long name - should we skip it, or
should we list a truncated name? That I'm not sure of.

Joel

Signature · 10 lines
 print STDOUT q
 Just another Perl hacker,
 unless $spring
	- Larry Wall

Joel Becker
Principal Software Developer
Oracle
E-mail: joel.becker at oracle.com
Phone: (650) 506-8127
author
#2 lore raw

PATCH 1/1 ocfs2: Don't print error when listing too many xattrs.

Hi Joel,

Quoted 9 lines · Joel Becker
Quoted 8 lines · Tao Ma

Currently, when listing xattrs, kernel define XATTR_LIST_MAX as 65536 in include/linux/limits.h, so it can't handle too many xattrs.

But with ocfs2 xattr tree, we actually have no limit for the number. And it will pollute the message with something like this when listing. (27738,0):ocfs2_iterate_xattr_buckets:3158 ERROR: status = -34 (27738,0):ocfs2_xattr_tree_list_index_block:3264 ERROR: status = -34

Quoted 7 lines
Quoted 1 line

So don't print "ERROR" message as this is not an ocfs2 error.

Hmm, but this will stop iteration of the xattrs right where we
hit the large one. I don't think that's correct. At the very least, we should go on listing with the following xattrs.
Now, the xattr with a too-long name - should we skip it, or
should we list a truncated name? That I'm not sure of.

I think we should stop at where we are, return errors and let the user space handle this.

Just give you an example.
1. for((i=0;i<20000;i++))do setfattr -n "user.name$i" -v "aaaaa" /mnt/ocfs2/a;done
This will create a very long name list.

2. getfattr /mnt/ocfs2/a
/mnt/ocfs2/a: Argument list too long
So you see it says clearly that the name list is too long. and the same goes for listxattr(2).
If the size of the list buffer is too small to hold the result, errno is set to ERANGE.

But if you go ahead and don't return errors. we will get a name list of about ~5000 xattrs and no error is returned. So the user may wonder why I set 20000 xattrs, but only get 5000 xattrs and look@this as a bug.

Regards,
Tao

#3 lore raw

PATCH 1/1 ocfs2: Don't print error when listing too many xattrs.

Quoted 32 lines · Tao Ma
Quoted 9 lines · Joel Becker
Quoted 8 lines · Tao Ma

Currently, when listing xattrs, kernel define XATTR_LIST_MAX as 65536 in include/linux/limits.h, so it can't handle too many xattrs.

But with ocfs2 xattr tree, we actually have no limit for the number. And it will pollute the message with something like this when listing. (27738,0):ocfs2_iterate_xattr_buckets:3158 ERROR: status = -34 (27738,0):ocfs2_xattr_tree_list_index_block:3264 ERROR: status = -34

Quoted 7 lines
Quoted 1 line

So don't print "ERROR" message as this is not an ocfs2 error.

Hmm, but this will stop iteration of the xattrs right where we
hit the large one. I don't think that's correct. At the very least, we should go on listing with the following xattrs.
Now, the xattr with a too-long name - should we skip it, or
should we list a truncated name? That I'm not sure of.

I think we should stop at where we are, return errors and let the user space handle this.

Just give you an example.
1. for((i=0;i<20000;i++))do setfattr -n "user.name$i" -v "aaaaa" /mnt/ocfs2/a;done
This will create a very long name list.

2. getfattr /mnt/ocfs2/a
/mnt/ocfs2/a: Argument list too long
So you see it says clearly that the name list is too long. and the same goes for listxattr(2).
If the size of the list buffer is too small to hold the result, errno is set to ERANGE.

Quoted 3 lines

But if you go ahead and don't return errors. we will get a name list of about ~5000 xattrs and no error is returned. So the user may wonder why I set 20000 xattrs, but only get 5000 xattrs and look at this as a bug.

I think I mis-read. I was thinking you'd error if the name of
an xattr was too long, and thus I could never list the xattrs past that name. Instead, this is apparently that the entire list grew past an arbitrary limit. If the kernel is enforcing this limit, this is probably the correct way to go.

Joel

Signature · 9 lines
Life's Little Instruction Book #267

	"Lie on your back and look at the stars."

Joel Becker
Principal Software Developer
Oracle
E-mail: joel.becker at oracle.com
Phone: (650) 506-8127
author
#4 lore raw

PATCH 1/1 ocfs2: Don't print error when listing too many xattrs.

Quoted 36 lines · Joel Becker
Quoted 31 lines · Tao Ma
Quoted 9 lines · Joel Becker
Quoted 8 lines · Tao Ma

Currently, when listing xattrs, kernel define XATTR_LIST_MAX as 65536 in include/linux/limits.h, so it can't handle too many xattrs.

But with ocfs2 xattr tree, we actually have no limit for the number. And it will pollute the message with something like this when listing. (27738,0):ocfs2_iterate_xattr_buckets:3158 ERROR: status = -34 (27738,0):ocfs2_xattr_tree_list_index_block:3264 ERROR: status = -34

Quoted 6 lines
Quoted 1 line

So don't print "ERROR" message as this is not an ocfs2 error.

Hmm, but this will stop iteration of the xattrs right where we
hit the large one. I don't think that's correct. At the very least, we should go on listing with the following xattrs.
Now, the xattr with a too-long name - should we skip it, or
should we list a truncated name? That I'm not sure of.

I think we should stop at where we are, return errors and let the user space handle this.

Just give you an example.
1. for((i=0;i<20000;i++))do setfattr -n "user.name$i" -v "aaaaa" /mnt/ocfs2/a;done
This will create a very long name list.

2. getfattr /mnt/ocfs2/a
/mnt/ocfs2/a: Argument list too long
So you see it says clearly that the name list is too long. and the same goes for listxattr(2).
If the size of the list buffer is too small to hold the result, errno is set to ERANGE.

Quoted 3 lines

But if you go ahead and don't return errors. we will get a name list of about ~5000 xattrs and no error is returned. So the user may wonder why I set 20000 xattrs, but only get 5000 xattrs and look at this as a bug.

Quoted 5 lines

I think I mis-read. I was thinking you'd error if the name of
an xattr was too long, and thus I could never list the xattrs past that name. Instead, this is apparently that the entire list grew past an arbitrary limit. If the kernel is enforcing this limit, this is probably the correct way to go.

yeah, this is what I mean. Sorry for my poor English.

Regards,
Tao

#5 lore raw

PATCH 1/1 ocfs2: Don't print error when listing too many xattrs.

In reply to Tao Ma
Quoted 11 lines · Tao Ma

Currently, when listing xattrs, kernel define XATTR_LIST_MAX as 65536 in include/linux/limits.h, so it can't handle too many xattrs.

But with ocfs2 xattr tree, we actually have no limit for the number. And it will pollute the message with something like this when listing. (27738,0):ocfs2_iterate_xattr_buckets:3158 ERROR: status = -34 (27738,0):ocfs2_xattr_tree_list_index_block:3264 ERROR: status = -34

So don't print "ERROR" message as this is not an ocfs2 error.

This is in 'fixes' now.

Joel

Signature · 8 lines
"Egotist: a person more interested in himself than in me."
         - Ambrose Bierce 

Joel Becker
Principal Software Developer
Oracle
E-mail: joel.becker at oracle.com
Phone: (650) 506-8127