Skip to contentSkip to conversation

platform/x86: amd: pmc: Remove __maybe_unused from amd_pmc_suspend_handler()

PATCH In review Hans de Goede 2 participants 3 messages Apr 10, 2023 – Apr 11, 2023 x86 platform drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 platform/x86: amd: pmc: Remove __maybe_unused from amd_pmc_suspend_handler()

Now that the pmc code has switched to DEFINE_SIMPLE_DEV_PM_OPS() the __maybe_unused is no longer necessary, drop it.

---
 drivers/platform/x86/amd/pmc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/platform/x86/amd/pmc.c +1 -1
index 2761e9b76e95..2e2b99b93df7 100644
@@ -840,7 +840,7 @@ static struct acpi_s2idle_dev_ops amd_pmc_s2idle_dev_ops = {
 	.restore = amd_pmc_s2idle_restore,
 };
 
-static int __maybe_unused amd_pmc_suspend_handler(struct device *dev)
+static int amd_pmc_suspend_handler(struct device *dev)
 {
 	struct amd_pmc_dev *pdev = dev_get_drvdata(dev);
 
Signature · 1 line
2.39.1
Reviewed-by on v1 1/1
#1 lore raw

[Public]

Quoted 24 lines

Now that the pmc code has switched to DEFINE_SIMPLE_DEV_PM_OPS() the __maybe_unused is no longer necessary, drop it.

---
 drivers/platform/x86/amd/pmc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/platform/x86/amd/pmc.c +1 -1
index 2761e9b76e95..2e2b99b93df7 100644
@@ -840,7 +840,7 @@ static struct acpi_s2idle_dev_ops
 amd_pmc_s2idle_dev_ops = {
 	.restore = amd_pmc_s2idle_restore,
 };
 
-static int __maybe_unused amd_pmc_suspend_handler(struct device
 *dev)
+static int amd_pmc_suspend_handler(struct device *dev)
 {

struct amd_pmc_dev *pdev = dev_get_drvdata(dev);

Quoted 2 lines

--
2.39.1

#2 lore raw

Hi,

Quoted 26 lines · Mario

[Public]

Quoted 24 lines

Now that the pmc code has switched to DEFINE_SIMPLE_DEV_PM_OPS() the __maybe_unused is no longer necessary, drop it.

---
 drivers/platform/x86/amd/pmc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/platform/x86/amd/pmc.c +1 -1
index 2761e9b76e95..2e2b99b93df7 100644
@@ -840,7 +840,7 @@ static struct acpi_s2idle_dev_ops
 amd_pmc_s2idle_dev_ops = {
 	.restore = amd_pmc_s2idle_restore,
 };
 
-static int __maybe_unused amd_pmc_suspend_handler(struct device
 *dev)
+static int amd_pmc_suspend_handler(struct device *dev)
 {

struct amd_pmc_dev *pdev = dev_get_drvdata(dev);

Quoted 4 lines
Quoted 2 lines

--
2.39.1

Thanks.

I've added this to my review-hans (soon to be for-next) branch now.

Regards,

Hans