platform/x86: amd: pmc: Remove __maybe_unused from amd_pmc_suspend_handler()
PATCH 1/1 platform/x86: amd: pmc: Remove __maybe_unused from amd_pmc_suspend_handler()
Now that the pmc code has switched to DEFINE_SIMPLE_DEV_PM_OPS() the __maybe_unused is no longer necessary, drop it.
Signed-off-by Hans de Goede <[email protected]>
--- drivers/platform/x86/amd/pmc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/platform/x86/amd/pmc.c +1 -1
@@ -840,7 +840,7 @@ static struct acpi_s2idle_dev_ops amd_pmc_s2idle_dev_ops = { .restore = amd_pmc_s2idle_restore, }; -static int __maybe_unused amd_pmc_suspend_handler (struct device *dev) +static int amd_pmc_suspend_handler (struct device *dev) {struct amd_pmc_dev *pdev =dev_get_drvdata (dev);
Signature · 1 line
2.39.1
[Public]
Quoted 24 lines
Now that the pmc code has switched to
DEFINE_SIMPLE_DEV_PM_OPS()the__maybe_unusedis no longer necessary, drop it.Signed-off-by Hans de Goede <[email protected]>--- drivers/platform/x86/amd/pmc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/platform/x86/amd/pmc.c +1
-1@@ -840,7 +840,7 @@ static struct acpi_s2idle_dev_ops amd_pmc_s2idle_dev_ops = { .restore = amd_pmc_s2idle_restore, }; -static int __maybe_unused amd_pmc_suspend_handler (struct device *dev) +static int amd_pmc_suspend_handler (struct device *dev) {struct
amd_pmc_dev*pdev =dev_get_drvdata(dev);
Quoted 2 lines
--
2.39.1
Reviewed-by Mario Limonciello <[email protected]>
Hi,
Quoted 26 lines · Mario
[Public]
Quoted 24 lines
Now that the pmc code has switched to
DEFINE_SIMPLE_DEV_PM_OPS()the__maybe_unusedis no longer necessary, drop it.Signed-off-by Hans de Goede <[email protected]>--- drivers/platform/x86/amd/pmc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/platform/x86/amd/pmc.c +1
-1@@ -840,7 +840,7 @@ static struct acpi_s2idle_dev_ops amd_pmc_s2idle_dev_ops = { .restore = amd_pmc_s2idle_restore, }; -static int __maybe_unused amd_pmc_suspend_handler (struct device *dev) +static int amd_pmc_suspend_handler (struct device *dev) {struct
amd_pmc_dev*pdev =dev_get_drvdata(dev);
Quoted 4 lines
Quoted 2 lines
--
2.39.1Reviewed-by Mario Limonciello <[email protected]>
Thanks.
I've added this to my review-hans (soon to be for-next) branch now.
Regards,
Hans