Skip to contentSkip to conversation

pr_info("I changed uvcvideo driver in the Linux Kernel\n");

PATCH In review XiaxiShen 2 participants 3 messages Dec 30, 2022 – Jan 10, 2023 1 message not in the archive

Subsystems (2)
lore
Share & tools
lore

XiaxiShen

author
#0 lore raw

PATCH 1/1 pr_info("I changed uvcvideo driver in the Linux Kernel\n");

---
 drivers/media/usb/uvc/uvc_driver.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/media/usb/uvc/uvc_driver.c +2 -0
index e4bcb5011360..60778a5a2b4e 100644
@@ -2082,6 +2082,8 @@ static int uvc_probe(struct usb_interface *intf,
 		(const struct uvc_device_info *)id->driver_info;
 	int function;
 	int ret;
+	pr_info("I changed uvcvideo driver in the Linux Kernel\n");
+
 
 	/* Allocate memory for the device and initialize it. */
 	dev = kzalloc(sizeof(*dev), GFP_KERNEL);
Signature · 1 line
2.34.1
#1 lore raw

Hello XiaxiShen,

From Documentation/process/researcher-guidelines.rst:

"The Linux kernel community expects that everyone interacting with the project is participating in good faith to make Linux better."

Please explain how your patch will make Linux better. "I added a pr_info() which emits information unrelated to work of the driver" is not enough of an explanation.

Failing to do so and to adhere to the expectation quoted above you risk any patches to the kernel submitted by you being disregarded.

Andrzej

W dniu 30.12.2022 o 04:46, XiaxiShen pisze:

Quoted 18 lines
---
  drivers/media/usb/uvc/uvc_driver.c | 2 ++
  1 file changed, 2 insertions(+)
drivers/media/usb/uvc/uvc_driver.c +2 -0
index e4bcb5011360..60778a5a2b4e 100644
@@ -2082,6 +2082,8 @@ static int uvc_probe(struct usb_interface *intf,
  		(const struct uvc_device_info *)id->driver_info;
  	int function;
  	int ret;
+	pr_info("I changed uvcvideo driver in the Linux Kernel\n");
+
 
  	/* Allocate memory for the device and initialize it. */
  	dev = kzalloc(sizeof(*dev), GFP_KERNEL);

A message that is not in the archive (sent off-list or not yet received): CABtBSabksqweaDjhSVEaETYtCoQCVE1stPN7wwJr=eLPEU3X2w@mail.gmail.com

#3 lore raw

Hi,

W dniu 10.01.2023 o 00:39, Xiaxi Shen pisze:

Quoted 4 lines

Hi Andrzej,

Thanks for your advice.
It is my first time to send a patch, I will definitely check my explanation according to relevant guidelines before my future submission

I recommend reading:

Documentation/process/*.

Regards,

Andrzej

Quoted 44 lines

Yours sincerely,
Xiaxi Shen

Andrzej Pietrasiewicz <[email protected] <mailto:[email protected]>> 于2023年1月9日周一 08:14写道:

    Hello XiaxiShen,

      From Documentation/process/researcher-guidelines.rst:

    "The Linux kernel community expects that everyone interacting with the
    project is participating in good faith to make Linux better."

    Please explain how your patch will make Linux better. "I added a pr_info()
    which emits information unrelated to work of the driver" is not enough of an
    explanation.

    Failing to do so and to adhere to the expectation quoted above
    you risk any patches to the kernel submitted by you being disregarded.

    Andrzej

    W dniu 30.12.2022 o 04:46, XiaxiShen pisze:
     > Signed-off-by: XiaxiShen <[email protected]
    <mailto:[email protected]>>
     > ---
     >   drivers/media/usb/uvc/uvc_driver.c | 2 ++
     >   1 file changed, 2 insertions(+)
     >
     > diff --git a/drivers/media/usb/uvc/uvc_driver.c
    b/drivers/media/usb/uvc/uvc_driver.c
     > index e4bcb5011360..60778a5a2b4e 100644
     > --- a/drivers/media/usb/uvc/uvc_driver.c
     > +++ b/drivers/media/usb/uvc/uvc_driver.c
     > @@ -2082,6 +2082,8 @@ static int uvc_probe(struct usb_interface *intf,
     >               (const struct uvc_device_info *)id->driver_info;
     >       int function;
     >       int ret;
     > +     pr_info("I changed uvcvideo driver in the Linux Kernel\n");
     > +
     >
     >       /* Allocate memory for the device and initialize it. */
     >       dev = kzalloc(sizeof(*dev), GFP_KERNEL);