Skip to contentSkip to conversation

arm64: dts: rockchip: Add ArmSom Sige7 board

PATCH In review Jianfeng Liu 3 participants 5 messages Apr 13, 2024 – Apr 15, 2024

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/2 arm64: dts: rockchip: Add ArmSom Sige7 board

Specification:
Rockchip Rk3588 SoC
4x ARM Cortex-A76, 4x ARM Cortex-A55 8/16/32GB Memory LPDDR4/LPDDR4x
Mali G610MP4 GPU
2× MIPI-CSI Connector
1× MIPI-DSI Connector
1x M.2 Key M (PCIe 3.0 4-lanes)
2x RTL8125 2.5G Ethernet
Onboard AP6275P for WIFI6/BT5 32GB/64GB/128GB eMMC
MicroSD card slot
1x USB2.0, 1x USB3.0 Type-A, 1x US3.0 Type-C 1x HDMI Output, 1x type-C DP Output

Functions work normally:

        USB2.0 Host
        USB3.0 Type-A Host (depend on just applied USBDP driver[1])
        M.2 Key M (PCIe 3.0 4-lanes)
        2x RTL8125 2.5G Ethernet
        eMMC
        MicroSD card

More information can be obtained from the following website
https://docs.armsom.org/armsom-sige7

[1] https://lore.kernel.org/all/[email protected]/

---
 arch/arm64/boot/dts/rockchip/Makefile         |   1 +
 .../boot/dts/rockchip/rk3588-armsom-sige7.dts | 725 ++++++++++++++++++
 2 files changed, 726 insertions(+)
 create mode 100644 arch/arm64/boot/dts/rockchip/rk3588-armsom-sige7.dts
arch/arm64/boot/dts/rockchip/Makefile +1 -0
index 7da198be8..0624c7284 100644
@@ -111,6 +111,7 @@ dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-roc-pc.dtb
 dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-rock-3a.dtb
 dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-wolfvision-pf5.dtb
 dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-wolfvision-pf5-io-expander.dtbo
+dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588-armsom-sige7.dtb
 dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588-coolpi-cm5-evb.dtb
 dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588-edgeble-neu6a-io.dtb
 dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588-edgeble-neu6a-wifi.dtbo
arch/arm64/boot/dts/rockchip/rk3588-armsom-sige7.dts new file +725 -0

725 lines not on this page · raw message

--
2.34.1

#1 lore raw

PATCH 2/2 Add devicetree binding for ArmSoM Sige7 board

---
 Documentation/devicetree/bindings/arm/rockchip.yaml | 5 +++++
 1 file changed, 5 insertions(+)
Documentation/devicetree/bindings/arm/rockchip.yaml +5 -0
index 4bd033ade..fd644e32c 100644
@@ -49,6 +49,11 @@ properties:
               - anbernic,rg-arc-s
           - const: rockchip,rk3566
 
+      - description: ArmSoM Sige7 board
+        items:
+          - const: armsom,sige7
+          - const: rockchip,rk3588
+
       - description: Asus Tinker board
         items:
           - const: asus,rk3288-tinker

--
2.34.1

#2 lore raw

Re: [PATCH 2/2] Add devicetree binding for ArmSoM Sige7 board

Quoted 3 lines · Jianfeng Liu
---
 Documentation/devicetree/bindings/arm/rockchip.yaml | 5 +++++

Missing commit msg. Describe the hardware.

Please use subject prefixes matching the subsystem. You can get them for example with git log --oneline -- DIRECTORY_OR_FILE on the directory your patch is touching.

Best regards,
Krzysztof

#3 lore raw
In reply to Jianfeng Liu
Quoted 54 lines · Jianfeng Liu

Specification:
Rockchip Rk3588 SoC
4x ARM Cortex-A76, 4x ARM Cortex-A55 8/16/32GB Memory LPDDR4/LPDDR4x
Mali G610MP4 GPU
2× MIPI-CSI Connector
1× MIPI-DSI Connector
1x M.2 Key M (PCIe 3.0 4-lanes)
2x RTL8125 2.5G Ethernet
Onboard AP6275P for WIFI6/BT5 32GB/64GB/128GB eMMC
MicroSD card slot
1x USB2.0, 1x USB3.0 Type-A, 1x US3.0 Type-C 1x HDMI Output, 1x type-C DP Output

Functions work normally:

        USB2.0 Host
        USB3.0 Type-A Host (depend on just applied USBDP driver[1])
        M.2 Key M (PCIe 3.0 4-lanes)
        2x RTL8125 2.5G Ethernet
        eMMC
        MicroSD card

More information can be obtained from the following website
https://docs.armsom.org/armsom-sige7

[1] https://lore.kernel.org/all/[email protected]/

---
 arch/arm64/boot/dts/rockchip/Makefile         |   1 +
 .../boot/dts/rockchip/rk3588-armsom-sige7.dts | 725 ++++++++++++++++++
 2 files changed, 726 insertions(+)
 create mode 100644 arch/arm64/boot/dts/rockchip/rk3588-armsom-sige7.dts
arch/arm64/boot/dts/rockchip/Makefile +1 -0
index 7da198be8..0624c7284 100644
@@ -111,6 +111,7 @@ dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-roc-pc.dtb
 dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-rock-3a.dtb
 dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-wolfvision-pf5.dtb
 dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-wolfvision-pf5-io-expander.dtbo
+dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588-armsom-sige7.dtb
 dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588-coolpi-cm5-evb.dtb
 dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588-edgeble-neu6a-io.dtb
 dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588-edgeble-neu6a-wifi.dtbo
arch/arm64/boot/dts/rockchip/rk3588-armsom-sige7.dts new file +1 -0
new file mode 100644
index 000000000..aa45e60bb
@@ -0,0 +1,725 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)

arch/arm64/boot/dts/rockchip/rk3588-armsom-sige7.dts line 11

Quoted 10 lines
arch/arm64/boot/dts/rockchip/rk3588-armsom-sige7.dts new file +10 -0
+
+/dts-v1/;
+
+#include <dt-bindings/gpio/gpio.h>
+#include <dt-bindings/leds/common.h>
+#include "rk3588.dtsi"
+
+/ {
+	model = "ArmSoM Sige7";
+	compatible = "armsom,sige7", "rockchip,rk3588";

Bindings come before users.

Quoted 23 lines
arch/arm64/boot/dts/rockchip/rk3588-armsom-sige7.dts new file +23 -0
+
+	aliases {
+		mmc0 = &sdhci;
+		mmc1 = &sdmmc;
+	};
+
+	chosen {
+		stdout-path = "serial2:1500000n8";
+	};
+
+	analog-sound {
+		compatible = "audio-graph-card";
+		label = "rk3588-es8316";
+
+		widgets = "Microphone", "Mic Jack",
+			  "Headphone", "Headphones";
+
+		routing = "MIC2", "Mic Jack",
+			  "Headphones", "HPOL",
+			  "Headphones", "HPOR";
+
+		dais = <&i2s0_8ch_p0>;
+		hp-det-gpio = <&gpio1 RK_PD5 GPIO_ACTIVE_HIGH>;

arch/arm64/boot/dts/rockchip/rk3588-armsom-sige7.dts line 44

Quoted 10 lines
arch/arm64/boot/dts/rockchip/rk3588-armsom-sige7.dts new file +10 -0
+		pinctrl-names = "default";
+		pinctrl-0 = <&hp_detect>;
+	};
+
+	leds {
+		compatible = "gpio-leds";
+		pinctrl-names = "default";
+		pinctrl-0 = <&led_rgb_g>;
+
+		led_rgb_g {

No underscores in node names.

Best regards,
Krzysztof

maintainer
#4 lore raw
In reply to Jianfeng Liu
Quoted 26 lines · Jianfeng Liu

Specification:
Rockchip Rk3588 SoC
4x ARM Cortex-A76, 4x ARM Cortex-A55 8/16/32GB Memory LPDDR4/LPDDR4x
Mali G610MP4 GPU
2× MIPI-CSI Connector
1× MIPI-DSI Connector
1x M.2 Key M (PCIe 3.0 4-lanes)
2x RTL8125 2.5G Ethernet
Onboard AP6275P for WIFI6/BT5 32GB/64GB/128GB eMMC
MicroSD card slot
1x USB2.0, 1x USB3.0 Type-A, 1x US3.0 Type-C 1x HDMI Output, 1x type-C DP Output

Functions work normally:

        USB2.0 Host
        USB3.0 Type-A Host (depend on just applied USBDP driver[1])
        M.2 Key M (PCIe 3.0 4-lanes)
        2x RTL8125 2.5G Ethernet
        eMMC
        MicroSD card

More information can be obtained from the following website
https://docs.armsom.org/armsom-sige7

Quoted 9 lines

[1] https://lore.kernel.org/all/[email protected]/

---
 arch/arm64/boot/dts/rockchip/Makefile         |   1 +
 .../boot/dts/rockchip/rk3588-armsom-sige7.dts | 725 ++++++++++++++++++
 2 files changed, 726 insertions(+)
 create mode 100644 arch/arm64/boot/dts/rockchip/rk3588-armsom-sige7.dts

My bot found new DTB warnings on the .dts files added or changed in this series.

Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings are fixed by another series. Ultimately, it is up to the platform maintainer whether these warnings are acceptable or not. No need to reply unless the platform maintainer has comments.

If you already ran DT checks and didn't see these error(s), then make sure dt-schema is up to date:

  pip3 install dtschema --upgrade

New warnings running 'make CHECK_DTBS=y rockchip/rk3588-armsom-sige7.dtb' for [email protected]:

arch/arm64/boot/dts/rockchip/rk3588-armsom-sige7.dtb: pcie@fe150000: 'pinctrl-0' is a dependency of 'pinctrl-names'
from schema $id: http://devicetree.org/schemas/pinctrl/pinctrl-consumer.yaml#
arch/arm64/boot/dts/rockchip/rk3588-armsom-sige7.dtb: leds: led_rgb_r:linux,default-trigger: 'oneOf' conditional failed, one must be fixed:

	'default-off' is not one of ['backlight', 'default-on', 'heartbeat', 'disk-activity', 'disk-read', 'disk-write', 'timer', 'pattern', 'audio-micmute', 'audio-mute', 'bluetooth-power', 'flash', 'kbd-capslock', 'mtd', 'nand-disk', 'none', 'torch', 'usb-gadget', 'usb-host', 'usbport']
	'default-off' does not match '^cpu[0-9]*$'
	'default-off' does not match '^hci[0-9]+-power$'
	'default-off' does not match '^mmc[0-9]+$'
	'default-off' does not match '^phy[0-9]+tx$'
	from schema $id: http://devicetree.org/schemas/leds/leds-gpio.yaml#

arch/arm64/boot/dts/rockchip/rk3588-armsom-sige7.dtb: leds: led_rgb_r: Unevaluated properties are not allowed ('linux,default-trigger' was unexpected)
from schema $id: http://devicetree.org/schemas/leds/leds-gpio.yaml#