net: phy: phylink: fix uninitialized variable in phylink_get_mac_state
Subsystems (4)
Heiner Kallweit
maintainerPATCH v3 1/1 net: phy: phylink: fix uninitialized variable in phylink_get_mac_state
When debugging an issue I found implausible values in state->pause. Reason in that state->pause isn't initialized and later only single bits are changed. Also the struct itself isn't initialized in phylink_resolve(). So better initialize state->pause and other not yet initialized fields.
v2:
- use right function name in subject
v3:
- initialize additional fields
--- drivers/net/phy/phylink.c | 4 ++++ 1 file changed, 4 insertions(+)
drivers/net/phy/phylink.c +4 -0
@@ -324,6 +324,10 @@ static int phylink_get_mac_state(struct phylink *pl, struct phylink_link_state *linkmode_zero (state->lp_advertising); state->interface = pl->link_config.interface; state->an_enabled = pl->link_config.an_enabled; + state->speed =SPEED_UNKNOWN ; + state->duplex =DUPLEX_UNKNOWN ; + state->pause =MLO_PAUSE_NONE ; + state->an_complete =0 ; state->link =1 ;return pl->ops->mac_link_state (ndev, state);
Signature · 1 line
2.20.1
David Miller
maintainerFrom: Heiner Kallweit <[email protected]>
Date: Tue, 26 Feb 2019 19:29:22 +0100
Quoted 6 lines
When debugging an issue I found implausible values in
state->pause. Reason in thatstate->pauseisn't initialized and later only single bits are changed. Also the struct itself isn't initialized inphylink_resolve(). So better initializestate->pauseand other not yet initialized fields.
Quoted 7 lines
v2:
- use right function name in subject
v3:
- initialize additional fieldsFixes 9525ae83959b ("phylink: add phylink infrastructure")Signed-off-by Heiner Kallweit <[email protected]>
Applied and queued up for -stable.