mm: move more expensive part of XA setup out of mapping check
Subsystems (2)
PATCH 1/1 mm: move more expensive part of XA setup out of mapping check
The fast path here is not needing any writeback, yet we spend time setting up the xarray lookup data upfront. Move the part that actually needs to iterate the address space mapping into a separate helper, saving ~30% of the time here.
---
mm/filemap.c +25 -18
@@ -638,6 +638,30 @@ static bool mapping_needs_writeback(struct address_space *mapping)return mapping->nrpages; } +static bool filemap_range_has_writeback (struct address_space *mapping, +loff_t start_byte,loff_t end_byte) +{ +XA_STATE (xas, &mapping->i_pages, start_byte >>PAGE_SHIFT ); +pgoff_t max = end_byte >>PAGE_SHIFT ; +struct page *page; + +if (end_byte < start_byte) +return false; + +rcu_read_lock (); +xas_for_each (&xas, page, max) { +if (xas_retry (&xas, page)) +continue ; +if (xa_is_value (page)) +continue ; +if (PageDirty (page) ||PageLocked (page) ||PageWriteback (page)) +break ; + } +rcu_read_unlock (); +return page !=NULL ; + +} +/** * filemap_range_needs_writeback - check if range potentially needs writeback * @mapping: address space within which to check
@@ -655,29 +679,12 @@ static bool mapping_needs_writeback(struct address_space *mapping)bool filemap_range_needs_writeback (struct address_space *mapping,loff_t start_byte,loff_t end_byte) { -XA_STATE (xas, &mapping->i_pages, start_byte >>PAGE_SHIFT ); -pgoff_t max = end_byte >>PAGE_SHIFT ; -struct page *page; -if (!mapping_needs_writeback (mapping))return false;if (!mapping_tagged (mapping,PAGECACHE_TAG_DIRTY ) && !mapping_tagged (mapping,PAGECACHE_TAG_WRITEBACK ))return false; -if (end_byte < start_byte) -return false; - -rcu_read_lock (); -xas_for_each (&xas, page, max) { -if (xas_retry (&xas, page)) -continue ; -if (xa_is_value (page)) -continue ; -if (PageDirty (page) ||PageLocked (page) ||PageWriteback (page)) -break ; - } -rcu_read_unlock (); -return page !=NULL ; +return filemap_range_has_writeback (mapping, start_byte, end_byte); }EXPORT_SYMBOL_GPL (filemap_range_needs_writeback);
Signature · 1 line
Jens Axboe
Matthew Wilcox
maintainerQuoted 4 lines · Jens Axboe
The fast path here is not needing any writeback, yet we spend time setting up the xarray lookup data upfront. Move the part that actually needs to iterate the address space mapping into a separate helper, saving ~30% of the time here.
No objection to this patch, but it did remind me that I never saw an answer to
https://lore.kernel.org/all/CAHk-=wg_-EwefQ_3Osz4iJxTrTk3tfrV53Z7-jaGg=tm9i5TXg@mail.gmail.com/
(and nor did lore)
Quoted 9 lines · Matthew Wilcox
Quoted 4 lines · Jens Axboe
The fast path here is not needing any writeback, yet we spend time setting up the xarray lookup data upfront. Move the part that actually needs to iterate the address space mapping into a separate helper, saving ~30% of the time here.
No objection to this patch, but it did remind me that I never saw an answer to
https://lore.kernel.org/all/CAHk-=wg_-EwefQ_3Osz4iJxTrTk3tfrV53Z7-jaGg=tm9i5TXg@mail.gmail.com/
(and nor did lore)
Totally missed that, and yes there could be cases where that lookup is going to be way too slow. I'll take a look.
Signature · 1 line
Jens Axboe