Skip to contentSkip to conversation

net-sched: fix bfifo default limit

PATCH Applied Patrick McHardy 2 participants 2 messages May 6, 2009

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

net-sched: fix bfifo default limit

When no limit is given, the bfifo uses a default of tx_queue_len * mtu. Packets handled by qdiscs include the link layer header, so this should be taken into account, similar to what other qdiscs do.

net/sched/sch_fifo.c +1 -1
index 92cfc9d..69188e8 100644
@@ -51,7 +51,7 @@ static int fifo_init(struct Qdisc *sch, struct nlattr *opt)
 		u32 limit = qdisc_dev(sch)->tx_queue_len ? : 1;
 
 		if (sch->ops == &bfifo_qdisc_ops)
-			limit *= qdisc_dev(sch)->mtu;
+			limit *= psched_mtu(qdisc_dev(sch));
 
 		q->limit = limit;
 	} else {
maintainer Applied
#1 lore raw

From: Patrick McHardy <[email protected]>
Date: Wed, 06 May 2009 15:35:12 +0200

Quoted 7 lines

net-sched: fix bfifo default limit

When no limit is given, the bfifo uses a default of tx_queue_len * mtu. Packets handled by qdiscs include the link layer header, so this should be taken into account, similar to what other qdiscs do.

Applied, thanks a lot!