dlm_tool: Fix silly error:
PATCH 1/1 dlm_tool: Fix silly error:
If you do
# dlm_tool lockdump default
on a lockspace with no locks in it, you get the error message:
can't read /sys/kernel/debug/dlm/default_locks: Success
This patch puts a slightly more sensible error message in place.
Chrissie
-------------- next part --------------
A non-text attachment was scrubbed...
Name: dlmtool.patch
Type: text/x-patch
Size: 556 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/cluster-devel/attachments/20090507/790574fd/attachment.bin>
PATCH 1/1 dlm_tool: Fix silly error:
Quoted 9 lines · Chrissie Caulfield
If you do
# dlm_tool lockdump defaulton a lockspace with no locks in it, you get the error message:
can't read
/sys/kernel/debug/dlm/default_locks: SuccessThis patch puts a slightly more sensible error message in place.
Ack, thanks, could you also do the same for "lockdebug"?
PATCH 1/1 dlm_tool: Fix silly error:
Quoted 5 lines · David Teigland
Quoted 4 lines · Chrissie Caulfield
If you do
# dlm_tool lockdump default
Quoted 7 lines
Quoted 5 lines
on a lockspace with no locks in it, you get the error message:
can't read
/sys/kernel/debug/dlm/default_locks: SuccessThis patch puts a slightly more sensible error message in place.
Ack, thanks, could you also do the same for "lockdebug"?
Or perhaps it would make more sense to simply print noting at all in that case. That would be consistent with all the other parts of dlm_tool as well as the "no news is good news" philosophy of Unix tools in general.
Signature · 1 line
Chrissie