ACPI: battery drivers should call power_supply_changed()

PATCH New Alan Jenkins 1 participant 1 message May 12, 2009 ACPI

Share & tools

Alan Jenkins

author

2009-05-12 14:51 UTC #0 lore raw

PATCH 1/1 ACPI: battery drivers should call power_supply_changed()

Calling kobject_uevent() directly is a layering violation. In particular, it means we'll miss updating the generic LED trigger.

Signed-off-by Alan Jenkins <[email protected]>

drivers/acpi/battery.c +1 -1

index 2ccc87e..9208e97 100644
@@ -812,7 +812,7 @@ static void acpi_battery_notify(acpi_handle handle, u32 event, void *data)
 #ifdef CONFIG_ACPI_SYSFS_POWER
 	/* acpi_batter_update could remove power_supply object */
 	if (battery->bat.dev)
-		kobject_uevent(&battery->bat.dev->kobj, KOBJ_CHANGE);
+		power_supply_changed(&battery->bat);
 #endif
 }

drivers/acpi/sbs.c +2 -2

index 4b214b7..dfa9455 100644
@@ -890,7 +890,7 @@ static void acpi_sbs_callback(void *context)
 					      sbs->charger_present);
 #endif
 #ifdef CONFIG_ACPI_SYSFS_POWER
-		kobject_uevent(&sbs->charger.dev->kobj, KOBJ_CHANGE);
+		power_supply_changed(&sbs->charger);
 #endif
 	}
 	if (sbs->manager_present) {

@@ -909,7 +909,7 @@ static void acpi_sbs_callback(void *context)
 						      bat->present);
 #endif
 #ifdef CONFIG_ACPI_SYSFS_POWER
-			kobject_uevent(&bat->bat.dev->kobj, KOBJ_CHANGE);
+			power_supply_changed(&bat->bat);
 #endif
 		}
 	}