Skip to contentSkip to conversation

atmel_lcdfb: Correct fifo size for some products

PATCH In review Nicolas Ferre 4 participants 5 messages May 15, 2009 – Jun 9, 2009

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 atmel_lcdfb: Correct fifo size for some products

Remove wrong fifo size definition for some AT91 products.

Due to a misunderstanding of some AT91 datasheets, a fifo size of 2048 (words) has been introduced by mistake. In fact, all products (AT91/AT32) are sharing the same fifo size of 512 words.

---
Can we consider this fix for .30-final ?

 drivers/video/atmel_lcdfb.c |   10 ++--------
 1 files changed, 2 insertions(+), 8 deletions(-)
drivers/video/atmel_lcdfb.c +2 -8
index 9a577a8..2fb63f6 100644
@@ -29,14 +29,8 @@
 
 /* configurable parameters */
 #define ATMEL_LCDC_CVAL_DEFAULT		0xc8
-#define ATMEL_LCDC_DMA_BURST_LEN	8
-
-#if defined(CONFIG_ARCH_AT91SAM9263) || defined(CONFIG_ARCH_AT91CAP9) || \
-	defined(CONFIG_ARCH_AT91SAM9RL)
-#define ATMEL_LCDC_FIFO_SIZE		2048
-#else
-#define ATMEL_LCDC_FIFO_SIZE		512
-#endif
+#define ATMEL_LCDC_DMA_BURST_LEN	8	/* words */
+#define ATMEL_LCDC_FIFO_SIZE		512	/* words */
 
 #if defined(CONFIG_ARCH_AT91)
 #define	ATMEL_LCDFB_FBINFO_DEFAULT	(FBINFO_DEFAULT \
Signature · 10 lines
1.5.3.7



------------------------------------------------------------------------------
Crystal Reports - New Free Runtime and 30 Day Trial
Check out the new simplified licensing option that enables 
unlimited royalty-free distribution of the report engine 
for externally facing server and web deployment. 
http://p.sf.net/sfu/businessobjects
#1 lore raw
Quoted 9 lines · Nicolas Ferre

Remove wrong fifo size definition for some AT91 products.

Due to a misunderstanding of some AT91 datasheets, a fifo size of 2048 (words) has been introduced by mistake. In fact, all products (AT91/AT32) are sharing the same fifo size of 512 words.

---
Can we consider this fix for .30-final ?

Fine by me as it doesn't affect AVR32 in any way.

Haavard

------------------------------------------------------------------------------
Crystal Reports - New Free Runtime and 30 Day Trial Check out the new simplified licensing option that enables unlimited royalty-free distribution of the report engine for externally facing server and web deployment.
http://p.sf.net/sfu/businessobjects

#2 lore raw
In reply to Nicolas Ferre
Quoted 6 lines · On Fri, 15 May 2009 12:34:18 +0200 Nicolas Ferre <[email protected]>…

Remove wrong fifo size definition for some AT91 products.

Due to a misunderstanding of some AT91 datasheets, a fifo size of 2048 (words) has been introduced by mistake. In fact, all products (AT91/AT32) are sharing the same fifo size of 512 words.

Changelog fails to describe the impact of the bug, so people who are working out which kernel versions it should be ported into don't know what to do.

Furthermore, people who are hitting a bug in this driver in older kernel versions will have difficulty working out whether this patch might fix their bug.

Quoted 1 line

Can we consider this fix for .30-final ?

Sure, but for what reason?

What about 2.6.29.x, 2.6.28.x, earlier?

Quoted 9 lines
drivers/video/atmel_lcdfb.c +0 -3
@@ -29,14 +29,8 @@
 
 /* configurable parameters */
 #define ATMEL_LCDC_CVAL_DEFAULT		0xc8
-#define ATMEL_LCDC_DMA_BURST_LEN	8
-
-#if defined(CONFIG_ARCH_AT91SAM9263) || defined(CONFIG_ARCH_AT91CAP9) || \

drivers/video/atmel_lcdfb.c line 36

Quoted 10 lines
drivers/video/atmel_lcdfb.c +2 -5
-	defined(CONFIG_ARCH_AT91SAM9RL)
-#define ATMEL_LCDC_FIFO_SIZE		2048
-#else
-#define ATMEL_LCDC_FIFO_SIZE		512
-#endif
+#define ATMEL_LCDC_DMA_BURST_LEN	8	/* words */
+#define ATMEL_LCDC_FIFO_SIZE		512	/* words */
 
 #if defined(CONFIG_ARCH_AT91)
 #define	ATMEL_LCDFB_FBINFO_DEFAULT	(FBINFO_DEFAULT \

------------------------------------------------------------------------------
Register Now for Creativity and Technology (CaT), June 3rd, NYC. CaT is a gathering of tech-side developers & brand creativity professionals. Meet the minds behind Google Creative Lab, Visual Complexity, Processing, & iPhoneDevCamp as they present alongside digital heavyweights like Barbarian Group, R/GA, & Big Spaceship. http://p.sf.net/sfu/creativitycat-com

#3 lore raw

Andrew Morton :

Quoted 9 lines · On Fri, 15 May 2009 12:34:18 +0200 Nicolas Ferre <[email protected]>…
Quoted 7 lines

Remove wrong fifo size definition for some AT91 products.

Due to a misunderstanding of some AT91 datasheets, a fifo size of 2048 (words) has been introduced by mistake. In fact, all products (AT91/AT32) are sharing the same fifo size of 512 words.

Quoted 7 lines

Changelog fails to describe the impact of the bug, so people who are working out which kernel versions it should be ported into don't know what to do.

Furthermore, people who are hitting a bug in this driver in older kernel versions will have difficulty working out whether this patch might fix their bug.

Ok, you are right, I will try to add some information.

In fact, if you mis-configure the fifo watermark making it too high you end without the capacity of issuing burst transfers on the internal AHB bus. This will decrease overall system performance as the LCD will ask for data as soon as the fifo will have one byte available (not efficient single accesses).

Quoted 5 lines
Quoted 1 line

Can we consider this fix for .30-final ?

Sure, but for what reason?

What about 2.6.29.x, 2.6.28.x, earlier?

Indeed, should be valuable to extend this correction to stable kernel series. I added Greg to the loop for this purpose.

Quoted 17 lines
Quoted 17 lines
drivers/video/atmel_lcdfb.c +2 -8
@@ -29,14 +29,8 @@
 
 /* configurable parameters */
 #define ATMEL_LCDC_CVAL_DEFAULT		0xc8
-#define ATMEL_LCDC_DMA_BURST_LEN	8
-
-#if defined(CONFIG_ARCH_AT91SAM9263) || defined(CONFIG_ARCH_AT91CAP9) || \
-	defined(CONFIG_ARCH_AT91SAM9RL)
-#define ATMEL_LCDC_FIFO_SIZE		2048
-#else
-#define ATMEL_LCDC_FIFO_SIZE		512
-#endif
+#define ATMEL_LCDC_DMA_BURST_LEN	8	/* words */
+#define ATMEL_LCDC_FIFO_SIZE		512	/* words */
 
Quoted 2 lines

drivers/video/atmel_lcdfb.c line 36

Quoted 2 lines
drivers/video/atmel_lcdfb.c +0 -0
 #if defined(CONFIG_ARCH_AT91)
 #define	ATMEL_LCDFB_FBINFO_DEFAULT	(FBINFO_DEFAULT \

Thanks to have taken immediately this patch into account ; even before my late explanation ;-)

Best regards,

Signature · 9 lines
Nicolas Ferre


------------------------------------------------------------------------------
Crystal Reports - New Free Runtime and 30 Day Trial
Check out the new simplified licensing option that enables unlimited
royalty-free distribution of the report engine for externally facing 
server and web deployment.
http://p.sf.net/sfu/businessobjects
#4 lore raw
Quoted 26 lines · Nicolas Ferre

Andrew Morton :

Quoted 9 lines · On Fri, 15 May 2009 12:34:18 +0200 Nicolas Ferre <[email protected]>…
Quoted 7 lines

Remove wrong fifo size definition for some AT91 products.

Due to a misunderstanding of some AT91 datasheets, a fifo size of 2048 (words) has been introduced by mistake. In fact, all products (AT91/AT32) are sharing the same fifo size of 512 words.

Quoted 7 lines

Changelog fails to describe the impact of the bug, so people who are working out which kernel versions it should be ported into don't know what to do.

Furthermore, people who are hitting a bug in this driver in older kernel versions will have difficulty working out whether this patch might fix their bug.

Ok, you are right, I will try to add some information.

In fact, if you mis-configure the fifo watermark making it too high you end without the capacity of issuing burst transfers on the internal AHB bus. This will decrease overall system performance as the LCD will ask for data as soon as the fifo will have one byte available (not efficient single accesses).

Quoted 8 lines
Quoted 5 lines
Quoted 1 line

Can we consider this fix for .30-final ?

Sure, but for what reason?

What about 2.6.29.x, 2.6.28.x, earlier?

Indeed, should be valuable to extend this correction to stable kernel series. I added Greg to the loop for this purpose.

For stable stuff, please send any requested patches, with the git commit id of the patch in Linus's tree, to [email protected], otherwise I might miss it :)

Also, you can add:
Cc: stable <[email protected]>
to the signed-off-by area of the patch, and when it is taken into Linus's tree, the stable team will automatically get notified of it and include it in the next stable releases without any other work needed to be done by you.

hope this helps,

greg k-h

------------------------------------------------------------------------------
Crystal Reports - New Free Runtime and 30 Day Trial
Check out the new simplified licensing option that enables unlimited royalty-free distribution of the report engine for externally facing server and web deployment.
http://p.sf.net/sfu/businessobjects