Skip to contentSkip to conversation

b43legacy: Remove unnecessary MMIO in interrupt hotpath

PATCH In review Larry Finger 2 participants 2 messages May 15, 2009 Networking drivers (wireless)

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/2 b43legacy: Remove unnecessary MMIO in interrupt hotpath

From: Stefano Brivio <[email protected]>

This removes unnecessary MMIO accesses in the interrupt hotpath. The patch by Michael Buesch for b43 has been ported to b43legacy.

---

John,

This is 2.6.31 material. I am submitting this for Stefano because this patch touches a section of the code that had to be changed to fix a locking problem.

I hope this patch does not cause any problems. My normal method is not available while I'm away from home.

V2 does not try to eliminate any "unused" DMA rings. If any should be eliminated, that will be in a separate patch.

Larry
---

 b43legacy.h |    4 +--
 main.c      |   78 ++++++++++++++++--------------------------------------------
 pio.c       |    2 -
 3 files changed, 25 insertions(+), 59 deletions(-)
drivers/net/wireless/b43legacy/b43legacy.h +2 -2
Index: wireless-testing/drivers/net/wireless/b43legacy/b43legacy.h
===================================================================
@@ -694,8 +694,8 @@ struct b43legacy_wldev {
 	/* Reason code of the last interrupt. */
 	u32 irq_reason;
 	u32 dma_reason[6];
-	/* saved irq enable/disable state bitfield. */
-	u32 irq_savedstate;
+	/* The currently active generic-interrupt mask. */
+	u32 irq_mask;
 	/* Link Quality calculation context. */
 	struct b43legacy_noise_calculation noisecalc;
 	/* if > 0 MAC is suspended. if == 0 MAC is enabled. */
drivers/net/wireless/b43legacy/main.c +22 -56

199 lines not on this page · raw message

drivers/net/wireless/b43legacy/pio.c +1 -1
Index: wireless-testing/drivers/net/wireless/b43legacy/pio.c
===================================================================
@@ -443,7 +443,7 @@ int b43legacy_pio_init(struct b43legacy_
 	pio->queue3 = queue;
 
 	if (dev->dev->id.revision < 3)
-		dev->irq_savedstate |= B43legacy_IRQ_PIO_WORKAROUND;
+		dev->irq_mask |= B43legacy_IRQ_PIO_WORKAROUND;
 
 	b43legacydbg(dev->wl, "PIO initialized\n");
 	err = 0;
#1 lore raw
Quoted 15 lines · On Friday 15 May 2009 22:39:20 Larry Finger wrote:

From: Stefano Brivio <[email protected]>

This removes unnecessary MMIO accesses in the interrupt hotpath. The patch by Michael Buesch for b43 has been ported to b43legacy.

---

John,

This is 2.6.31 material. I am submitting this for Stefano because this patch touches a section of the code that had to be changed to fix a locking problem.

Quoted 5 lines

I hope this patch does not cause any problems. My normal method is not available while I'm away from home.

V2 does not try to eliminate any "unused" DMA rings. If any should be eliminated, that will be in a separate patch.

ACK

Signature · 1 line
Greetings, Michael.