Skip to contentSkip to conversation

OMAP3: Introduce CONFIG option for power code

PATCH Superseded Dirk Behme 2 participants 3 messages May 16, 2009 – May 19, 2009

lore
Share & tools
lore

Dirk Behme

author
#0 lore raw

PATCH v2 1/1 OMAP3: Introduce CONFIG option for power code

Some OMAP3 boards need control for external power companion chips. Introduce a CONFIG option for this, to avoid Makefile changes for each board.

---

Compile tested with ./MAKEALL ARM_CORTEX_A8, boot tested on OMAP3 based BeagleBoard.

Note: This patch trys to fix the first comment of

http://lists.denx.de/pipermail/u-boot/2009-April/051383.html

Changes in v2:
- Mention about which power companion chips we talk here

This version v2 replaces all previous patches

 board/omap3/common/Makefile     |    5 +----
 doc/README.omap3                |   11 +++++++++++
 include/configs/omap3_beagle.h  |    1 +
 include/configs/omap3_overo.h   |    1 +
 include/configs/omap3_pandora.h |    1 +
 include/configs/omap3_zoom1.h   |    1 +
 6 files changed, 16 insertions(+), 4 deletions(-)
doc/README.omap3 +11 -0
Index: u-boot-main/doc/README.omap3
===================================================================
@@ -77,6 +77,17 @@ For all other commands see
 
 help
 
+Custom configs
+==============
+
+CONFIG_OMAP3_POWER
+
+Some OMAP3 boards use external power companion chips to be configured. Enable
+this CONFIG option in your board specific configuration file if your board
+uses such a companion chip. E.g. TWL4030 or compatible TPS65950.
+
+This enables compilation of board/omap3/common/power.c.
+
 Acknowledgements
 ================
 
board/omap3/common/Makefile +1 -4
Index: u-boot-main/board/omap3/common/Makefile
===================================================================
@@ -29,10 +29,7 @@ endif
 
 LIB	= $(obj)lib$(VENDOR).a
 
-COBJS-$(CONFIG_OMAP3_BEAGLE) += power.o
-COBJS-$(CONFIG_OMAP3_OVERO) += power.o
-COBJS-$(CONFIG_OMAP3_PANDORA) += power.o
-COBJS-$(CONFIG_OMAP3_ZOOM1) += power.o
+COBJS-$(CONFIG_OMAP3_POWER) += power.o
 
 COBJS	:= $(COBJS-y)
 SRCS	:= $(COBJS:.o=.c)
include/configs/omap3_beagle.h +1 -0
Index: u-boot-main/include/configs/omap3_beagle.h
===================================================================
@@ -37,6 +37,7 @@
 #define CONFIG_OMAP34XX		1	/* which is a 34XX */
 #define CONFIG_OMAP3430		1	/* which is in a 3430 */
 #define CONFIG_OMAP3_BEAGLE	1	/* working with BEAGLE */
+#define CONFIG_OMAP3_POWER	1	/* use power code, see README.omap3 */
 
 #include <asm/arch/cpu.h>		/* get chip and board defs */
 #include <asm/arch/omap3.h>
include/configs/omap3_overo.h +1 -0
Index: u-boot-main/include/configs/omap3_overo.h
===================================================================
@@ -29,6 +29,7 @@
 #define CONFIG_OMAP34XX		1	/* which is a 34XX */
 #define CONFIG_OMAP3430		1	/* which is in a 3430 */
 #define CONFIG_OMAP3_OVERO		1	/* working with overo */
+#define CONFIG_OMAP3_POWER	1	/* use power code, see README.omap3 */
 
 #include <asm/arch/cpu.h>	/* get chip and board defs */
 #include <asm/arch/omap3.h>
include/configs/omap3_pandora.h +1 -0
Index: u-boot-main/include/configs/omap3_pandora.h
===================================================================
@@ -32,6 +32,7 @@
 #define CONFIG_OMAP34XX		1	/* which is a 34XX */
 #define CONFIG_OMAP3430		1	/* which is in a 3430 */
 #define CONFIG_OMAP3_PANDORA	1	/* working with pandora */
+#define CONFIG_OMAP3_POWER	1	/* use power code, see README.omap3 */
 
 #include <asm/arch/cpu.h>	/* get chip and board defs */
 #include <asm/arch/omap3.h>
include/configs/omap3_zoom1.h +1 -0
Index: u-boot-main/include/configs/omap3_zoom1.h
===================================================================
@@ -38,6 +38,7 @@
 #define CONFIG_OMAP34XX		1	/* which is a 34XX */
 #define CONFIG_OMAP3430		1	/* which is in a 3430 */
 #define CONFIG_OMAP3_ZOOM1	1	/* working with Zoom MDK Rev1 */
+#define CONFIG_OMAP3_POWER	1	/* use power code, see README.omap3 */
 
 #include <asm/arch/cpu.h>		/* get chip and board defs */
 #include <asm/arch/omap3.h>
#1 lore raw

PATCH v2 1/1 OMAP3: Introduce CONFIG option for power code

Quoted 6 lines · Dirk Behme

Some OMAP3 boards need control for external power companion chips. Introduce a CONFIG option for this, to avoid Makefile changes for each board.

---

IIRC the Revc Change it's companion chip is this code still compatible?

Best Regards,
J.

author
#2 lore raw

PATCH v2 1/1 OMAP3: Introduce CONFIG option for power code

Dear Jean-Christophe,

Quoted 8 lines · Jean-Christophe PLAGNIOL-VILLARD
Quoted 6 lines · Dirk Behme

Some OMAP3 boards need control for external power companion chips. Introduce a CONFIG option for this, to avoid Makefile changes for each board.

---

IIRC the Revc Change it's companion chip is this code still compatible?

Yes, the code is still compatible. And yes, the companion chip changed. And yes, this is quite confusing ;) Do you still remember what I wrote in one of the other mails "only TI marketing department might understand their chip naming"?

What I understood is that revision A & B BeagleBoards used "OEM" companion chip you will only get in large quantities and manual is NDA. Revision C now uses the "catalogue" device, you will e.g. able to get from DigiKey and manual is publically available. So different chip names, but compatible.

Recent U-Boot mainline is used on rev B and C boards without any difference :)

Best regards

Dirk