SMC911x driver fixed for NFS boot
PATCH 1/1 SMC911x driver fixed for NFS boot
Quoted 8 lines · Manikandan Pillai
eth_halt()function in the smc911x drivers used to call thesmc911x_reset()function.eth_halt()used to be called after tftp transfers. This used to put the ethernet chip in reset while the linux boots up resulting in the ethernet driver not coming up. NFS boot used to fail as a result.This patch calls
smc911x_shutdown()instead ofsmc911x_reset(). Some comments received has also been fixed.
This patch fixes NFS boot in the case where the kernel is first loaded with tftpboot, as described.
If the kernel is loaded using some other mechanism, like flash, the smc device is never initialized. At least in the case where there is no valid EEPROM connected to the smc device, NFS boot will fail. I'm not sure whether or not a loaded MAC address has anything to do with it, or if the kernel is expecting the smc device to be in a different state.
Relying on tftpboot leaving the ethernet device in the right state doesn't seem right. Is there an existing clean way to deal with this, short of adding an initramfs to fix it up? I'll work on a patch if someone can suggest an approach that makes sense.
Regards,
- Josh
PATCH 1/1 SMC911x driver fixed for NFS boot
Dear Josh Karabin,
Quoted 11 lines · In message <[email protected]> you wrote:
If the kernel is loaded using some other mechanism, like flash, the smc device is never initialized. At least in the case where there is no valid EEPROM connected to the smc device, NFS boot will fail. I'm not sure whether or not a loaded MAC address has anything to do with it, or if the kernel is expecting the smc device to be in a different state.
Relying on tftpboot leaving the ethernet device in the right state doesn't seem right. Is there an existing clean way to deal with this, short of adding an initramfs to fix it up? I'll work on a patch if someone can suggest an approach that makes sense.
Please check the FAQ, especially here:
http://www.denx.de/wiki/view/DULG/EthernetDoesNotWorkInLinux
Best regards,
Wolfgang Denk
Signature · 6 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de Another war ... must it always be so? How many comrades have we lost in this way? ... Obedience. Duty. Death, and more death ... -- Romulan Commander, "Balance of Terror", stardate 1709.2