Skip to contentSkip to conversation

qemu-kvm: Drop obsolete CONFIG_GDBSTUB

PATCH Applied Jan Kiszka 3 participants 4 messages May 21, 2009 KVM

lore
Share & tools
lore

Jan Kiszka

author
#0 lore raw

PATCH 1/1 qemu-kvm: Drop obsolete CONFIG_GDBSTUB

This fixes the recently reported gdbstub regression of qemu-kvm.

Signed-off-by Jan Kiszka <[email protected]>

---

 qemu-kvm.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)
qemu-kvm.c +0 -2
index 98c7cd7..bc3d7db 100644
@@ -606,13 +606,11 @@ int kvm_main_loop(void)
             qemu_system_powerdown();
         else if (qemu_reset_requested())
 	    qemu_kvm_system_reset();
-#ifdef CONFIG_GDBSTUB
 	else if (kvm_debug_cpu_requested) {
 	    gdb_set_stop_cpu(kvm_debug_cpu_requested);
 	    vm_stop(EXCP_DEBUG);
 	    kvm_debug_cpu_requested = NULL;
 	}
-#endif
     }
 
     pause_all_threads();
Applied
#1 lore raw
Quoted 3 lines · Jan Kiszka

This fixes the recently reported gdbstub regression of qemu-kvm.

Applied, thanks.

Signature · 1 line
error compiling committee.c: too many arguments to function
Applied
#2 lore raw
In reply to Jan Kiszka
Quoted 17 lines · Jan Kiszka

This fixes the recently reported gdbstub regression of qemu-kvm.

Signed-off-by Jan Kiszka <[email protected]>

---

 qemu-kvm.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)
qemu-kvm.c +0 -0
index 98c7cd7..bc3d7db 100644
@@ -606,13 +606,11 @@ int kvm_main_loop(void)
             qemu_system_powerdown();
         else if (qemu_reset_requested())
 	    qemu_kvm_system_reset();

qemu-kvm.c int kvm_main_loop(void) · line 616

Quoted 10 lines
qemu-kvm.c +0 -2
-#ifdef CONFIG_GDBSTUB
 	else if (kvm_debug_cpu_requested) {
 	    gdb_set_stop_cpu(kvm_debug_cpu_requested);
 	    vm_stop(EXCP_DEBUG);
 	    kvm_debug_cpu_requested = NULL;
 	}
-#endif
     }
 
     pause_all_threads();

Applied this patch to qemu-kvm tree and I get the error
" Remote 'g' packet reply is too long". Is there any other pathches i should try ?

-aneesh

#3 lore raw
Quoted 26 lines · Aneesh Kumar K.V
Quoted 25 lines · Jan Kiszka

This fixes the recently reported gdbstub regression of qemu-kvm.

Signed-off-by Jan Kiszka <[email protected]>

---

 qemu-kvm.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)
qemu-kvm.c +0 -2
index 98c7cd7..bc3d7db 100644
@@ -606,13 +606,11 @@ int kvm_main_loop(void)
             qemu_system_powerdown();
         else if (qemu_reset_requested())
 	    qemu_kvm_system_reset();
-#ifdef CONFIG_GDBSTUB
 	else if (kvm_debug_cpu_requested) {
 	    gdb_set_stop_cpu(kvm_debug_cpu_requested);
 	    vm_stop(EXCP_DEBUG);
 	    kvm_debug_cpu_requested = NULL;
 	}
-#endif
     }
Quoted 8 lines

qemu-kvm.c int kvm_main_loop(void) · line 616

Quoted 2 lines
qemu-kvm.c +0 -0
     pause_all_threads();

Applied this patch to qemu-kvm tree and I get the error
" Remote 'g' packet reply is too long". Is there any other pathches i should try ?

Works fine with the below patches

http://git.kiszka.org/?p=kvm-userspace.git;a=commit;h=159c7d73428c7df3167babf8253d618aea253338
http://git.kiszka.org/?p=kvm-userspace.git;a=commit;h=c84899b311ac882c4f73299ad90b88ed3302b813
http://git.kiszka.org/?p=kvm-userspace.git;a=commit;h=125f74afaf973ff4faf6b4a8a4c8262df373fe49
http://git.kiszka.org/?p=kvm-userspace.git;a=commit;h=9d5bc0241268ceea7975ae9e4562fe21484afb68

-aneesh