Skip to contentSkip to conversation

Add static to local machine declaration.

PATCH In review Stefan Weil 3 participants 3 messages May 23, 2009 – May 27, 2009

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Add static to local machine declaration.

Variable akitapda_machine is only used locally, so the static attribute avoids a compiler warning.

---
 hw/spitz.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
hw/spitz.c +0 -0
index aa1487b..ef0bace 100644
@@ -1041,7 +1041,7 @@ static void terrier_init(ram_addr_t ram_size,
                 kernel_cmdline, initrd_filename, cpu_model, terrier,

0x33f);
}

-QEMUMachine akitapda_machine = {

+static QEMUMachine akitapda_machine = {
     .name = "akita",
     .desc = "Akita PDA (PXA270)",
     .init = akita_init,

--
1.5.6.5

#1 lore raw
Quoted 5 lines · Stefan Weil

Variable akitapda_machine is only used locally, so the static attribute avoids a compiler warning.

This patch is whitespace broken as is two other patches I have in my queue for you. Could you try using something like git-send-email?

Regards,

Anthony Liguori

#2 lore raw
Quoted 7 lines · Anthony Liguori
Quoted 5 lines · Stefan Weil

Variable akitapda_machine is only used locally, so the static attribute avoids a compiler warning.

Quoted 7 lines

This patch is whitespace broken as is two other patches I have in my queue for you. Could you try using something like git-send-email?

Regards,

Anthony Liguori

Sorry, I am still a git-learner...

The appended patch will work.

Regards,

Stefan Weil

Quoted 1 line

From 3c4e4df0b882fd553aa89616e5d3d08a7eca301c Mon Sep 17 00:00:00 2001

From: Stefan Weil <[email protected]>
Date: Sat, 23 May 2009 23:49:14 +0200
Subject: [PATCH] Add static to local machine declaration.

Variable akitapda_machine is only used locally, so the static attribute avoids a compiler warning.

---
 hw/spitz.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
hw/spitz.c +1 -1
index aa1487b..ef0bace 100644
@@ -1041,7 +1041,7 @@ static void terrier_init(ram_addr_t ram_size,
                 kernel_cmdline, initrd_filename, cpu_model, terrier, 0x33f);
 }
 
-QEMUMachine akitapda_machine = {
+static QEMUMachine akitapda_machine = {
     .name = "akita",
     .desc = "Akita PDA (PXA270)",
     .init = akita_init,
Signature · 1 line
1.5.6.5