Skip to contentSkip to conversation

Display processor virtualization resource allocations in lparcfg

PATCH In review Nathan Fontenot 2 participants 5 messages May 26, 2009 – May 28, 2009 PowerPC

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Display processor virtualization resource allocations in lparcfg

This patch updates the output from /proc/ppc64/lparcfg to display the processor virtualization resource allocations for a shared processor partition.

This information is already gathered via the h_get_ppp call, we just have to make sure that the ibm,partition-performance-parameters-level property is >= 1 to ensure that the information is valid.

---

arch/powerpc/kernel/lparcfg.c +0 -0
Index: linux-2.6/arch/powerpc/kernel/lparcfg.c
===================================================================
@@ -169,6 +169,9 @@
	u8	unallocated_weight;
	u16	active_procs_in_pool;
	u16	active_system_procs;

+ u16 phys_platform_procs;
+ u32 max_proc_cap_avail;
+ u32 entitled_proc_cap_avail;
};

/*
@@ -190,13 +193,18 @@
* XX - Unallocated Variable Processor Capacity Weight.
* XXXX - Active processors in Physical Processor Pool.
* XXXX - Processors active on platform.
+ * R8 (QQQQRRRRRRSSSSSS). if ibm,partition-performance-parameters-level >= 1
+ * XXXX - Physical platform procs allocated to virtualization.
+ * XXXXXX - Max procs capacity % available to the partitions pool.
+ * XXXXXX - Entitled procs capacity % available to the
+ * partitions pool.
*/
static unsigned int h_get_ppp(struct hvcall_ppp_data *ppp_data)

{
	unsigned long rc;

- unsigned long retbuf[PLPAR_HCALL_BUFSIZE];
+ unsigned long retbuf[PLPAR_HCALL9_BUFSIZE];

- rc = plpar_hcall(H_GET_PPP, retbuf);
+ rc = plpar_hcall9(H_GET_PPP, retbuf);

	ppp_data->entitlement = retbuf[0];
	ppp_data->unallocated_entitlement = retbuf[1];
@@ -210,6 +218,10 @@
	ppp_data->active_procs_in_pool = (retbuf[3] >> 2 * 8) & 0xffff;
	ppp_data->active_system_procs = retbuf[3] & 0xffff;

+ ppp_data->phys_platform_procs = retbuf[4] >> 6 * 8;
+ ppp_data->max_proc_cap_avail = (retbuf[4] >> 3 * 8) & 0xffffff;
+ ppp_data->entitled_proc_cap_avail = retbuf[4] & 0xffffff;
+

	return rc;
}

@@ -234,6 +246,8 @@
static void parse_ppp_data(struct seq_file *m)

{
	struct hvcall_ppp_data ppp_data;
+	struct device_node *root;
+	const int *perf_level;
	int rc;

	rc = h_get_ppp(&ppp_data);
@@ -267,6 +281,28 @@
	seq_printf(m, "capped=%d\n", ppp_data.capped);
	seq_printf(m, "unallocated_capacity=%lld\n",
		   ppp_data.unallocated_entitlement);

+
+ /* The last bits of information returned from h_get_ppp are only
+ * valid if the ibm,partition-performance-parameters-level
+ * property is >= 1.
+ */
+ root = of_find_node_by_path("/");
+ if (root) {
+ perf_level = of_get_property(root,
+ "ibm,partition-performance-parameters-level",
+ NULL);
+ if (*perf_level >= 1) {
+ seq_printf(m,
+ "physical_procs_allocated_to_virtualization=%d\n",
+ ppp_data.phys_platform_procs);
+ seq_printf(m, "max_proc_capacity_available=%d\n",
+ ppp_data.max_proc_cap_avail);
+ seq_printf(m, "entitled_proc_capacity_available=%d\n",
+ ppp_data.entitled_proc_cap_avail);
+ }
+
+ of_node_put(root);
+ }
}

/**

#1 lore raw
Quoted 8 lines · Nathan Fontenot

This patch updates the output from /proc/ppc64/lparcfg to display the processor virtualization resource allocations for a shared processor partition.

(quoted diff) +0 -0
@@ -267,6 +281,28 @@
 	seq_printf(m, "capped=%d\n", ppp_data.capped);
 	seq_printf(m, "unallocated_capacity=%lld\n",
 		   ppp_data.unallocated_entitlement);

Review line 293

Quoted 10 lines
(quoted diff) +10 -0
+
+	/* The last bits of information returned from h_get_ppp are only
+	 * valid if the ibm,partition-performance-parameters-level
+	 * property is >= 1.
+	 */
+	root = of_find_node_by_path("/");
+	if (root) {
+		perf_level = of_get_property(root,
+				"ibm,partition-performance-parameters-level",
+					     NULL);

What if there is no such property?

Review line 305

Quoted 12 lines
(quoted diff) +12 -0
+		if (*perf_level >= 1) {
+			seq_printf(m,
+			    "physical_procs_allocated_to_virtualization=%d\n",
+				   ppp_data.phys_platform_procs);
+			seq_printf(m, "max_proc_capacity_available=%d\n",
+				   ppp_data.max_proc_cap_avail);
+			seq_printf(m, "entitled_proc_capacity_available=%d\n",
+				   ppp_data.entitled_proc_cap_avail);
+		}
+
+		of_node_put(root);
+	}

cheers

#2 lore raw
Quoted 7 lines · Michael Ellerman

Review

Quoted 5 lines
(quoted diff) +5 -0
+	root = of_find_node_by_path("/");
+	if (root) {
+		perf_level = of_get_property(root,
+				"ibm,partition-performance-parameters-level",
+					     NULL);

What if there is no such property?

Yes, that would cause this code to do some bad things. Updated patch on its way.

Quoted 15 lines

Review

Quoted 13 lines
(quoted diff) +12 -0
+		if (*perf_level >= 1) {
+			seq_printf(m,
+			    "physical_procs_allocated_to_virtualization=%d\n",
+				   ppp_data.phys_platform_procs);
+			seq_printf(m, "max_proc_capacity_available=%d\n",
+				   ppp_data.max_proc_cap_avail);
+			seq_printf(m, "entitled_proc_capacity_available=%d\n",
+				   ppp_data.entitled_proc_cap_avail);
+		}
+
+		of_node_put(root);
+	}

cheers

-Nathan

#3 lore raw

PATCH 1/1 v2: Display processor virtualization resource allocations in lparcfg

In reply to Nathan Fontenot

This patch updates the output from /proc/ppc64/lparcfg to display the processor virtualization resource allocations for a shared processor partition.

This information is already gathered via the h_get_ppp call, we just have to make sure that the ibm,partition-performance-parameters-level property is >= 1 to ensure that the information is valid.

---

arch/powerpc/kernel/lparcfg.c +0 -0
Index: linux-2.6/arch/powerpc/kernel/lparcfg.c
===================================================================
@@ -169,6 +169,9 @@
	u8	unallocated_weight;
	u16	active_procs_in_pool;
	u16	active_system_procs;

+ u16 phys_platform_procs;
+ u32 max_proc_cap_avail;
+ u32 entitled_proc_cap_avail;
};

/*
@@ -190,13 +193,18 @@
* XX - Unallocated Variable Processor Capacity Weight.
* XXXX - Active processors in Physical Processor Pool.
* XXXX - Processors active on platform.
+ * R8 (QQQQRRRRRRSSSSSS). if ibm,partition-performance-parameters-level >= 1
+ * XXXX - Physical platform procs allocated to virtualization.
+ * XXXXXX - Max procs capacity % available to the partitions pool.
+ * XXXXXX - Entitled procs capacity % available to the
+ * partitions pool.
*/
static unsigned int h_get_ppp(struct hvcall_ppp_data *ppp_data)

{
	unsigned long rc;

- unsigned long retbuf[PLPAR_HCALL_BUFSIZE];
+ unsigned long retbuf[PLPAR_HCALL9_BUFSIZE];

- rc = plpar_hcall(H_GET_PPP, retbuf);
+ rc = plpar_hcall9(H_GET_PPP, retbuf);

	ppp_data->entitlement = retbuf[0];
	ppp_data->unallocated_entitlement = retbuf[1];
@@ -210,6 +218,10 @@
	ppp_data->active_procs_in_pool = (retbuf[3] >> 2 * 8) & 0xffff;
	ppp_data->active_system_procs = retbuf[3] & 0xffff;

+ ppp_data->phys_platform_procs = retbuf[4] >> 6 * 8;
+ ppp_data->max_proc_cap_avail = (retbuf[4] >> 3 * 8) & 0xffffff;
+ ppp_data->entitled_proc_cap_avail = retbuf[4] & 0xffffff;
+

	return rc;
}

@@ -234,6 +246,8 @@
static void parse_ppp_data(struct seq_file *m)

{
	struct hvcall_ppp_data ppp_data;
+	struct device_node *root;
+	const int *perf_level;
	int rc;

	rc = h_get_ppp(&ppp_data);
@@ -267,6 +281,28 @@
	seq_printf(m, "capped=%d\n", ppp_data.capped);
	seq_printf(m, "unallocated_capacity=%lld\n",
		   ppp_data.unallocated_entitlement);

+
+ /* The last bits of information returned from h_get_ppp are only
+ * valid if the ibm,partition-performance-parameters-level
+ * property is >= 1.
+ */
+ root = of_find_node_by_path("/");
+ if (root) {
+ perf_level = of_get_property(root,
+ "ibm,partition-performance-parameters-level",
+ NULL);
+ if (perf_level && (*perf_level >= 1)) {
+ seq_printf(m,
+ "physical_procs_allocated_to_virtualization=%d\n",
+ ppp_data.phys_platform_procs);
+ seq_printf(m, "max_proc_capacity_available=%d\n",
+ ppp_data.max_proc_cap_avail);
+ seq_printf(m, "entitled_proc_capacity_available=%d\n",
+ ppp_data.entitled_proc_cap_avail);
+ }
+
+ of_node_put(root);
+ }
}

/**

#4 lore raw

Re: [PATCH] v2: Display processor virtualization resource allocations in lparcfg

Quoted 13 lines · Nathan Fontenot

This patch updates the output from /proc/ppc64/lparcfg to display the processor virtualization resource allocations for a shared processor partition.

This information is already gathered via the h_get_ppp call, we just have to make sure that the ibm,partition-performance-parameters-level property is >= 1 to ensure that the information is valid.

(quoted diff) +1 -0
@@ -267,6 +281,28 @@
 	seq_printf(m, "capped=%d\n", ppp_data.capped);
 	seq_printf(m, "unallocated_capacity=%lld\n",
 		   ppp_data.unallocated_entitlement);
+

Review line 294

Quoted 10 lines
(quoted diff) +10 -0
+	/* The last bits of information returned from h_get_ppp are only
+	 * valid if the ibm,partition-performance-parameters-level
+	 * property is >= 1.
+	 */
+	root = of_find_node_by_path("/");
+	if (root) {
+		perf_level = of_get_property(root,
+				"ibm,partition-performance-parameters-level",
+					     NULL);
+		if (perf_level && (*perf_level >= 1)) {

Yep that looks better, thanks.

cheers