ide: remove superfluous SELECT_MASK() call from do_rw_taskfile()

PATCH In review Bartlomiej Zolnierkiewicz 2 participants 2 messages Jun 1, 2009 – Jun 2, 2009 libata

Share & tools

Bartlomiej Zolnierkiewicz

author

2009-06-01 21:55 UTC #0 lore raw

PATCH 2/3 ide: remove superfluous SELECT_MASK() call from do_rw_taskfile()

With ->write_devctl method call (which unmasks drive IRQ) preceding SELECT_MASK() call there is really no need for the latter.

Moreover with the combination of HPT36x controller and the drive on the quirk_drives[] list this can result in superfluous enable_irq() call which in turn will trigger WARN() in __enable_irq().

Cc Sergei Shtylyov <[email protected]>

Signed-off-by Bartlomiej Zolnierkiewicz <[email protected]>

---
 drivers/ide/ide-taskfile.c |    1 -
 1 file changed, 1 deletion(-)

drivers/ide/ide-taskfile.c +0 -1

Index: b/drivers/ide/ide-taskfile.c
===================================================================
@@ -98,7 +98,6 @@ ide_startstop_t do_rw_taskfile(ide_drive
 	if ((cmd->tf_flags & IDE_TFLAG_DMA_PIO_FALLBACK) == 0) {
 		ide_tf_dump(drive->name, cmd);
 		tp_ops->write_devctl(hwif, ATA_DEVCTL_OBS);
-		SELECT_MASK(drive, 0);
 
 		if (cmd->ftf_flags & IDE_FTFLAG_OUT_DATA) {
 			u8 data[2] = { cmd->tf.data, cmd->hob.data };

Sergei Shtylyov

Acked-by on v1 2/3

2009-06-02 16:23 UTC #1 lore raw

Quoted 8 lines · Bartlomiej Zolnierkiewicz

With ->write_devctl method call (which unmasks drive IRQ) preceding SELECT_MASK() call there is really no need for the latter.
Moreover with the combination of HPT36x controller and the drive on the quirk_drives[] list this can result in superfluous enable_irq() call which in turn will trigger WARN() in __enable_irq().
Signed-off-by Bartlomiej Zolnierkiewicz <[email protected]>

Acked-by Sergei Shtylyov <[email protected]>

MBR, Sergei