ar9170usb: unsigned is always greater than 0

PATCH New Roel Kluin 1 participant 1 message Jun 2, 2009 Networking drivers (wireless)

lore

Share & tools

lore

Roel Kluin

author

2009-06-02 20:33 UTC #0 lore raw

PATCH 1/1 ar9170usb: unsigned is always greater than 0

outlen is unsigned so always greater than 0.

Signed-off-by Roel Kluin <[email protected]>

---
Maybe you want to test `outlen < MAX', but what should MAX be?

drivers/net/wireless/ar9170/usb.c +1 -1

index fddda47..dfd39e9 100644
@@ -350,7 +350,7 @@ static int ar9170_usb_exec_cmd(struct ar9170 *ar, enum ar9170_cmd cmd,
 		goto err_unbuf;
 	}
 
-	if (outlen >= 0 && aru->readlen != outlen) {
+	if (aru->readlen != outlen) {
 		err = -EMSGSIZE;
 		goto err_unbuf;
 	}