Skip to contentSkip to conversation

tracing/mm: val should be signed

PATCH New Roel Kluin 1 participant 1 message Jun 2, 2009 Tracing

lore
Share & tools
lore

Roel Kluin

author
#0 lore raw

PATCH 1/1 tracing/mm: val should be signed

If not signed the `val < 0' test below doesn't make sense. Also strict_strtol requires a long pointer.

---
I think this is what was intended? please review.

kernel/trace/trace_mm.c +2 -1
index 4bc7fc0..9af2351 100644
@@ -54,7 +54,8 @@ static ssize_t
 trace_mm_dump_range_write(struct file *filp, const char __user *ubuf, size_t cnt,
 		       loff_t *ppos)
 {
-	unsigned long val, start, end;
+	unsigned long start, end;
+	long val;
 	char buf[64];
 	int ret;