SPI: xilinx_spi: Added platform driver and support for DS570
Subsystems (2)
PATCH 2/9 SPI: xilinx_spi: Added platform driver and support for DS570
This patch splits xilinx_spi into three parts, an OF and a platform driver and generic part.
The generic part now also works on X86 and also supports the Xilinx SPI IP DS570
---
drivers/spi/xilinx_spi.c +204 -188
@@ -14,22 +14,79 @@#include <linux/module.h> #include <linux/init.h> #include <linux/interrupt.h> -#include <linux/platform_device.h> -#include <linux/of_platform.h> -#include <linux/of_device.h> -#include <linux/of_spi.h> -#include <linux/spi/spi.h> #include <linux/spi/spi_bitbang.h> #include <linux/io.h> -#define XILINX_SPI_NAME "xilinx_spi" +#include "xilinx_spi.h" +struct xilinx_spi { +/* bitbang has to be first */ +struct spi_bitbang bitbang; +struct completion done; +struct resource mem;/* phys mem */ +void __iomem *regs;/* virt. address of the control registers */ +u32 irq; +u8 *rx_ptr;/* pointer in the Tx buffer */ +const u8 *tx_ptr;/* pointer in the Rx buffer */ +int remaining_bytes;/* the number of bytes left to transfer */ +/* offset to the XSPI regs, these might vary... */ +u8 cr_offset; +u8 sr_offset; +u8 txd_offset; +u8 rxd_offset; +u8 ssr_offset; +u8 bits_per_word; +u8 model; +}; + +#ifndef CONFIG_PPC +#define in_8 (addr) ioread8(addr) +#define in_be16 (addr) ioread16(addr) +#define in_be32 (addr) ioread32(addr) + +#define out_8 (addr, b) iowrite8(b, addr) +#define out_be16 (addr, w) iowrite16(w, addr) +#define out_be32 (addr, l) iowrite32(l, addr) +#endif + +#define XSPI_WRITE8 (xspi, offs, val) \ + do { \ + if (xspi->model == XILINX_SPI_MODEL_DS464) \ + out_8(xspi->regs + offs, (val) & 0xff); \ + else \ + XSPI_WRITE32(xspi, offs, val); \ + } while (0) + +#define XSPI_WRITE16 (xspi, offs, val) \ + do { \ + if (xspi->model == XILINX_SPI_MODEL_DS464) \ + out_be16(xspi->regs + offs, (val) & 0xffff); \ + else \ + XSPI_WRITE32(xspi, offs, val); \ + } while (0) + +#define XSPI_WRITE32 (xspi, offs, val) \ + out_be32(xspi->regs + offs, val) + +#define XSPI_READ8 (xspi, offs) \ + (xspi->model == XILINX_SPI_MODEL_DS464) ? \ + in_8(xspi->regs + offs) : XSPI_READ32(xspi, offs) + +#define XSPI_READ16 (xspi, offs) \ + (xspi->model == XILINX_SPI_MODEL_DS464) ? \ + in_be16(xspi->regs + offs) : XSPI_READ32(xspi, offs) + +#define XSPI_READ32 (xspi, offs) \ + in_be32(xspi->regs + offs) + +/* Register definitions as per "OPB Serial Peripheral Interface (SPI) (v1.00e) * Product Specification", DS464 */ -#define XSPI_CR_OFFSET 0x62/* 16-bit Control Register */ +#define XSPI_CR_OFFSET_DS464 0x62/* 16-bit Control Register */ +#define XSPI_CR_OFFSET_DS570 0x60#define XSPI_CR_ENABLE 0x02#define XSPI_CR_MASTER_MODE 0x04
@@ -40,8 +97,10 @@#define XSPI_CR_RXFIFO_RESET 0x40#define XSPI_CR_MANUAL_SSELECT 0x80#define XSPI_CR_TRANS_INHIBIT 0x100 +#define XSPI_CR_LSB_FIRST 0x200 -#define XSPI_SR_OFFSET 0x67/* 8-bit Status Register */ +#define XSPI_SR_OFFSET_DS464 0x67/* 8-bit Status Register */ +#define XSPI_SR_OFFSET_DS570 0x64#define XSPI_SR_RX_EMPTY_MASK 0x01/* Receive FIFO is empty */ #define XSPI_SR_RX_FULL_MASK 0x02/* Receive FIFO is full */
@@ -49,10 +108,13 @@#define XSPI_SR_TX_FULL_MASK 0x08/* Transmit FIFO is full */ #define XSPI_SR_MODE_FAULT_MASK 0x10/* Mode fault error */ -#define XSPI_TXD_OFFSET 0x6b/* 8-bit Data Transmit Register */ -#define XSPI_RXD_OFFSET 0x6f/* 8-bit Data Receive Register */ +#define XSPI_TXD_OFFSET_DS464 0x6b/* 8-bit Data Transmit Register */ +#define XSPI_TXD_OFFSET_DS570 0x68 +#define XSPI_RXD_OFFSET_DS464 0x6f/* 8-bit Data Receive Register */ +#define XSPI_RXD_OFFSET_DS570 0x6C -#define XSPI_SSR_OFFSET 0x70/* 32-bit Slave Select Register */ +#define XSPI_SSR_OFFSET_DS464 0x70/* 32-bit Slave Select Register */ +#define XSPI_SSR_OFFSET_DS570 0x70/* Register definitions as per "OPB IPIF (v3.01c) Product Specification", DS414 * IPIF registers are 32 bit
@@ -70,43 +132,27 @@#define XSPI_INTR_TX_UNDERRUN 0x08/* TxFIFO was underrun */ #define XSPI_INTR_RX_FULL 0x10/* RxFIFO is full */ #define XSPI_INTR_RX_OVERRUN 0x20/* RxFIFO was overrun */ +#define XSPI_INTR_TX_HALF_EMPTY 0x40/* TxFIFO is half empty */ #define XIPIF_V123B_RESETR_OFFSET 0x40/* IPIF reset register */ #define XIPIF_V123B_RESET_MASK 0x0a/* the value to write */ -struct xilinx_spi { -/* bitbang has to be first */ -struct spi_bitbang bitbang; -struct completion done; - -void __iomem *regs;/* virt. address of the control registers */ - -u32 irq; - -u32 speed_hz;/* SCK has a fixed frequency of speed_hz Hz */ - -u8 *rx_ptr;/* pointer in the Tx buffer */ -const u8 *tx_ptr;/* pointer in the Rx buffer */ -int remaining_bytes;/* the number of bytes left to transfer */ -}; - -static void xspi_init_hw (void __iomem *regs_base) +static void xspi_init_hw (struct xilinx_spi *xspi) {/* Reset the SPI device */ -out_be32 (regs_base +XIPIF_V123B_RESETR_OFFSET , -XIPIF_V123B_RESET_MASK ); +XSPI_WRITE32 (xspi,XIPIF_V123B_RESETR_OFFSET ,XIPIF_V123B_RESET_MASK );/* Disable all the interrupts just in case */ -out_be32 (regs_base +XIPIF_V123B_IIER_OFFSET ,0 ); +XSPI_WRITE32 (xspi,XIPIF_V123B_IIER_OFFSET ,0 );/* Enable the global IPIF interrupt */ -out_be32 (regs_base +XIPIF_V123B_DGIER_OFFSET , -XIPIF_V123B_GINTR_ENABLE ); +XSPI_WRITE32 (xspi,XIPIF_V123B_DGIER_OFFSET ,XIPIF_V123B_GINTR_ENABLE );/* Deselect the slave on the SPI bus */ -out_be32 (regs_base +XSPI_SSR_OFFSET ,0xffff ); +XSPI_WRITE32 (xspi, xspi->ssr_offset,0xffff );/* Disable the transmitter, enable Manual Slave Select Assertion, * put SPI controller into master mode, and enable it */ -out_be16 (regs_base +XSPI_CR_OFFSET , -XSPI_CR_TRANS_INHIBIT |XSPI_CR_MANUAL_SSELECT - |XSPI_CR_MASTER_MODE |XSPI_CR_ENABLE ); +XSPI_WRITE16 (xspi, xspi->cr_offset, +XSPI_CR_TRANS_INHIBIT |XSPI_CR_MANUAL_SSELECT | +XSPI_CR_MASTER_MODE |XSPI_CR_ENABLE |XSPI_CR_TXFIFO_RESET | +XSPI_CR_RXFIFO_RESET ); }static void xilinx_spi_chipselect (struct spi_device *spi,int is_on)
@@ -115,16 +161,16 @@if (is_on ==BITBANG_CS_INACTIVE ) {/* Deselect the slave on the SPI bus */ -out_be32 (xspi->regs +XSPI_SSR_OFFSET ,0xffff ); +XSPI_WRITE32 (xspi, xspi->ssr_offset,0xffff ); }else if (is_on ==BITBANG_CS_ACTIVE ) {/* Set the SPI clock phase and polarity */ -u16 cr =in_be16 (xspi->regs +XSPI_CR_OFFSET ) +u32 cr =XSPI_READ16 (xspi, xspi->cr_offset) & ~XSPI_CR_MODE_MASK ;if (spi->mode &SPI_CPHA ) cr |=XSPI_CR_CPHA ;if (spi->mode &SPI_CPOL ) cr |=XSPI_CR_CPOL ; -out_be16 (xspi->regs +XSPI_CR_OFFSET , cr); +XSPI_WRITE16 (xspi, xspi->cr_offset, cr);/* We do not check spi->max_speed_hz here as the SPI clock * frequency is not software programmable (the IP block design
@@ -132,7 +178,7 @@*/ /* Activate the chip select */ -out_be32 (xspi->regs +XSPI_SSR_OFFSET , +XSPI_WRITE32 (xspi, xspi->ssr_offset, ~(0x0001 << spi->chip_select)); } }
@@ -144,12 +190,13 @@* added here as soon as bitbang_work() can be made aware of the delay value. */ static int xilinx_spi_setup_transfer (struct spi_device *spi, -struct spi_transfer *t) +struct spi_transfer *t) {u8 bits_per_word; +struct xilinx_spi *xspi =spi_master_get_devdata (spi->master); bits_per_word = (t) ? t->bits_per_word : spi->bits_per_word; -if (bits_per_word !=8 ) { +if (bits_per_word != xspi->bits_per_word) {dev_err (&spi->dev,"%s, unsupported bits_per_word=%d\n" , __func__, bits_per_word);return -EINVAL ;
@@ -171,7 +218,7 @@ bitbang = &xspi->bitbang;if (!spi->bits_per_word) - spi->bits_per_word =8 ; + spi->bits_per_word = xspi->bits_per_word;if (spi->mode & ~MODEBITS ) { dev_err(&spi->dev, "%s, unsupported mode bits %x\n",
@@ -191,18 +238,35 @@static void xilinx_spi_fill_tx_fifo (struct xilinx_spi *xspi) { -u8 sr; +u32 sr; +u8 wsize; +if (xspi->bits_per_word ==8 ) + wsize =1 ; +else if (xspi->bits_per_word ==16 ) + wsize =2 ; +else + wsize =4 ;/* Fill the Tx FIFO with as many bytes as possible */ - sr =in_8 (xspi->regs +XSPI_SR_OFFSET ); -while ((sr &XSPI_SR_TX_FULL_MASK ) ==0 && xspi->remaining_bytes >0 ) { + sr =XSPI_READ8 (xspi, xspi->sr_offset); +while ((sr &XSPI_SR_TX_FULL_MASK ) ==0 && + xspi->remaining_bytes >0 ) {if (xspi->tx_ptr) { -out_8 (xspi->regs +XSPI_TXD_OFFSET , *xspi->tx_ptr++); - }else { -out_8 (xspi->regs +XSPI_TXD_OFFSET ,0 ); - } - xspi->remaining_bytes--; - sr =in_8 (xspi->regs +XSPI_SR_OFFSET ); +if (wsize ==1 ) +XSPI_WRITE8 (xspi, xspi->txd_offset, + *xspi->tx_ptr); +else if (wsize ==2 ) +XSPI_WRITE16 (xspi, xspi->txd_offset, + *(u16 *)(xspi->tx_ptr)); +else if (wsize ==4 ) +XSPI_WRITE32 (xspi, xspi->txd_offset, + *(u32 *)(xspi->tx_ptr)); + + xspi->tx_ptr += wsize; + }else +XSPI_WRITE8 (xspi, xspi->txd_offset,0 ); + xspi->remaining_bytes -= wsize; + sr =XSPI_READ8 (xspi, xspi->sr_offset); } }
@@ -210,7 +274,7 @@ {struct xilinx_spi *xspi =spi_master_get_devdata (spi->master);u32 ipif_ier; -u16 cr; +u32 cr;/* We get here with transmitter inhibited */
@@ -224,23 +288,22 @@/* Enable the transmit empty interrupt, which we use to determine * progress on the transmission. */ - ipif_ier =in_be32 (xspi->regs +XIPIF_V123B_IIER_OFFSET ); -out_be32 (xspi->regs +XIPIF_V123B_IIER_OFFSET , + ipif_ier =XSPI_READ32 (xspi,XIPIF_V123B_IIER_OFFSET ); +XSPI_WRITE32 (xspi,XIPIF_V123B_IIER_OFFSET , ipif_ier |XSPI_INTR_TX_EMPTY );/* Start the transfer by not inhibiting the transmitter any longer */ - cr =in_be16 (xspi->regs +XSPI_CR_OFFSET ) & ~XSPI_CR_TRANS_INHIBIT ; -out_be16 (xspi->regs +XSPI_CR_OFFSET , cr); + cr =XSPI_READ16 (xspi, xspi->cr_offset) & ~XSPI_CR_TRANS_INHIBIT ; +XSPI_WRITE16 (xspi, xspi->cr_offset, cr);wait_for_completion (&xspi->done);/* Disable the transmit empty interrupt */ -out_be32 (xspi->regs +XIPIF_V123B_IIER_OFFSET , ipif_ier); +XSPI_WRITE32 (xspi,XIPIF_V123B_IIER_OFFSET , ipif_ier);return t->len - xspi->remaining_bytes; } -/* This driver supports single master mode only. Hence Tx FIFO Empty * is the only interrupt we care about. * Receive FIFO Overrun, Transmit FIFO Underrun, Mode Fault, and Slave Mode
@@ -252,32 +315,50 @@u32 ipif_isr;/* Get the IPIF interrupts, and clear them immediately */ - ipif_isr =in_be32 (xspi->regs +XIPIF_V123B_IISR_OFFSET ); -out_be32 (xspi->regs +XIPIF_V123B_IISR_OFFSET , ipif_isr); + ipif_isr =XSPI_READ32 (xspi,XIPIF_V123B_IISR_OFFSET ); +XSPI_WRITE32 (xspi,XIPIF_V123B_IISR_OFFSET , ipif_isr);if (ipif_isr &XSPI_INTR_TX_EMPTY ) {/* Transmission completed */ -u16 cr; -u8 sr; +u32 cr; +u32 sr; +u8 rsize; +if (xspi->bits_per_word ==8 ) + rsize =1 ; +else if (xspi->bits_per_word ==16 ) + rsize =2 ; +else + rsize =4 ;/* A transmit has just completed. Process received data and * check for more data to transmit. Always inhibit the * transmitter while the Isr refills the transmit register/FIFO, * or make sure it is stopped if we're done. */ - cr =in_be16 (xspi->regs +XSPI_CR_OFFSET ); -out_be16 (xspi->regs +XSPI_CR_OFFSET , - cr |XSPI_CR_TRANS_INHIBIT ); + cr =XSPI_READ16 (xspi, xspi->cr_offset); +XSPI_WRITE16 (xspi, xspi->cr_offset, cr |XSPI_CR_TRANS_INHIBIT );/* Read out all the data from the Rx FIFO */ - sr =in_8 (xspi->regs +XSPI_SR_OFFSET ); + sr =XSPI_READ8 (xspi, xspi->sr_offset);while ((sr &XSPI_SR_RX_EMPTY_MASK ) ==0 ) { -u8 data; +u32 data; +if (rsize ==1 ) + data =XSPI_READ8 (xspi, xspi->rxd_offset); +else if (rsize ==2 ) + data =XSPI_READ16 (xspi, xspi->rxd_offset); +else + data =XSPI_READ32 (xspi, xspi->rxd_offset); - data =in_8 (xspi->regs +XSPI_RXD_OFFSET );if (xspi->rx_ptr) { - *xspi->rx_ptr++ = data; +if (rsize ==1 ) + *xspi->rx_ptr = data &0xff ; +else if (rsize ==2 ) + *(u16 *)(xspi->rx_ptr) = data &0xffff ; +else + *((u32 *)(xspi->rx_ptr)) = data; + xspi->rx_ptr += rsize; } - sr =in_8 (xspi->regs +XSPI_SR_OFFSET ); + + sr =XSPI_READ8 (xspi, xspi->sr_offset); }/* See if there is more data to send */
@@ -286,7 +367,7 @@/* Start the transfer by not inhibiting the * transmitter any longer */ -out_be16 (xspi->regs +XSPI_CR_OFFSET , cr); +XSPI_WRITE16 (xspi, xspi->cr_offset, cr); }else {/* No more data to send. * Indicate the transfer is completed.
@@ -294,45 +375,21 @@complete (&xspi->done); } } -return IRQ_HANDLED ; } -static int __init xilinx_spi_of_probe (struct of_device *ofdev, -const struct of_device_id *match) +struct spi_master *xilinx_spi_init (struct device *dev,struct resource *mem, +u32 irq,u8 model,s16 bus_num,u16 num_chipselect,u8 bits_per_word) {struct spi_master *master;struct xilinx_spi *xspi; -struct resource r_irq_struct; -struct resource r_mem_struct; +int ret =0 ; -struct resource *r_irq = &r_irq_struct; -struct resource *r_mem = &r_mem_struct; -int rc =0 ; -const u32 *prop; -int len; + master =spi_alloc_master (dev,sizeof (struct xilinx_spi )); -/* Get resources(memory, IRQ) associated with the device */ - master =spi_alloc_master (&ofdev->dev,sizeof (struct xilinx_spi )); +if (master ==NULL ) +return ERR_PTR (-ENOMEM ); -if (master ==NULL ) { -return -ENOMEM ; - } - -dev_set_drvdata (&ofdev->dev, master); - - rc =of_address_to_resource (ofdev->node,0 , r_mem); -if (rc) { -dev_warn (&ofdev->dev,"invalid address\n" ); - goto put_master; - } - - rc =of_irq_to_resource (ofdev->node,0 , r_irq); -if (rc ==NO_IRQ ) { -dev_warn (&ofdev->dev,"no IRQ found\n" ); - goto put_master; - } - xspi =spi_master_get_devdata (master); xspi->bitbang.master =spi_master_get (master); xspi->bitbang.chipselect = xilinx_spi_chipselect;
@@ -341,128 +398,87 @@ xspi->bitbang.master->setup = xilinx_spi_setup;init_completion (&xspi->done); - xspi->irq = r_irq->start; - -if (!request_mem_region (r_mem->start, - r_mem->end - r_mem->start +1 ,XILINX_SPI_NAME )) { - rc = -ENXIO ; -dev_warn (&ofdev->dev,"memory request failure\n" ); +if (!request_mem_region (mem->start,resource_size (mem), +XILINX_SPI_NAME )) { + ret = -ENXIO ; goto put_master; } - xspi->regs =ioremap (r_mem->start, r_mem->end - r_mem->start +1 ); + xspi->regs =ioremap (mem->start,resource_size (mem));if (xspi->regs ==NULL ) { - rc = -ENOMEM ; -dev_warn (&ofdev->dev,"ioremap failure\n" ); - goto release_mem; + ret = -ENOMEM ; +dev_warn (dev,"ioremap failure\n" ); + goto map_failed; } - xspi->irq = r_irq->start; -/* dynamic bus assignment */ - master->bus_num =-1 ; + master->bus_num = bus_num; + master->num_chipselect = num_chipselect; -/* number of slave select bits is required */ - prop =of_get_property (ofdev->node,"xlnx,num-ss-bits" , &len); -if (!prop || len <sizeof (*prop)) { -dev_warn (&ofdev->dev,"no 'xlnx,num-ss-bits' property\n" ); - goto unmap_io; + xspi->mem = *mem; + xspi->irq = irq; + xspi->bits_per_word = bits_per_word; + xspi->model = model; + +if (model ==XILINX_SPI_MODEL_DS464 ) { + xspi->cr_offset =XSPI_CR_OFFSET_DS464 ; + xspi->sr_offset =XSPI_SR_OFFSET_DS464 ; + xspi->txd_offset =XSPI_TXD_OFFSET_DS464 ; + xspi->rxd_offset =XSPI_RXD_OFFSET_DS464 ; + xspi->ssr_offset =XSPI_SSR_OFFSET_DS464 ; + }else { + xspi->cr_offset =XSPI_CR_OFFSET_DS570 ; + xspi->sr_offset =XSPI_SR_OFFSET_DS570 ; + xspi->txd_offset =XSPI_TXD_OFFSET_DS570 ; + xspi->rxd_offset =XSPI_RXD_OFFSET_DS570 ; + xspi->ssr_offset =XSPI_SSR_OFFSET_DS570 ; } - master->num_chipselect = *prop;/* SPI controller initializations */ -xspi_init_hw (xspi->regs); +xspi_init_hw (xspi);/* Register for SPI Interrupt */ - rc =request_irq (xspi->irq, xilinx_spi_irq,0 ,XILINX_SPI_NAME , xspi); -if (rc !=0 ) { -dev_warn (&ofdev->dev,"irq request failure: %d\n" , xspi->irq); + ret =request_irq (xspi->irq, xilinx_spi_irq,0 ,XILINX_SPI_NAME , xspi); +if (ret !=0 ) goto unmap_io; - } - rc =spi_bitbang_start (&xspi->bitbang); -if (rc !=0 ) { -dev_err (&ofdev->dev,"spi_bitbang_start FAILED\n" ); + ret =spi_bitbang_start (&xspi->bitbang); +if (ret !=0 ) { +dev_err (dev,"spi_bitbang_start FAILED\n" ); goto free_irq; } -dev_info (&ofdev->dev,"at 0x%08X mapped to 0x%08X, irq=%d\n" , - (unsigned int )r_mem->start, (u32 )xspi->regs, xspi->irq); +dev_info (dev,"at 0x%08X mapped to 0x%08X, irq=%d\n" , + (u32 )mem->start, (u32 )xspi->regs, xspi->irq); +return master; -/* Add any subnodes on the SPI bus */ -of_register_spi_devices (master, ofdev->node); - -return rc; - free_irq:free_irq (xspi->irq, xspi); unmap_io:iounmap (xspi->regs); -release_mem: -release_mem_region (r_mem->start,resource_size (r_mem)); +map_failed: +release_mem_region (mem->start,resource_size (mem)); put_master:spi_master_put (master); -return rc; +return ERR_PTR (ret); } +EXPORT_SYMBOL (xilinx_spi_init); -static int __devexit xilinx_spi_remove(struct of_device *ofdev) +void xilinx_spi_deinit (struct spi_master *master) {struct xilinx_spi *xspi; -struct spi_master *master; -struct resource r_mem; - master =platform_get_drvdata (ofdev); xspi =spi_master_get_devdata (master);spi_bitbang_stop (&xspi->bitbang);free_irq (xspi->irq, xspi);iounmap (xspi->regs); -if (!of_address_to_resource (ofdev->node,0 , &r_mem)) -release_mem_region (r_mem.start,resource_size (&r_mem)); -dev_set_drvdata (&ofdev->dev,0 ); + +release_mem_region (xspi->mem.start,resource_size (&xspi->mem));spi_master_put (xspi->bitbang.master); - -return 0 ; } +EXPORT_SYMBOL (xilinx_spi_deinit); -/* work with hotplug and coldplug */ -MODULE_ALIAS ("platform:" XILINX_SPI_NAME ); - -static int __exit xilinx_spi_of_remove(struct of_device *op) -{ -return xilinx_spi_remove (op); -} - -static struct of_device_id xilinx_spi_of_match[] = { - { .compatible ="xlnx,xps-spi-2.00.a" , }, - { .compatible ="xlnx,xps-spi-2.00.b" , }, - {} -}; - -MODULE_DEVICE_TABLE (of, xilinx_spi_of_match); - -static struct of_platform_driver xilinx_spi_of_driver = { - .owner =THIS_MODULE , - .name ="xilinx-xps-spi" , - .match_table = xilinx_spi_of_match, - .probe = xilinx_spi_of_probe, - .remove =__exit_p (xilinx_spi_of_remove), - .driver = { - .name ="xilinx-xps-spi" , - .owner =THIS_MODULE , - }, -}; - -static int __init xilinx_spi_init (void ) -{ -return of_register_platform_driver (&xilinx_spi_of_driver); -} -module_init (xilinx_spi_init); - -static void __exit xilinx_spi_exit(void) -{ -of_unregister_platform_driver (&xilinx_spi_of_driver); -} -module_exit (xilinx_spi_exit);MODULE_AUTHOR ("MontaVista Software, Inc. <[email protected]>" );MODULE_DESCRIPTION ("Xilinx SPI driver" );MODULE_LICENSE ("GPL" ); +
drivers/spi/xilinx_spi_of.c +123 -0
123 lines not on this page · raw message
drivers/spi/xilinx_spi_pltfm.c +104 -0
104 lines not on this page · raw message
drivers/spi/xilinx_spi.h +27 -0
@@ -0,0 +1,27 @@ +/* +* xilinx_spi.c +* +* Xilinx SPI controller driver (master mode only) +* +* Author: MontaVista Software, Inc. +* [email protected] +* +* 2002-2007 (c) MontaVista Software, Inc. This file is licensed under the +* terms of the GNU General Public License version 2. This program is licensed +* "as is" without any warranty of any kind, whether express or implied. +*/ + +#ifndef _XILINX_SPI_H_ +#define _XILINX_SPI_H_ 1 + +#include <linux/spi/spi.h> +#include <linux/spi/spi_bitbang.h> +#include <linux/spi/xilinx_spi.h> + +#define XILINX_SPI_NAME "xilinx_spi" + +struct spi_master *xilinx_spi_init (struct device *dev,struct resource *mem, +u32 irq,u8 model,s16 bus_num,u16 num_chipselect,u8 bits_per_word); + +void xilinx_spi_deinit (struct spi_master *master); +#endif
drivers/spi/Kconfig +21 -2
@@ -211,8 +211,8 @@ SPI driver for Toshiba TXx9 MIPS SoCs config SPI_XILINX - tristate "Xilinx SPI controller" - depends on XILINX_VIRTEX && EXPERIMENTAL + tristate "Xilinx SPI controller common module" + depends on EXPERIMENTAL select SPI_BITBANG help This exposes the SPI controller IP from the Xilinx EDK.
@@ -220,6 +220,25 @@ See the "OPB Serial Peripheral Interface (SPI) (v1.00e)" Product Specification document (DS464) for hardware details. +config SPI_XILINX_OF + tristate "Xilinx SPI controller OF device" + depends on SPI_XILINX && XILINX_VIRTEX + help + This exposes the SPI controller IP from the Xilinx EDK. + + See the "OPB Serial Peripheral Interface (SPI) (v1.00e)" + Product Specification document (DS464) for hardware details. + +config SPI_XILINX_PLTFM + tristate "Xilinx SPI controller platform device" + depends on SPI_XILINX + help + This exposes the SPI controller IP from the Xilinx EDK. + + See the "OPB Serial Peripheral Interface (SPI) (v1.00e)" + Product Specification document (DS464) for hardware details. + + # # Add new SPI master controllers in alphabetical order above this line #
drivers/spi/Makefile +2 -0
@@ -29,6 +29,8 @@ obj-$(CONFIG_SPI_S3C24XX) += spi_s3c24xx.o obj-$(CONFIG_SPI_TXX9) += spi_txx9.o obj-$(CONFIG_SPI_XILINX) += xilinx_spi.o +obj-$(CONFIG_SPI_XILINX_OF) += xilinx_spi_of.o +obj-$(CONFIG_SPI_XILINX_PLTFM) += xilinx_spi_pltfm.o obj-$(CONFIG_SPI_SH_SCI) += spi_sh_sci.o # ... add above this line ...
include/linux/spi/xilinx_spi.h +19 -0
@@ -0,0 +1,19 @@ +#ifndef __LINUX_SPI_XILINX_SPI_H +#define __LINUX_SPI_XILINX_SPI_H + +#define XILINX_SPI_MODEL_DS464 0 +#define XILINX_SPI_MODEL_DS570 1 + +/* SPI Controller IP */ +struct xspi_platform_data { +s16 bus_num; +u16 num_chipselect; +u8 model; +u8 bits_per_word; +/* devices to add to the bus when the host is up */ +struct spi_board_info *devices; +u8 num_devices; +}; + +#endif /* __LINUX_SPI_XILINX_SPI_H */ +
Quoted 5 lines · On Fri, 05 Jun 2009 15:40:19 +0200 Richard R__jfors…
This patch splits
xilinx_spiinto three parts, an OF and a platform driver and generic part.The generic part now also works on X86 and also supports the Xilinx SPI IP DS570
Unfortunately we already have two fairly significant drivers/spi/xilinx_spi.c patches queued in -mm:
spi-move-more-spi_setup-functionality-into-core.patch and spi-move-common-spi_setup-functionality-into-core.patch. Applying this patch on top of those makes rather a mess.
Hopefully things will still be OK if I skip this patch. You didn't identify the dependencies between those nine patchs. Can you please explain that?
------------------------------------------------------------------------------
Crystal Reports - New Free Runtime and 30 Day Trial
Check out the new simplified licensing option that enables unlimited royalty-free distribution of the report engine for externally facing server and web deployment.
http://p.sf.net/sfu/businessobjects
Quoted 15 lines · Andrew Morton
Quoted 5 lines · On Fri, 05 Jun 2009 15:40:19 +0200 Richard R__jfors…
This patch splits
xilinx_spiinto three parts, an OF and a platform driver and generic part.The generic part now also works on X86 and also supports the Xilinx SPI IP DS570
Unfortunately we already have two fairly significant
drivers/spi/xilinx_spi.cpatches queued in -mm:
spi-move-more-spi_setup-functionality-into-core.patch and spi-move-common-spi_setup-functionality-into-core.patch. Applying this patch on top of those makes rather a mess.
Quoted 3 lines
Hopefully things will still be OK if I skip this patch. You didn't identify the dependencies between those nine patchs. Can you please explain that?
Actually all patches except for the 7th(of 9), would work without the xilinx_spi-patch.
The 7th (Timberdale MFD) would not build. Some of the othe drivers are not possible to select because they depend on the MFD in their Kconfigs, but not the code.
I would be very happy if you applied all but the 7th (MFD) and 2nd (SPI) anyway.
I will update my SPI-patch to work against the two patches you point out above. And them I will resend the Timberdale MFD and the Xilinx SPI patch.
Would that be OK?
--Richard
Quoted 20 lines · On Wed, 10 Jun 2009 10:48:58 +0200 Richard R__jfors…
Quoted 15 lines · Andrew Morton
Quoted 5 lines · On Fri, 05 Jun 2009 15:40:19 +0200 Richard R__jfors…
This patch splits
xilinx_spiinto three parts, an OF and a platform driver and generic part.The generic part now also works on X86 and also supports the Xilinx SPI IP DS570
Unfortunately we already have two fairly significant
drivers/spi/xilinx_spi.cpatches queued in -mm:
spi-move-more-spi_setup-functionality-into-core.patch and spi-move-common-spi_setup-functionality-into-core.patch. Applying this patch on top of those makes rather a mess.Quoted 3 lines
Hopefully things will still be OK if I skip this patch. You didn't identify the dependencies between those nine patchs. Can you please explain that?
Quoted 5 lines
Actually all patches except for the 7th(of 9), would work without the xilinx_spi-patch.
The 7th (Timberdale MFD) would not build. Some of the othe drivers are not possible to select because they depend on the MFD in their Kconfigs, but not the code.
Confused.
See, my problem is that normally I will hold off on sending a patch to its subsystem maintainer until its prerequisite patch(es) are in mainline. But for each of these patches, I don't know what the exact prerequisites are. Help?
(The simple alternative is for me to seek acks and merge them all myself. But sometimes getting those acks is hard).
Quoted 6 lines
I would be very happy if you applied all but the 7th (MFD) and 2nd (SPI) anyway.
I will update my SPI-patch to work against the two patches you point out above. And them I will resend the Timberdale MFD and the Xilinx SPI patch.
Would that be OK?
That would be great, thanks.
Quoted 20 lines · Andrew Morton
Quoted 18 lines · On Wed, 10 Jun 2009 10:48:58 +0200 Richard R__jfors…
Quoted 17 lines · Andrew Morton
Quoted 5 lines · On Fri, 05 Jun 2009 15:40:19 +0200 Richard R__jfors…
This patch splits
xilinx_spiinto three parts, an OF and a platform driver and generic part.The generic part now also works on X86 and also supports the Xilinx SPI IP DS570
Unfortunately we already have two fairly significant
drivers/spi/xilinx_spi.cpatches queued in -mm:
spi-move-more-spi_setup-functionality-into-core.patch and spi-move-common-spi_setup-functionality-into-core.patch. Applying this patch on top of those makes rather a mess.Hopefully things will still be OK if I skip this patch. You didn't identify the dependencies between those nine patchs. Can you please explain that?
Quoted 7 lines
Quoted 5 lines
Actually all patches except for the 7th(of 9), would work without the xilinx_spi-patch.
The 7th (Timberdale MFD) would not build. Some of the othe drivers are not possible to select because they depend on the MFD in their Kconfigs, but not the code.Confused.
Sorry, will try to explain below.
Quoted 2 lines
See, my problem is that normally I will hold off on sending a patch to its subsystem maintainer until its prerequisite patch(es) are in mainline.
That was what I started doing, the MFD-driver requires plaform-data structs from some of the drivers.
On the other hand some of the drivers depends on the MFD conf-option, which you found in the GPIO-driver :-)
Quoted 2 lines
But for each of these patches, I don't know what the exact prerequisites are. Help?
Patch dependencies
1/9 -> (mc33880) no dependencies on my patches
2/9 -> (xilinx_spi) no dependencies on my patches
3/9 -> (i2c-ocores) no dependencies on my patches
4/9 -> (timb-dma) Kconfig depends on config set by timberdale (patch 7/9) 5/9 -> (logiwin) code depends on timb-dma (patch 4/9)
6/9 -> (v4l2 Kconfig) Kconfig depends on config set by timb-dma (patch(4/9) 7/9 -> (timberdale) code depends on mc3380 (patch 1/9), xilinx_spi (patch 2/9)
i2c-ocores (patch 3/9), logiwin (patch 5/9)
8/9 -> (timbserial) Kconfig depends on config set by timberdale (patch 7/9)
Btw Alan Cox said i has queued it for the ttydev stack, and it is further patched.
9/9 -> (timbgpio) Kconfig depends on config set by timberdale (patch 7/9)
So my suggestion is;
Apply all but patch 2 and 7. They will apply, some have Kconfig dependencies to patch 7.
Quoted 8 lines
Quoted 6 lines
I would be very happy if you applied all but the 7th (MFD) and 2nd (SPI) anyway.
I will update my SPI-patch to work against the two patches you point out above. And them I will resend the Timberdale MFD and the Xilinx SPI patch.
Would that be OK?
That would be great, thanks.
I will come up with a patch as soon as possible.
Thanks
--Richard
PATCH v2 2/9 SPI: xilinx_spi: Added platform driver and support for DS570
This patch splits xilinx_spi into three parts, an OF and a platform driver and generic part.
The generic part now also works on X86 and also supports the Xilinx SPI IP DS570
---
drivers/spi/Kconfig +21 -2
@@ -211,8 +211,8 @@ SPI driver for Toshiba TXx9 MIPS SoCs config SPI_XILINX - tristate "Xilinx SPI controller" - depends on XILINX_VIRTEX && EXPERIMENTAL + tristate "Xilinx SPI controller common module" + depends on EXPERIMENTAL select SPI_BITBANG help This exposes the SPI controller IP from the Xilinx EDK.
@@ -220,6 +220,25 @@ See the "OPB Serial Peripheral Interface (SPI) (v1.00e)" Product Specification document (DS464) for hardware details. +config SPI_XILINX_OF + tristate "Xilinx SPI controller OF device" + depends on SPI_XILINX && XILINX_VIRTEX + help + This exposes the SPI controller IP from the Xilinx EDK. + + See the "OPB Serial Peripheral Interface (SPI) (v1.00e)" + Product Specification document (DS464) for hardware details. + +config SPI_XILINX_PLTFM + tristate "Xilinx SPI controller platform device" + depends on SPI_XILINX + help + This exposes the SPI controller IP from the Xilinx EDK. + + See the "OPB Serial Peripheral Interface (SPI) (v1.00e)" + Product Specification document (DS464) for hardware details. + + # # Add new SPI master controllers in alphabetical order above this line #
drivers/spi/xilinx_spi_of.c +123 -0
123 lines not on this page · raw message
drivers/spi/xilinx_spi.c +216 -200
615 lines not on this page · raw message
drivers/spi/xilinx_spi_pltfm.c +104 -0
104 lines not on this page · raw message
drivers/spi/Makefile +2 -0
@@ -29,6 +29,8 @@ obj-$(CONFIG_SPI_S3C24XX) += spi_s3c24xx.o obj-$(CONFIG_SPI_TXX9) += spi_txx9.o obj-$(CONFIG_SPI_XILINX) += xilinx_spi.o +obj-$(CONFIG_SPI_XILINX_OF) += xilinx_spi_of.o +obj-$(CONFIG_SPI_XILINX_PLTFM) += xilinx_spi_pltfm.o obj-$(CONFIG_SPI_SH_SCI) += spi_sh_sci.o # ... add above this line ...
include/linux/spi/xilinx_spi.h +19 -0
@@ -0,0 +1,19 @@ +#ifndef __LINUX_SPI_XILINX_SPI_H +#define __LINUX_SPI_XILINX_SPI_H + +#define XILINX_SPI_MODEL_DS464 0 +#define XILINX_SPI_MODEL_DS570 1 + +/* SPI Controller IP */ +struct xspi_platform_data { +s16 bus_num; +u16 num_chipselect; +u8 model; +u8 bits_per_word; +/* devices to add to the bus when the host is up */ +struct spi_board_info *devices; +u8 num_devices; +}; + +#endif /* __LINUX_SPI_XILINX_SPI_H */ +