Adding a composite device, how to structure ?
Wolfgang,
I would like to add support for the twl4030, a composite i2c device, found on the omap3 zoom's.
The header file will be include/twl4030.h.
How do you want the source to be structured ?
1. A single large file in drivers/i2c/twl4030.c
or device files added under a directory ?
2. drivers/i2c/twl4030/keyboard, drivers/i2c/twl4030/usb, drivers/i2c/twl4030/battery,
or just the common code in i2c and twl4030 devices in the places they usually go.
3. drivers/i2c/twl4030.c, drivers/usb/tw4030_usb.c etc ..
My guess is #3.
Tom
Dear Tom,
Quoted 12 lines · In message <[email protected]> you wrote:
I would like to add support for the twl4030, a composite i2c device, found on the omap3 zoom's.
The header file will beinclude/twl4030.h.
How do you want the source to be structured ?
1. A single large file indrivers/i2c/twl4030.cor device files added under a directory ?
2.
drivers/i2c/twl4030/keyboard,drivers/i2c/twl4030/usb,drivers/i2c/twl4030/battery,
Quoted 6 lines
or just the common code in i2c and twl4030 devices in the places they usually go.
3.
drivers/i2c/twl4030.c,drivers/usb/tw4030_usb.cetc ..My guess is #3.
My guess is so, too - but this is acually for Heiko to answer.
Heiko?
Best regards,
Wolfgang Denk
Signature · 6 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
If I don't document something, it's usually either for a good reason,
or a bad reason. In this case it's a good reason. :-)
- Larry Wall in <[email protected]>Hello Tom,
Quoted 11 lines · Tom
I would like to add support for the twl4030, a composite i2c device, found on the omap3 zoom's.
The header file will beinclude/twl4030.h.
How do you want the source to be structured ?
1. A single large file indrivers/i2c/twl4030.cor device files added under a directory ?
2.
drivers/i2c/twl4030/keyboard,drivers/i2c/twl4030/usb,drivers/i2c/twl4030/battery,
Quoted 6 lines
or just the common code in i2c and twl4030 devices in the places they usually go.
3.
drivers/i2c/twl4030.c,drivers/usb/tw4030_usb.cetc ..My guess is #3.
Yep, I think #3 is the right way to go.
bye
Heiko
Signature · 2 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany