Skip to contentSkip to conversation

sched: remove unneeded __ref tag

PATCH In review Li Zefan 2 participants 3 messages Jun 15, 2009 – Jun 17, 2009

lore
Share & tools
lore

Li Zefan

author
#0 lore raw

PATCH 1/1 sched: remove unneeded __ref tag

Those two functions no longer call alloc_bootmmem_cpumask_var(), so no need to tag them with __init_refok.

---
 kernel/sched.c        |    2 +-
 kernel/sched_cpupri.c |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
kernel/sched.c +1 -1
index 6032f51..54e47bc 100644
@@ -7828,7 +7828,7 @@ static void rq_attach_root(struct rq *rq, struct root_domain *rd)
 		free_rootdomain(old_rd);
 }
 
-static int __init_refok init_rootdomain(struct root_domain *rd, bool bootmem)
+static int init_rootdomain(struct root_domain *rd, bool bootmem)
 {
 	gfp_t gfp = GFP_KERNEL;
 
kernel/sched_cpupri.c +1 -1
index 7deffc9..e6c2517 100644
@@ -152,7 +152,7 @@ void cpupri_set(struct cpupri *cp, int cpu, int newpri)
  *
  * Returns: -ENOMEM if memory fails.
  */
-int __init_refok cpupri_init(struct cpupri *cp, bool bootmem)
+int cpupri_init(struct cpupri *cp, bool bootmem)
 {
 	gfp_t gfp = GFP_KERNEL;
 	int i;
Signature · 1 line
1.5.4.rc3
Acked-by on v1 1/1
#1 lore raw
Quoted 4 lines · Li Zefan

Those two functions no longer call alloc_bootmmem_cpumask_var(), so no need to tag them with __init_refok.

Thanks Li!

Quoted 40 lines

---
 kernel/sched.c        |    2 +-
 kernel/sched_cpupri.c |    2 +-

 2 files changed, 2 insertions(+), 2 deletions(-)
kernel/sched.c +1 -1
index 6032f51..54e47bc 100644
@@ -7828,7 +7828,7 @@ static void rq_attach_root(struct rq *rq, struct root_domain *rd)
                free_rootdomain(old_rd);
  }
 
-static int __init_refok init_rootdomain(struct root_domain *rd, bool bootmem)
+static int init_rootdomain(struct root_domain *rd, bool bootmem)
  {
        gfp_t gfp = GFP_KERNEL;
 
kernel/sched_cpupri.c +1 -2
index 7deffc9..e6c2517 100644
@@ -152,7 +152,7 @@ void cpupri_set(struct cpupri *cp, int cpu, int newpri)
  *
  * Returns: -ENOMEM if memory fails.
  */
-int __init_refok cpupri_init(struct cpupri *cp, bool bootmem)
+int cpupri_init(struct cpupri *cp, bool bootmem)
  {
        gfp_t gfp = GFP_KERNEL;
        int i;
--

1.5.4.rc3

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

#2 lore raw

[tip:sched/urgent] sched: Remove unneeded __ref tag

In reply to Li Zefan
Commit-ID:  fd5e1b5dbaa8b4aacc0e251d74182eda37062194
Gitweb:     http://git.kernel.org/tip/fd5e1b5dbaa8b4aacc0e251d74182eda37062194
Author:     Li Zefan <[email protected]>
AuthorDate: Mon, 15 Jun 2009 13:34:19 +0800
Committer:  Ingo Molnar <[email protected]>
CommitDate: Wed, 17 Jun 2009 16:08:04 +0200

sched: Remove unneeded __ref tag

Those two functions no longer call alloc_bootmmem_cpumask_var(), so no need to tag them with __init_refok.

LKML-Reference: <[email protected]>

---
 kernel/sched.c        |    2 +-
 kernel/sched_cpupri.c |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
kernel/sched.c +1 -1
index 8fb88a9..0056795 100644
@@ -7828,7 +7828,7 @@ static void rq_attach_root(struct rq *rq, struct root_domain *rd)
 		free_rootdomain(old_rd);
 }
 
-static int __init_refok init_rootdomain(struct root_domain *rd, bool bootmem)
+static int init_rootdomain(struct root_domain *rd, bool bootmem)
 {
 	gfp_t gfp = GFP_KERNEL;
 
kernel/sched_cpupri.c +1 -1
index 7deffc9..e6c2517 100644
@@ -152,7 +152,7 @@ void cpupri_set(struct cpupri *cp, int cpu, int newpri)
  *
  * Returns: -ENOMEM if memory fails.
  */
-int __init_refok cpupri_init(struct cpupri *cp, bool bootmem)
+int cpupri_init(struct cpupri *cp, bool bootmem)
 {
 	gfp_t gfp = GFP_KERNEL;
 	int i;