Skip to contentSkip to conversation

restore_ipc_ns: set ret=0 if no error

PATCH In review Serge E. Hallyn 2 participants 2 messages Jun 15, 2009 1 message not in the archive

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 restore_ipc_ns: set ret=0 if no error

Why pretend there's an error when there isn't?

(Without this, all restarts fail with CONFIG_UTS_NS or CONFIG_IPC_NS on)

---
 kernel/nsproxy.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
kernel/nsproxy.c +1 -0
index e3db0b9..5fae13c 100644
@@ -308,6 +308,7 @@ static struct nsproxy *do_restore_ns(struct ckpt_ctx *ctx)
 	nsproxy = create_nsproxy();
 	if (!nsproxy)
 		goto out;
+	ret = 0;
 
 	get_uts_ns(uts_ns);
 	nsproxy->uts_ns = uts_ns;
Signature · 1 line
1.6.1

A message that is not in the archive (sent off-list or not yet received): 20090615205911.GA18820-r/[email protected]

#2 lore raw

Heh .. I already hit this one and fixed - I am finishing a few more fixes before pushing them all.

Thanks :)

Quoted 22 lines · Serge E. Hallyn

Why pretend there's an error when there isn't?

(Without this, all restarts fail with CONFIG_UTS_NS or CONFIG_IPC_NS on)

---
 kernel/nsproxy.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
kernel/nsproxy.c +1 -0
index e3db0b9..5fae13c 100644
@@ -308,6 +308,7 @@ static struct nsproxy *do_restore_ns(struct ckpt_ctx *ctx)
 	nsproxy = create_nsproxy();
 	if (!nsproxy)
 		goto out;
+	ret = 0;
 
 	get_uts_ns(uts_ns);
 	nsproxy->uts_ns = uts_ns;