Skip to contentSkip to conversation

mlx4_en: Removed redundant check on lso header size

PATCH In review Yevgeny Petrilin 1 participant 1 message Jun 21, 2009

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 5/6 mlx4_en: Removed redundant check on lso header size

This check that verifies that the LSO header along with control segment and first data segment do not cross 128 bytes is no longer required.

---
 drivers/net/mlx4/en_tx.c   |    5 -----
 drivers/net/mlx4/mlx4_en.h |    1 -
 2 files changed, 0 insertions(+), 6 deletions(-)
drivers/net/mlx4/en_tx.c +0 -5
index 99a6a36..08c43f2 100644
@@ -518,11 +518,6 @@ static int get_real_size(struct sk_buff *skb, struct net_device *dev,
 				return 0;
 			}
 		}
-		if (unlikely(*lso_header_size > MAX_LSO_HDR_SIZE)) {
-			if (netif_msg_tx_err(priv))
-				en_warn(priv, "LSO header size too big\n");
-			return 0;
-		}
 	} else {
 		*lso_header_size = 0;
 		if (!is_inline(skb, NULL))
drivers/net/mlx4/mlx4_en.h +0 -1
index d43a9e4..ad861db 100644
@@ -99,7 +99,6 @@
 #define RSS_FACTOR		2
 #define TXBB_SIZE		64
 #define HEADROOM		(2048 / TXBB_SIZE + 1)
-#define MAX_LSO_HDR_SIZE	92
 #define STAMP_STRIDE		64
 #define STAMP_DWORDS		(STAMP_STRIDE / 4)
 #define STAMP_SHIFT		31
Signature · 1 line
1.6.0