adfs: remove redundant test on unsigned
PATCH 1/1 adfs: remove redundant test on unsigned
unsigned block cannot be less than 0.
Signed-off-by Roel Kluin <[email protected]>
---
Or should it read
if (!create) {
if (block >= inode->i_blocks)
goto abort_toobig;
...
} else if (block >= inode->i_blocks) {
adfs_error(inode->i_sb, "block %d < 0", block);
return -EIO;
}?
fs/adfs/inode.c +0 -7
@@ -19,9 +19,6 @@ static int adfs_get_block(struct inode *inode, sector_t block, struct buffer_head *bh, int create) { - if (block < 0) - goto abort_negative; - if (!create) { if (block >= inode->i_blocks) goto abort_toobig;
@@ -34,10 +31,6 @@ adfs_get_block(struct inode *inode, sector_t block, struct buffer_head *bh,/* don't support allocation of blocks yet */ return -EIO ; -abort_negative: -adfs_error (inode->i_sb,"block %d < 0" , block); -return -EIO ; - abort_toobig:return 0 ; }