Skip to contentSkip to conversation

ext4: remove redundant test on unsigned

PATCH Applied Roel Kluin 2 participants 2 messages Jun 22, 2009 – Aug 11, 2009 ext4 file system

lore
Share & tools
lore

Roel Kluin

author
#0 lore raw

PATCH 1/1 ext4: remove redundant test on unsigned

unsigned i_block cannot be less than 0.

Signed-off-by Roel Kluin <[email protected]>

---
Maybe a test `if (i_block > MAX)' but what should MAX be?

fs/ext4/inode.c +1 -3
index 7c17ae2..3cd567d 100644
@@ -343,9 +343,7 @@ static int ext4_block_to_path(struct inode *inode,
 	int n = 0;
 	int final = 0;
 
-	if (i_block < 0) {
-		ext4_warning(inode->i_sb, "ext4_block_to_path", "block < 0");
-	} else if (i_block < direct_blocks) {
+	if (i_block < direct_blocks) {
 		offsets[n++] = i_block;
 		final = direct_blocks;
 	} else if ((i_block -= direct_blocks) < indirect_blocks) {